From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7665BC11F66 for ; Mon, 12 Jul 2021 20:11:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5711860FF0 for ; Mon, 12 Jul 2021 20:11:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236563AbhGLUOS (ORCPT ); Mon, 12 Jul 2021 16:14:18 -0400 Received: from mail-io1-f42.google.com ([209.85.166.42]:40711 "EHLO mail-io1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231693AbhGLUOR (ORCPT ); Mon, 12 Jul 2021 16:14:17 -0400 Received: by mail-io1-f42.google.com with SMTP id l5so24221785iok.7; Mon, 12 Jul 2021 13:11:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8vx4roC1t44uRDMKvtWy4G2yQadZ8UNHNbyeeJaYsn8=; b=LAVFBR4oVqYY59xvJp8Iqdlh+9CY2iBYYRo/peTDXCNvknUbLH5fkgOyXQhxDP/rWH PZjS78GOv+CECylGdII/NLSbwSedwzz2DP9ylelmP2icKq9spycQI5ixrz49vqEqCxo4 SNK3rg546ThkybPbOXi0tKzzKAmHiLLznJPSEF9iJJXWOziQPylIKQUCa2PjcXjjjxf3 D32v7FO/8iBZmDw8wch2Y0Tz2lpmVNl4w0Ka70WReXZ8jguU025pxYZVXplnm5wghayC Z1cz6RiaRpJd8D8wqdVsuTZAWc6Hl3AyBiGxP9LzaBFBprisfBZrnoSKmGRMq34VI26B CsJQ== X-Gm-Message-State: AOAM531kfHPY71seyoMCV1MU+P0kQMsrWQWbZmtibO7CztMly59m6a/U A/YGvU4Lk+aOwIGHmOaiQw== X-Google-Smtp-Source: ABdhPJzP9Tl9BuIS+smxRdFk4eVQWlMsI8BnrQqgRg+s0VguhaQEmbN+761bl/F8klabtu8ZkVtT5Q== X-Received: by 2002:a02:6946:: with SMTP id e67mr674179jac.4.1626120688898; Mon, 12 Jul 2021 13:11:28 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id m20sm2261259ioc.39.2021.07.12.13.11.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 13:11:28 -0700 (PDT) Received: (nullmailer pid 2407738 invoked by uid 1000); Mon, 12 Jul 2021 20:11:25 -0000 Date: Mon, 12 Jul 2021 14:11:25 -0600 From: Rob Herring To: Corentin Labbe List-Id: Cc: arnd@arndb.de, linus.walleij@linaro.org, olof@lixom.net, soc@kernel.org, ulli.kroll@googlemail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/5] ARM: gemini: add device tree for ssi1328 Message-ID: <20210712201125.GA2401230@robh.at.kernel.org> References: <20210618205533.1527384-1-clabbe@baylibre.com> <20210618205533.1527384-6-clabbe@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210618205533.1527384-6-clabbe@baylibre.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 18, 2021 at 08:55:33PM +0000, Corentin Labbe wrote: > The SSI 1328 is a NAS box running a SL3516 SoC. > > Signed-off-by: Corentin Labbe > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/gemini-ssi1328.dts | 138 +++++++++++++++++++++++++++ > 2 files changed, 139 insertions(+) > create mode 100644 arch/arm/boot/dts/gemini-ssi1328.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 806715f3266d..49bf7af72111 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -221,6 +221,7 @@ dtb-$(CONFIG_ARCH_GEMINI) += \ > gemini-rut1xx.dtb \ > gemini-sl93512r.dtb \ > gemini-sq201.dtb \ > + gemini-ssi1328.dtb \ > gemini-wbd111.dtb \ > gemini-wbd222.dtb > dtb-$(CONFIG_ARCH_HI3xxx) += \ > diff --git a/arch/arm/boot/dts/gemini-ssi1328.dts b/arch/arm/boot/dts/gemini-ssi1328.dts > new file mode 100644 > index 000000000000..2b3e7db84fed > --- /dev/null > +++ b/arch/arm/boot/dts/gemini-ssi1328.dts > @@ -0,0 +1,138 @@ > +// SPDX-License-Identifier: GPL-2.0 Dual license? No one runs BSD or other OS on these devices? > +/* > + * Copyright (C) 2021 Corentin Labbe > + * Device Tree file for SSI 1328 > + */ > + > +/dts-v1/; > + > +#include "gemini.dtsi" Though the license should match this file. > + > +/ { > + model = "SSI 1328"; > + compatible = "ssi,1328", "cortina,gemini"; Where's ssi,1328 documented? > + #address-cells = <1>; > + #size-cells = <1>; > + > + memory@0 { > + /* 128 MB */ > + device_type = "memory"; > + reg = <0x00000000 0x8000000>; > + }; > + > + aliases { > + mdio-gpio0 = &mdio0; > + }; > + > + chosen { > + bootargs = "console=ttyS0,19200n8 initrd=0x900000,9M"; > + stdout-path = &uart0; Don't need both 'console' and stdout-path. (console should be removed) > + }; > + > + mdio0: mdio { > + compatible = "virtual,mdio-gpio"; > + gpios = <&gpio0 22 GPIO_ACTIVE_HIGH>, /* MDC */ > + <&gpio0 21 GPIO_ACTIVE_HIGH>; /* MDIO */ > + #address-cells = <1>; > + #size-cells = <0>; > + > + /* LAN Marvell 88E1118 */ > + phy0: ethernet-phy@1 { > + reg = <1>; > + device_type = "ethernet-phy"; > + /* We lack the knowledge of necessary GPIO to achieve > + * Gigabit > + */ > + max-speed = <100>; > + }; > + /* WAN ICPlus IP101A */ > + phy1: ethernet-phy@2 { > + reg = <2>; > + device_type = "ethernet-phy"; > + }; > + }; > +}; > + > +ðernet { > + status = "okay"; > + ethernet-port@0 { > + phy-mode = "rgmii"; > + phy-handle = <&phy0>; > + }; > + ethernet-port@1 { > + phy-mode = "rgmii"; > + phy-handle = <&phy1>; > + }; > +}; > + > +&flash { > + status = "okay"; > + /* 32MB of flash */ > + reg = <0x30000000 0x03200000>; > + > + pinctrl-names = "enabled", "disabled"; > + pinctrl-0 = <&pflash_default_pins>; > + pinctrl-1 = <&pflash_disabled_pins>; > + > + partitions { > + compatible = "redboot-fis"; > + /* Eraseblock at 0xfe0000 */ > + fis-index-block = <0x7F>; > + }; > +}; > + > +&gpio0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&gpio0_default_pins>; > +}; > + > +&ide0 { > + status = "okay"; > +}; > + > +&ide1 { > + status = "okay"; > +}; > + > +&sata { > + cortina,gemini-ata-muxmode = <0>; > + cortina,gemini-enable-sata-bridge; > + status = "okay"; > +}; > + > +&syscon { > + pinctrl { > + /* > + * gpio0agrp cover line 0-4 > + * gpio0bgrp cover line 5 > + */ > + gpio0_default_pins: pinctrl-gpio0 { > + mux { > + function = "gpio0"; > + groups = "gpio0agrp", "gpio0bgrp"; > + }; > + }; > + pflash_disabled_pins: pinctrl-pflash-disabled { > + mux { > + function = "gpio0"; > + groups = "gpio0ggrp", "gpio0igrp", "gpio0jgrp", > + "gpio0kgrp"; > + }; > + }; > + pinctrl-gmii { > + /* This platform use both the ethernet ports */ > + mux { > + function = "gmii"; > + groups = "gmii_gmac0_grp", "gmii_gmac1_grp"; > + }; > + }; > + }; > +}; > + > +&usb0 { > + status = "okay"; > +}; > + > +&usb1 { > + status = "okay"; > +}; > -- > 2.31.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18B3FC07E9C for ; Mon, 12 Jul 2021 20:13:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D02E061245 for ; Mon, 12 Jul 2021 20:13:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D02E061245 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=o19nb1gxZLdasstGu26gUl8qBqHSCyO0gtERp+FwQi8=; b=WS2RddAJJj1P9g EFC1DLTjGIWEdXpBx/ycI+/Zrqn/IbrrdKJplsvr7ViNa0b1qa+pXSCqCtNLdFNLhYotEi4i4FnVQ X67yUklKT3K08Dh858nuBOp0QAMb+UfJ/QYI0/6Wy7Qen28Wv9myZ1ZfiRYCBehsuYqQAIufhNJYx WLkdtil46ji1aYfidkqLP8dz2ipCtT1S9B8f6bmz46E1RwUa3Y/3Q3KgAlcHd6xct8tGmOB8+4/QY OXATU6tF/TDmlK4Mz80E0wefdwvLHz61PFSwmtvL23soUiMMXcirv6e9J7eXc4YPA5EoX1jlcdH5f x6IkqcDL7j+jtglQsSMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m32H8-008LdV-5c; Mon, 12 Jul 2021 20:11:34 +0000 Received: from mail-io1-f42.google.com ([209.85.166.42]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m32H4-008Lcf-GC for linux-arm-kernel@lists.infradead.org; Mon, 12 Jul 2021 20:11:31 +0000 Received: by mail-io1-f42.google.com with SMTP id z26so12734574ioz.11 for ; Mon, 12 Jul 2021 13:11:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8vx4roC1t44uRDMKvtWy4G2yQadZ8UNHNbyeeJaYsn8=; b=teEhFCy2Nnj/g02nso7KWLxcTXku18cIG4YSp3kfFlcnrGzlbQibCp0/FNnZws2X10 14mWOUg5P95IvqbygOAvwkamwuzSIcNSfwa64uyYFSHyaBRuwllcdQpKC2PHtA5WBRuR rlVdg786DGUtAHnSJqQB4eqzHfXL0VSvKHfqqa6kSEurtff7dxV3vYZMVclldfgPsP2B Fp2Cja+5geVpxYdHLEdZ/ispYdhANYs+Fp5iuu+aQJYBaTkkF9Co31n6ms5rTOAcWrKG t2a5IbzgUvmrK4KYNgMwaoWBnmFfrujpWEC1/1uBckCALqdKtzsAXdqxJ5jG25oeetye tc/w== X-Gm-Message-State: AOAM533wsNh7S9pyVAFphAMeYX5jaI66kfhMlZxSdl9gZEtuIcVIiRA0 lO2HWV/iQ0gTYJ0V8Al2/5ldwvJ2nA== X-Google-Smtp-Source: ABdhPJzP9Tl9BuIS+smxRdFk4eVQWlMsI8BnrQqgRg+s0VguhaQEmbN+761bl/F8klabtu8ZkVtT5Q== X-Received: by 2002:a02:6946:: with SMTP id e67mr674179jac.4.1626120688898; Mon, 12 Jul 2021 13:11:28 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id m20sm2261259ioc.39.2021.07.12.13.11.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 13:11:28 -0700 (PDT) Received: (nullmailer pid 2407738 invoked by uid 1000); Mon, 12 Jul 2021 20:11:25 -0000 Date: Mon, 12 Jul 2021 14:11:25 -0600 From: Rob Herring To: Corentin Labbe List-Id: Cc: arnd@arndb.de, linus.walleij@linaro.org, olof@lixom.net, soc@kernel.org, ulli.kroll@googlemail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/5] ARM: gemini: add device tree for ssi1328 Message-ID: <20210712201125.GA2401230@robh.at.kernel.org> References: <20210618205533.1527384-1-clabbe@baylibre.com> <20210618205533.1527384-6-clabbe@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210618205533.1527384-6-clabbe@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210712_131130_590377_47B8CAE2 X-CRM114-Status: GOOD ( 22.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Message-ID: <20210712201125.QliN-e4ezYcaHHdPivfEk1HkBxv1ilDsusJz4oAkC8k@z> On Fri, Jun 18, 2021 at 08:55:33PM +0000, Corentin Labbe wrote: > The SSI 1328 is a NAS box running a SL3516 SoC. > > Signed-off-by: Corentin Labbe > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/gemini-ssi1328.dts | 138 +++++++++++++++++++++++++++ > 2 files changed, 139 insertions(+) > create mode 100644 arch/arm/boot/dts/gemini-ssi1328.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 806715f3266d..49bf7af72111 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -221,6 +221,7 @@ dtb-$(CONFIG_ARCH_GEMINI) += \ > gemini-rut1xx.dtb \ > gemini-sl93512r.dtb \ > gemini-sq201.dtb \ > + gemini-ssi1328.dtb \ > gemini-wbd111.dtb \ > gemini-wbd222.dtb > dtb-$(CONFIG_ARCH_HI3xxx) += \ > diff --git a/arch/arm/boot/dts/gemini-ssi1328.dts b/arch/arm/boot/dts/gemini-ssi1328.dts > new file mode 100644 > index 000000000000..2b3e7db84fed > --- /dev/null > +++ b/arch/arm/boot/dts/gemini-ssi1328.dts > @@ -0,0 +1,138 @@ > +// SPDX-License-Identifier: GPL-2.0 Dual license? No one runs BSD or other OS on these devices? > +/* > + * Copyright (C) 2021 Corentin Labbe > + * Device Tree file for SSI 1328 > + */ > + > +/dts-v1/; > + > +#include "gemini.dtsi" Though the license should match this file. > + > +/ { > + model = "SSI 1328"; > + compatible = "ssi,1328", "cortina,gemini"; Where's ssi,1328 documented? > + #address-cells = <1>; > + #size-cells = <1>; > + > + memory@0 { > + /* 128 MB */ > + device_type = "memory"; > + reg = <0x00000000 0x8000000>; > + }; > + > + aliases { > + mdio-gpio0 = &mdio0; > + }; > + > + chosen { > + bootargs = "console=ttyS0,19200n8 initrd=0x900000,9M"; > + stdout-path = &uart0; Don't need both 'console' and stdout-path. (console should be removed) > + }; > + > + mdio0: mdio { > + compatible = "virtual,mdio-gpio"; > + gpios = <&gpio0 22 GPIO_ACTIVE_HIGH>, /* MDC */ > + <&gpio0 21 GPIO_ACTIVE_HIGH>; /* MDIO */ > + #address-cells = <1>; > + #size-cells = <0>; > + > + /* LAN Marvell 88E1118 */ > + phy0: ethernet-phy@1 { > + reg = <1>; > + device_type = "ethernet-phy"; > + /* We lack the knowledge of necessary GPIO to achieve > + * Gigabit > + */ > + max-speed = <100>; > + }; > + /* WAN ICPlus IP101A */ > + phy1: ethernet-phy@2 { > + reg = <2>; > + device_type = "ethernet-phy"; > + }; > + }; > +}; > + > +ðernet { > + status = "okay"; > + ethernet-port@0 { > + phy-mode = "rgmii"; > + phy-handle = <&phy0>; > + }; > + ethernet-port@1 { > + phy-mode = "rgmii"; > + phy-handle = <&phy1>; > + }; > +}; > + > +&flash { > + status = "okay"; > + /* 32MB of flash */ > + reg = <0x30000000 0x03200000>; > + > + pinctrl-names = "enabled", "disabled"; > + pinctrl-0 = <&pflash_default_pins>; > + pinctrl-1 = <&pflash_disabled_pins>; > + > + partitions { > + compatible = "redboot-fis"; > + /* Eraseblock at 0xfe0000 */ > + fis-index-block = <0x7F>; > + }; > +}; > + > +&gpio0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&gpio0_default_pins>; > +}; > + > +&ide0 { > + status = "okay"; > +}; > + > +&ide1 { > + status = "okay"; > +}; > + > +&sata { > + cortina,gemini-ata-muxmode = <0>; > + cortina,gemini-enable-sata-bridge; > + status = "okay"; > +}; > + > +&syscon { > + pinctrl { > + /* > + * gpio0agrp cover line 0-4 > + * gpio0bgrp cover line 5 > + */ > + gpio0_default_pins: pinctrl-gpio0 { > + mux { > + function = "gpio0"; > + groups = "gpio0agrp", "gpio0bgrp"; > + }; > + }; > + pflash_disabled_pins: pinctrl-pflash-disabled { > + mux { > + function = "gpio0"; > + groups = "gpio0ggrp", "gpio0igrp", "gpio0jgrp", > + "gpio0kgrp"; > + }; > + }; > + pinctrl-gmii { > + /* This platform use both the ethernet ports */ > + mux { > + function = "gmii"; > + groups = "gmii_gmac0_grp", "gmii_gmac1_grp"; > + }; > + }; > + }; > +}; > + > +&usb0 { > + status = "okay"; > +}; > + > +&usb1 { > + status = "okay"; > +}; > -- > 2.31.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel