From: "Marek Behún" <kabel@kernel.org>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Ioana Ciornei <ioana.ciornei@nxp.com>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [RFC PATCH net-next] net: dpaa2-mac: add support for more ethtool 10G link modes
Date: Mon, 12 Jul 2021 23:27:13 +0200 [thread overview]
Message-ID: <20210712232713.5e4f6e15@thinkpad> (raw)
In-Reply-To: <E1m2y9G-0005vm-Vm@rmk-PC.armlinux.org.uk>
Hi Russell,
On Mon, 12 Jul 2021 16:47:10 +0100
Russell King <rmk+kernel@armlinux.org.uk> wrote:
> Phylink documentation says:
> * Note that the PHY may be able to transform from one connection
> * technology to another, so, eg, don't clear 1000BaseX just
> * because the MAC is unable to BaseX mode. This is more about
> * clearing unsupported speeds and duplex settings. The port modes
> * should not be cleared; phylink_set_port_modes() will help with this.
At first I thought these are points as in Markdown. Maybe remove the
asterisks from the commit message, next time :)
>
> So add the missing 10G modes.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
> net-next is currently closed, but I'd like to collect acks for this
> patch. Thanks.
>
> drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
> index ae6d382d8735..543c1f202420 100644
> --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
> +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
> @@ -140,6 +140,11 @@ static void dpaa2_mac_validate(struct phylink_config *config,
> case PHY_INTERFACE_MODE_10GBASER:
> case PHY_INTERFACE_MODE_USXGMII:
> phylink_set(mask, 10000baseT_Full);
> + phylink_set(mask, 10000baseCR_Full);
> + phylink_set(mask, 10000baseSR_Full);
> + phylink_set(mask, 10000baseLR_Full);
> + phylink_set(mask, 10000baseLRM_Full);
> + phylink_set(mask, 10000baseER_Full);
> if (state->interface == PHY_INTERFACE_MODE_10GBASER)
> break;
> phylink_set(mask, 5000baseT_Full);
Acked-by: Marek Behún <kabel@kernel.org>
next prev parent reply other threads:[~2021-07-12 21:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 15:47 [RFC PATCH net-next] net: dpaa2-mac: add support for more ethtool 10G link modes Russell King
2021-07-12 21:27 ` Marek Behún [this message]
2021-07-19 9:05 ` Ioana Ciornei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210712232713.5e4f6e15@thinkpad \
--to=kabel@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.