From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB20AC07E95 for ; Tue, 13 Jul 2021 10:46:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5595B610CB for ; Tue, 13 Jul 2021 10:46:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5595B610CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7B8446B008C; Tue, 13 Jul 2021 06:46:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 768526B0095; Tue, 13 Jul 2021 06:46:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 609C36B0096; Tue, 13 Jul 2021 06:46:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0068.hostedemail.com [216.40.44.68]) by kanga.kvack.org (Postfix) with ESMTP id 3CF876B008C for ; Tue, 13 Jul 2021 06:46:41 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 465961850A75F for ; Tue, 13 Jul 2021 10:46:40 +0000 (UTC) X-FDA: 78357236160.26.4C49092 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf25.hostedemail.com (Postfix) with ESMTP id B9E4CB0002A5 for ; Tue, 13 Jul 2021 10:46:39 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id B0B402009D; Tue, 13 Jul 2021 10:46:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1626173198; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8otA0qLioi90qyUhZvljuR4lWeiOrqphL1U65L2/rXg=; b=QwHLFDlgfaaDcl0uGRku6KFPu2IFLAfgxILN+IgnWqBMGmMR4UV0Bf0BbucAmeln9/SiR2 +5p4ampY2cMB/1wlQhpm1rWmB5nT/6N8xZH1NOYRstdTzR4mFyaxaQkpT7RHCS7w4QuAP8 vzdUQjrAhSghXCEBG7ypl20JROQNMXM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1626173198; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8otA0qLioi90qyUhZvljuR4lWeiOrqphL1U65L2/rXg=; b=LnOL3XLhaJ6o1Dfchg0u72P0yrmmVSmh+YvONXCcxbmwPag/xQ/hUjRNr11K727b+Y3G6R hUVSIqPQenLb5yAA== Received: from quack2.suse.cz (unknown [10.100.224.230]) by relay2.suse.de (Postfix) with ESMTP id A0BDCA3B83; Tue, 13 Jul 2021 10:46:38 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 81EF11E0BBC; Tue, 13 Jul 2021 12:46:38 +0200 (CEST) Date: Tue, 13 Jul 2021 12:46:38 +0200 From: Jan Kara To: Andrew Morton Cc: linux-mm@kvack.org, Michael Stapelberg , Wu Fengguang , Jan Kara Subject: Re: [PATCH 0/5 v3] writeback: Fix bandwidth estimates Message-ID: <20210713104638.GF12142@quack2.suse.cz> References: <20210713103347.8364-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210713103347.8364-1-jack@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QwHLFDlg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=LnOL3XLh; spf=pass (imf25.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none X-Rspamd-Server: rspam02 X-Stat-Signature: no8fjahpwq17g4ukybi89fn53oex8zuw X-Rspamd-Queue-Id: B9E4CB0002A5 X-HE-Tag: 1626173199-755538 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, so this is really embarrasing but I have sent the version of patches without the fixes :-|. I'm really sorry for the noise. I will send v4 now with updated patch 5/5. Honza On Tue 13-07-21 12:36:24, Jan Kara wrote: > Hello, > > Here is the third revision of the patch series to fix estimate of writeback > throughput when device is not fully busy doing writeback. Michael Stapelberg > has reported that such workload (e.g. generated by linking) tends to push > estimated throughput down to 0 and as a result writeback on the device is > practically stalled. > > The first three patches fix the reported issue, the remaining two patches > are unrelated cleanups of problems I've noticed when reading the code. > > Andrew, can you please pick up the series? Thanks! > > Honza > Changes since v2: > * Rebased on top of 5.14-rc1 > * Fixed compilation failure introduced by patch 5/5 > > Changes since v1: > * Added comments to better explain the logic > * Added Tested-by tag > * Added WRITE_ONCE calls matching READ_ONCE in patch 5/5 > > > Previous versions: > Link: http://lore.kernel.org/r/20210705161610.19406-1-jack@suse.cz # v1 > Link: http://lore.kernel.org/r/20210712165811.13163-1-jack@suse.cz # v2 -- Jan Kara SUSE Labs, CR