* drivers/gpu/drm/i915/gem/i915_gem_object.h:39:27: warning: Uninitialized variable: obj [uninitvar]
@ 2021-07-13 4:50 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-07-13 4:50 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 3076 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Matthew Auld <matthew.auld@intel.com>
CC: Daniel Vetter <daniel.vetter@ffwll.ch>
CC: Chris Wilson <chris@chris-wilson.co.uk>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 7fef2edf7cc753b51f7ccc74993971b0a9c81eca
commit: ae2fb480f32f657d896d78b6214c2efebfa61993 drm/i915/gem: consolidate 2big error checking for object sizes
date: 4 months ago
:::::: branch date: 9 hours ago
:::::: commit date: 4 months ago
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> drivers/gpu/drm/i915/gem/i915_gem_object.h:39:27: warning: Uninitialized variable: obj [uninitvar]
if (overflows_type(size, obj->base.size))
^
vim +39 drivers/gpu/drm/i915/gem/i915_gem_object.h
f0e4a06397526d Chris Wilson 2019-05-28 18
ae2fb480f32f65 Matthew Auld 2021-01-22 19 /*
ae2fb480f32f65 Matthew Auld 2021-01-22 20 * XXX: There is a prevalence of the assumption that we fit the
ae2fb480f32f65 Matthew Auld 2021-01-22 21 * object's page count inside a 32bit _signed_ variable. Let's document
ae2fb480f32f65 Matthew Auld 2021-01-22 22 * this and catch if we ever need to fix it. In the meantime, if you do
ae2fb480f32f65 Matthew Auld 2021-01-22 23 * spot such a local variable, please consider fixing!
ae2fb480f32f65 Matthew Auld 2021-01-22 24 *
ae2fb480f32f65 Matthew Auld 2021-01-22 25 * Aside from our own locals (for which we have no excuse!):
ae2fb480f32f65 Matthew Auld 2021-01-22 26 * - sg_table embeds unsigned int for num_pages
ae2fb480f32f65 Matthew Auld 2021-01-22 27 * - get_user_pages*() mixed ints with longs
ae2fb480f32f65 Matthew Auld 2021-01-22 28 */
ae2fb480f32f65 Matthew Auld 2021-01-22 29 #define GEM_CHECK_SIZE_OVERFLOW(sz) \
ae2fb480f32f65 Matthew Auld 2021-01-22 30 GEM_WARN_ON((sz) >> PAGE_SHIFT > INT_MAX)
ae2fb480f32f65 Matthew Auld 2021-01-22 31
ae2fb480f32f65 Matthew Auld 2021-01-22 32 static inline bool i915_gem_object_size_2big(u64 size)
ae2fb480f32f65 Matthew Auld 2021-01-22 33 {
ae2fb480f32f65 Matthew Auld 2021-01-22 34 struct drm_i915_gem_object *obj;
ae2fb480f32f65 Matthew Auld 2021-01-22 35
ae2fb480f32f65 Matthew Auld 2021-01-22 36 if (GEM_CHECK_SIZE_OVERFLOW(size))
ae2fb480f32f65 Matthew Auld 2021-01-22 37 return true;
ae2fb480f32f65 Matthew Auld 2021-01-22 38
ae2fb480f32f65 Matthew Auld 2021-01-22 @39 if (overflows_type(size, obj->base.size))
ae2fb480f32f65 Matthew Auld 2021-01-22 40 return true;
ae2fb480f32f65 Matthew Auld 2021-01-22 41
ae2fb480f32f65 Matthew Auld 2021-01-22 42 return false;
ae2fb480f32f65 Matthew Auld 2021-01-22 43 }
ae2fb480f32f65 Matthew Auld 2021-01-22 44
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 2+ messages in thread
* drivers/gpu/drm/i915/gem/i915_gem_object.h:39:27: warning: Uninitialized variable: obj [uninitvar]
@ 2021-05-29 1:32 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-05-29 1:32 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 3688 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Matthew Auld <matthew.auld@intel.com>
CC: Daniel Vetter <daniel.vetter@ffwll.ch>
CC: Chris Wilson <chris@chris-wilson.co.uk>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 5ff2756afde08b266fbb673849899fec694f39f1
commit: ae2fb480f32f657d896d78b6214c2efebfa61993 drm/i915/gem: consolidate 2big error checking for object sizes
date: 9 weeks ago
:::::: branch date: 7 hours ago
:::::: commit date: 9 weeks ago
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> drivers/gpu/drm/i915/gt/gen7_renderclear.c:417:42: warning: Same expression on both sides of '-'. [knownConditionTrueFalse]
gen7_emit_vfe_state(&cmds, bv, urb_size - 1, 0, 0);
^
drivers/gpu/drm/i915/gt/gen7_renderclear.c:381:32: note: 'urb_size' is assigned value '1' here.
const unsigned int urb_size = 1;
^
drivers/gpu/drm/i915/gt/gen7_renderclear.c:417:42: note: Same expression on both sides of '-'.
gen7_emit_vfe_state(&cmds, bv, urb_size - 1, 0, 0);
^
--
>> drivers/gpu/drm/i915/gem/i915_gem_object.h:39:27: warning: Uninitialized variable: obj [uninitvar]
if (overflows_type(size, obj->base.size))
^
vim +39 drivers/gpu/drm/i915/gem/i915_gem_object.h
f0e4a06397526d Chris Wilson 2019-05-28 18
ae2fb480f32f65 Matthew Auld 2021-01-22 19 /*
ae2fb480f32f65 Matthew Auld 2021-01-22 20 * XXX: There is a prevalence of the assumption that we fit the
ae2fb480f32f65 Matthew Auld 2021-01-22 21 * object's page count inside a 32bit _signed_ variable. Let's document
ae2fb480f32f65 Matthew Auld 2021-01-22 22 * this and catch if we ever need to fix it. In the meantime, if you do
ae2fb480f32f65 Matthew Auld 2021-01-22 23 * spot such a local variable, please consider fixing!
ae2fb480f32f65 Matthew Auld 2021-01-22 24 *
ae2fb480f32f65 Matthew Auld 2021-01-22 25 * Aside from our own locals (for which we have no excuse!):
ae2fb480f32f65 Matthew Auld 2021-01-22 26 * - sg_table embeds unsigned int for num_pages
ae2fb480f32f65 Matthew Auld 2021-01-22 27 * - get_user_pages*() mixed ints with longs
ae2fb480f32f65 Matthew Auld 2021-01-22 28 */
ae2fb480f32f65 Matthew Auld 2021-01-22 29 #define GEM_CHECK_SIZE_OVERFLOW(sz) \
ae2fb480f32f65 Matthew Auld 2021-01-22 30 GEM_WARN_ON((sz) >> PAGE_SHIFT > INT_MAX)
ae2fb480f32f65 Matthew Auld 2021-01-22 31
ae2fb480f32f65 Matthew Auld 2021-01-22 32 static inline bool i915_gem_object_size_2big(u64 size)
ae2fb480f32f65 Matthew Auld 2021-01-22 33 {
ae2fb480f32f65 Matthew Auld 2021-01-22 34 struct drm_i915_gem_object *obj;
ae2fb480f32f65 Matthew Auld 2021-01-22 35
ae2fb480f32f65 Matthew Auld 2021-01-22 36 if (GEM_CHECK_SIZE_OVERFLOW(size))
ae2fb480f32f65 Matthew Auld 2021-01-22 37 return true;
ae2fb480f32f65 Matthew Auld 2021-01-22 38
ae2fb480f32f65 Matthew Auld 2021-01-22 @39 if (overflows_type(size, obj->base.size))
ae2fb480f32f65 Matthew Auld 2021-01-22 40 return true;
ae2fb480f32f65 Matthew Auld 2021-01-22 41
ae2fb480f32f65 Matthew Auld 2021-01-22 42 return false;
ae2fb480f32f65 Matthew Auld 2021-01-22 43 }
ae2fb480f32f65 Matthew Auld 2021-01-22 44
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-13 4:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-13 4:50 drivers/gpu/drm/i915/gem/i915_gem_object.h:39:27: warning: Uninitialized variable: obj [uninitvar] kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2021-05-29 1:32 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.