From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00, DATE_IN_FUTURE_06_12,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A66C8C07E95 for ; Tue, 13 Jul 2021 09:14:33 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 28E7160FF0 for ; Tue, 13 Jul 2021 09:14:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28E7160FF0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 76268411BD; Tue, 13 Jul 2021 11:14:32 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 708EC4069E; Tue, 13 Jul 2021 11:14:31 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10043"; a="197314725" X-IronPort-AV: E=Sophos;i="5.84,236,1620716400"; d="scan'208";a="197314725" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2021 02:14:27 -0700 X-IronPort-AV: E=Sophos;i="5.84,236,1620716400"; d="scan'208";a="492681233" Received: from dpdk.cd.intel.com ([10.240.178.134]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2021 02:14:25 -0700 From: Jie Wang To: dev@dpdk.org Cc: xiaoyun.li@intel.com, andrew.rybchenko@oktetlabs.ru, Jie Wang , stable@dpdk.org Date: Tue, 13 Jul 2021 17:04:01 +0000 Message-Id: <20210713170401.252445-1-jie1x.wang@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210709155717.103425-1-jie1x.wang@intel.com> References: <20210709155717.103425-1-jie1x.wang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix testpmd doesn't show RSS hash offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch reapply Rx/Tx offloads configuration for all ports after the program configuring the device port. When the program configures the ports, the default Rx/Tx offloads are modified in dev->data->dev_conf. So it is need to reapply Rx/Tx offloads configuration after dev_configure. Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") Cc: stable@dpdk.org Signed-off-by: Jie Wang --- v2: copy "rx/txmode.offloads", instead of copying the entire struct "dev->data->dev_conf.rx/txmode". --- app/test-pmd/testpmd.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 1cdd3cdd12..dc9ce5330b 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2475,6 +2475,11 @@ start_port(portid_t pid) } if (port->need_reconfig > 0) { + const struct rte_eth_dev *dev = &rte_eth_devices[pi]; + struct rte_eth_conf *dev_conf; + int k; + + dev_conf = &dev->data->dev_conf; port->need_reconfig = 0; if (flow_isolate_all) { @@ -2508,6 +2513,20 @@ start_port(portid_t pid) port->need_reconfig = 1; return -1; } + /* Apply Rx offloads configuration */ + for (k = 0; k < port->dev_info.max_rx_queues; k++) { + if (port->rx_conf[k].offloads != + dev_conf->rxmode.offloads) + port->rx_conf[k].offloads = + dev_conf->rxmode.offloads; + } + /* Apply Tx offloads configuration */ + for (k = 0; k < port->dev_info.max_tx_queues; k++) { + if (port->tx_conf[k].offloads != + dev_conf->txmode.offloads) + port->tx_conf[k].offloads = + dev_conf->txmode.offloads; + } } if (port->need_reconfig_queues > 0) { port->need_reconfig_queues = 0; -- 2.25.1