From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1382C07E95 for ; Tue, 13 Jul 2021 17:07:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CEA8C61362 for ; Tue, 13 Jul 2021 17:07:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229978AbhGMRKH (ORCPT ); Tue, 13 Jul 2021 13:10:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229585AbhGMRKH (ORCPT ); Tue, 13 Jul 2021 13:10:07 -0400 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EB51C0613DD for ; Tue, 13 Jul 2021 10:07:17 -0700 (PDT) Received: by mail-pf1-x436.google.com with SMTP id a127so20224071pfa.10 for ; Tue, 13 Jul 2021 10:07:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rqIuPI5g0C7jbNOQY3Oslc7BrhONgDRjmQP2hQEh/60=; b=Mp7qhKEbedzaNill1MGRfB52XPbThqTxhHMQIv1t36xDlIBV2QSGlkhleAtwioRe3L 0IYwM+RTiFTh3o8otmPnIg3TR/wLw98kXUzPN5LniehxqJ7xbXKpy0nE3Irm29m+2sU5 u6cUx349OsFS27zeNORw7v7R+OVydo+1jjP3FtIVdttTpnXRDZWRIN1zurx+1H+mYlce vmwuf6iM7rWueId+O0jv6WyNpBjn4lYY0md6hXLs1RbykvwBvF7BN6860Oqk25c8Yt6K S/bUrSElVTkaxYNfRMiLW3FGGZe6wl377gg4qvqYFgiEtjepfssSISk22j11sR/8Gmps 6dwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rqIuPI5g0C7jbNOQY3Oslc7BrhONgDRjmQP2hQEh/60=; b=sWg97dHn1DdbOeTWBzbHkJ3EcfTX9KC4G1GdTon2lflMxP1NCsJvDb+9te/1Mi81Jl d54R/sy8DAkr6VELamHKhWLAf/T2DTh0qJIjABQfrgtZQq6xM0WbZCs27TeBhoFZhKnq hTQHGx95hoWvc8d/GYFgMlLyUrHKC/H0k0LGNkUslYn1tTe9u+sQ7RuzBODhveQVDV5n FA2pU04LwkGtd3XJc6icZTNloCYDEGK/bv9JtldVxG993NdiAcrt62ycA6cnMB4tTuLw pQxx25TsKZZO7Unm1clEtZMx2idzB0XZzXp9G5QBP74XQ6PugcaIppr5wGgRSwa4419G JyZA== X-Gm-Message-State: AOAM531k5YaFg8mIX1lG8fNbk21jAD+QKJZCvlujIpcpi2UaTGvge4SL gfpJEtJLaIP6wNvwrlNbm3Npvg== X-Google-Smtp-Source: ABdhPJxvgr2zjWS14qBP5YSln/TlB0agXOMukEPxthRY4CQydBKIkdk8k/4RZFwygIuR2Fglk7p3yg== X-Received: by 2002:a62:4e0f:0:b029:329:20be:287a with SMTP id c15-20020a624e0f0000b029032920be287amr5605209pfb.55.1626196036740; Tue, 13 Jul 2021 10:07:16 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id m16sm15821063pfo.152.2021.07.13.10.07.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jul 2021 10:07:15 -0700 (PDT) Date: Tue, 13 Jul 2021 11:07:13 -0600 From: Mathieu Poirier To: Aisheng Dong Cc: "linux-remoteproc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "ohad@wizery.com" , "dongas86@gmail.com" , "bjorn.andersson@linaro.org" , Peng Fan Subject: Re: [PATCH 4/4] remoteproc: imx_rproc: fix rsc-table name Message-ID: <20210713170713.GB1816225@p14s> References: <20210706142335.952858-1-aisheng.dong@nxp.com> <20210706142335.952858-4-aisheng.dong@nxp.com> <20210712180859.GC1779922@p14s> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Tue, Jul 13, 2021 at 02:47:44AM +0000, Aisheng Dong wrote: > Hi Mathieu, > > Thanks for the feedback. > > > From: Mathieu Poirier > > Sent: Tuesday, July 13, 2021 2:09 AM > > > > On Tue, Jul 06, 2021 at 10:23:35PM +0800, Dong Aisheng wrote: > > > Usually the dash '-' is preferred in node name. > > > > ... And yet the DT binding shows &m4_reserved_sysmem1 and > > &m4_reserved_sysmem2. > > > > Either change it all or leave as is. > > These are phandles and not node names. > So should be ok. > > BTW, I've sent V2, could you help review V2 series? > https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210707094033.1959752-1-aisheng.dong@nxp.com/ > Looks like I reviewed the wrong version... > Regards > Aisheng > > > > > Thanks, > > Mathieu > > > > > So far, not dts in upstream kernel, so we just update node name in > > > driver. > > > > > > Cc: Bjorn Andersson > > > Cc: Mathieu Poirier > > > Cc: Peng Fan > > > Fixes: 5e4c1243071d ("remoteproc: imx_rproc: support remote cores > > > booted before Linux Kernel") > > > Signed-off-by: Dong Aisheng > > > --- > > > drivers/remoteproc/imx_rproc.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/remoteproc/imx_rproc.c > > > b/drivers/remoteproc/imx_rproc.c index 12de153abb2d..26eb130f3263 > > > 100644 > > > --- a/drivers/remoteproc/imx_rproc.c > > > +++ b/drivers/remoteproc/imx_rproc.c > > > @@ -600,7 +600,7 @@ static int imx_rproc_addr_init(struct imx_rproc > > *priv, > > > } > > > priv->mem[b].sys_addr = res.start; > > > priv->mem[b].size = resource_size(&res); > > > - if (!strcmp(node->name, "rsc_table")) > > > + if (!strcmp(node->name, "rsc-table")) > > > priv->rsc_table = priv->mem[b].cpu_addr; > > > b++; > > > } > > > -- > > > 2.25.1 > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09F96C07E95 for ; Tue, 13 Jul 2021 17:08:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C94F261364 for ; Tue, 13 Jul 2021 17:08:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C94F261364 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JQ+CaiUdIh3fpHVGAYf7rPLoE816P5YFBYXSx4AegAs=; b=3/JkOxtoShPttR 3GzRJZ73oLd30Md7OVBHQqaeEEBw80P3+UAUqHzDYCnTxbFevoJZwGdvsImI7JK6tyvVrfdqEWHJC V/RpxtN6oSNYjXDerEvfufRKA/Bu6FqhShXmVmN7+x9z76il5oZJnIXmALR0/sH3B6ead2ie0kV0Y 9ABsKyBtR0BMNo4abVnN3D4wLcDXvVfox6uRijQFRO6dI5jfb6eUKXorkBp2oEAGApA6go8ZX4Nlp f9/5+XdVjuxR1WOw9PM+Bskz1QRpE39dYUPXRrJkPFJOj2gc5S0pKD8NlyKYg7lDS4VUp06eKTCpP KebqLrwnz5BcpFSNEPYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3LsP-00B1Az-Fw; Tue, 13 Jul 2021 17:07:21 +0000 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3LsL-00B19s-Bs for linux-arm-kernel@lists.infradead.org; Tue, 13 Jul 2021 17:07:18 +0000 Received: by mail-pg1-x536.google.com with SMTP id y17so22146799pgf.12 for ; Tue, 13 Jul 2021 10:07:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rqIuPI5g0C7jbNOQY3Oslc7BrhONgDRjmQP2hQEh/60=; b=Mp7qhKEbedzaNill1MGRfB52XPbThqTxhHMQIv1t36xDlIBV2QSGlkhleAtwioRe3L 0IYwM+RTiFTh3o8otmPnIg3TR/wLw98kXUzPN5LniehxqJ7xbXKpy0nE3Irm29m+2sU5 u6cUx349OsFS27zeNORw7v7R+OVydo+1jjP3FtIVdttTpnXRDZWRIN1zurx+1H+mYlce vmwuf6iM7rWueId+O0jv6WyNpBjn4lYY0md6hXLs1RbykvwBvF7BN6860Oqk25c8Yt6K S/bUrSElVTkaxYNfRMiLW3FGGZe6wl377gg4qvqYFgiEtjepfssSISk22j11sR/8Gmps 6dwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rqIuPI5g0C7jbNOQY3Oslc7BrhONgDRjmQP2hQEh/60=; b=XG5trPGZ8g1bMnDRtA4DtMGdQ+vEfhA7zRcT6fOx7OFA8W2iPJrg8FOw2ujdYqE9VM yPV4wfkOP12G/20PrT98yz4RUb2IPBCYZH+wvIaxyDj+axjrcFICm010Hvi0COFZ74+M XqZMnb5nrpjvy9+ACM398dRX1UuXcxXTK5sxOmP8qyLuP5MiyUD6UZbQb34LlSsbusCM TWNU+KqUuvBGHwcrauCQydzT5Ndhe/k/r/ErcM7sB8pi/4Qi9dkrK3v6DNZJRQo3TrQj XGvrsBg7yhhOnOZ+2Mghqmw6JHSTqK+6iz0Yj7ntu1EOAzDoDsLzKZYi7f42EwBksowz 0+vQ== X-Gm-Message-State: AOAM532oLhMXGehjwJUUkFrFqNE/dk9yVdUHE3v+Lw/gZtDZfIuL7ub/ wDI1EQH8mAkUEUf0+9qAVaep5Q== X-Google-Smtp-Source: ABdhPJxvgr2zjWS14qBP5YSln/TlB0agXOMukEPxthRY4CQydBKIkdk8k/4RZFwygIuR2Fglk7p3yg== X-Received: by 2002:a62:4e0f:0:b029:329:20be:287a with SMTP id c15-20020a624e0f0000b029032920be287amr5605209pfb.55.1626196036740; Tue, 13 Jul 2021 10:07:16 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id m16sm15821063pfo.152.2021.07.13.10.07.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jul 2021 10:07:15 -0700 (PDT) Date: Tue, 13 Jul 2021 11:07:13 -0600 From: Mathieu Poirier To: Aisheng Dong Cc: "linux-remoteproc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "ohad@wizery.com" , "dongas86@gmail.com" , "bjorn.andersson@linaro.org" , Peng Fan Subject: Re: [PATCH 4/4] remoteproc: imx_rproc: fix rsc-table name Message-ID: <20210713170713.GB1816225@p14s> References: <20210706142335.952858-1-aisheng.dong@nxp.com> <20210706142335.952858-4-aisheng.dong@nxp.com> <20210712180859.GC1779922@p14s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210713_100717_450256_B1D478DC X-CRM114-Status: GOOD ( 26.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 13, 2021 at 02:47:44AM +0000, Aisheng Dong wrote: > Hi Mathieu, > > Thanks for the feedback. > > > From: Mathieu Poirier > > Sent: Tuesday, July 13, 2021 2:09 AM > > > > On Tue, Jul 06, 2021 at 10:23:35PM +0800, Dong Aisheng wrote: > > > Usually the dash '-' is preferred in node name. > > > > ... And yet the DT binding shows &m4_reserved_sysmem1 and > > &m4_reserved_sysmem2. > > > > Either change it all or leave as is. > > These are phandles and not node names. > So should be ok. > > BTW, I've sent V2, could you help review V2 series? > https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210707094033.1959752-1-aisheng.dong@nxp.com/ > Looks like I reviewed the wrong version... > Regards > Aisheng > > > > > Thanks, > > Mathieu > > > > > So far, not dts in upstream kernel, so we just update node name in > > > driver. > > > > > > Cc: Bjorn Andersson > > > Cc: Mathieu Poirier > > > Cc: Peng Fan > > > Fixes: 5e4c1243071d ("remoteproc: imx_rproc: support remote cores > > > booted before Linux Kernel") > > > Signed-off-by: Dong Aisheng > > > --- > > > drivers/remoteproc/imx_rproc.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/remoteproc/imx_rproc.c > > > b/drivers/remoteproc/imx_rproc.c index 12de153abb2d..26eb130f3263 > > > 100644 > > > --- a/drivers/remoteproc/imx_rproc.c > > > +++ b/drivers/remoteproc/imx_rproc.c > > > @@ -600,7 +600,7 @@ static int imx_rproc_addr_init(struct imx_rproc > > *priv, > > > } > > > priv->mem[b].sys_addr = res.start; > > > priv->mem[b].size = resource_size(&res); > > > - if (!strcmp(node->name, "rsc_table")) > > > + if (!strcmp(node->name, "rsc-table")) > > > priv->rsc_table = priv->mem[b].cpu_addr; > > > b++; > > > } > > > -- > > > 2.25.1 > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel