From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1m3MWa-0002tK-0L for mharc-grub-devel@gnu.org; Tue, 13 Jul 2021 13:48:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3MWY-0002q1-E5 for grub-devel@gnu.org; Tue, 13 Jul 2021 13:48:50 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:27858) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3MWW-0003D9-6l for grub-devel@gnu.org; Tue, 13 Jul 2021 13:48:50 -0400 Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16DHjsMI014832; Tue, 13 Jul 2021 17:48:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2020-01-29; bh=SYeFLiBWcf1H+tHP54O/vAPgsPYrfNEfynABL95uBuU=; b=PktI8Ly3G+N4Kxlmg8S/6HpERy1AKD0oGS9vy4dLINqSqsf7SpVkVU8lcdS2HRmM3G7f 3Rm2g9eTn29aeJk4wpc2ZVrF6TOMOQRQ3B8bo2esQNTfeGnb38qfR5/lom0Lme5oDisd p+471IRp/Prhx3vNmeSZsyjqnHGss4QMCXMsUREV2GsX1uKhtw7d3Jl6O/SnRyf0HCTQ Ij7YBwxUVskR65JT6a4HcnprTB8HRhv8v1CjpTGdyY/hErg3rTXXwTXeyTYlG0/ne1jg pA3wNLZ5majJ4rJc6cMdPWjwTKxx73b/jmgk3rLN1U9wXOqEij7wS73TKl2k5wIZTgFt /g== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 39rqm0u0cu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Jul 2021 17:48:37 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 16DHese0097565; Tue, 13 Jul 2021 17:48:36 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2174.outbound.protection.outlook.com [104.47.55.174]) by aserp3030.oracle.com with ESMTP id 39qycwehgb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Jul 2021 17:48:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RsXA/yGgEr+eiElKfEfu+VnQ4a+uoOas1XpA/ysoJNXksbGTFyXl0QLtcY0kkKLtxKN0ZOd3AZL9A3sg8yeQTTuktWsn+GM1+uZui1edg2AuAKc4sb26kh3hrMjh8uGIZiUCikPeF5Dz++OqrfhJ+w1qa0DhdMqPhrs7xPbUUHiuNFueJdg4MTNNP/U2mksYvFfaSA5Vnf2uNRo7QXkEjdq/jddeV1SzKoPBwXciaKwWnsMApPfhlVnxpEfF0kjCUlUuk5pdvvOdhAHSeTDfhvxS4k75s2P0jVOTqKcPQs60mukZteHm2bmuUfrRRuTIgDwtAMw4/HIE3+ye83/EVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SYeFLiBWcf1H+tHP54O/vAPgsPYrfNEfynABL95uBuU=; b=DQ3gSqPRv3FnDPqKgASdtzwJ3UpLkGoV7aPkbhh1oDSs1ilziRq+zoXJjWs87SrJDThwMduAZdg+juMyk0GIUz6hPYQNy2QKmhKmDRQfNZzf21ts1q8KoIIh4wlarwMV1qO3KNDk2EwiiK+z2Pm8EjFDBKORxaGMjezGBzFrKOLpjHOvpVUiSodDreccrfXTTFzohFaaRw7+4/pi9SYV5S6RZLTlvCLqObKAUaA6pAv8NROqXfvUohLsr0O1PBDkVzgGCuujzZCj546XcP2qoahO9ofunPhjRbJZYq1rg8sWfm/QjZLWujaqc9evX7gGX7T/qZrt0Hb3W3m5CuhYAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SYeFLiBWcf1H+tHP54O/vAPgsPYrfNEfynABL95uBuU=; b=d1mzqrJ7mB0BPPR+4ZkRZWcYreBmCL4bqS8mhTmxCVkc4CyLev3gikd2YSSq09WYBc7rfEM6I/xlzcTObnF44EF2ee/j6uGb44Kb98D6A5CUtsZ4V47Pvryr5c9/Ni+qiJ3o1NxRB+OFqDMHhhX5quiV+RK3OMkOKiTciGB0PD8= Authentication-Results: suse.cz; dkim=none (message not signed) header.d=none;suse.cz; dmarc=none action=none header.from=oracle.com; Received: from BN6PR1001MB2228.namprd10.prod.outlook.com (2603:10b6:405:2e::38) by BN6PR10MB1939.namprd10.prod.outlook.com (2603:10b6:404:100::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.21; Tue, 13 Jul 2021 17:48:33 +0000 Received: from BN6PR1001MB2228.namprd10.prod.outlook.com ([fe80::ed56:7043:6d81:8547]) by BN6PR1001MB2228.namprd10.prod.outlook.com ([fe80::ed56:7043:6d81:8547%4]) with mapi id 15.20.4308.027; Tue, 13 Jul 2021 17:48:33 +0000 Date: Tue, 13 Jul 2021 19:48:25 +0200 From: Daniel Kiper To: Petr Vorel Cc: grub-devel@gnu.org, Jeff Mahoney , Michael Chang , Mike Gilbert Subject: Re: [PATCH 2/2] grub2: use stat instead of udevadm for partition lookup Message-ID: <20210713174825.psrixhsnnoii3ybk@tomti.i.net-space.pl> References: <20210708155558.26466-1-pvorel@suse.cz> <20210708155558.26466-3-pvorel@suse.cz> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210708155558.26466-3-pvorel@suse.cz> User-Agent: NeoMutt/20170113 (1.7.2) X-ClientProxiedBy: AM6P194CA0085.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:8f::26) To BN6PR1001MB2228.namprd10.prod.outlook.com (2603:10b6:405:2e::38) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from tomti.i.net-space.pl (84.10.22.86) by AM6P194CA0085.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:8f::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21 via Frontend Transport; Tue, 13 Jul 2021 17:48:31 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b480aff9-715e-4d38-92dd-08d946266e5e X-MS-TrafficTypeDiagnostic: BN6PR10MB1939: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gs6wm7LRoL0AiYautlMHmwskeCUwyP1e/hfkb5a1YO5FnM5p74ScdrmyuEjt9OFsNqJTkS3rsobnBg31DQ8CNMOhjbSYRnQFY3wnmu7xEctq4jPzG8vKF2Wnjb6xQkQ9fr43LkD8nF8YgnVZ8L7p7niaRSNslazI2dwoU2buQv7RxZB+uuABDSKYwpv4YwSqRRqwrxWzSHObLMyM0pGISxreNYGSfyACu5Ja7GLRQ35o6uUEub2OCHuiWRamHCM41DQK91zQMUKCinawEddLfoVR4/yYazAawANc8mUGuB0W9jF/6I6SyLFV9Ak6v65Ubk/nwVq64w6tHzVb03UTH2tytl3QloZ566CW1tw0Hpv+Vtuyn0tDthil4OUxofhuVFwMB9QmR+C+Sx+uLRmXon0C5MTCG8upfiGmE/F776Oz1UqknKL9wZpLq4aKqZ1FYHRmiIv9S8AduDqG1r7yrAfoo2/vBKhHmNMx89O6Cs1Eqs9VDvEhHz8z1HzcE2yGCfIPZ8/QLOlL9i2pVf1JIXSEdZkuyH6xVIIQ/3e979xoEHLdPJQmRoPhjJ78+wzmqvjylCKOZ6BehfcX2ahDBVkKEUrZlFoHtnfCv50eQ4DNM+7RmHFmq/PCyThoUCAV7AU9bxOyntjEmB+XGaWMMpX/+NNuv1DkqnY7C+cMrhQLylF6XD0ReOnwmdbOaSEo X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR1001MB2228.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(39860400002)(346002)(376002)(396003)(366004)(86362001)(6506007)(8676002)(4326008)(66556008)(2906002)(956004)(66476007)(478600001)(54906003)(38100700002)(1076003)(9686003)(6916009)(44832011)(83380400001)(55016002)(26005)(316002)(7696005)(52116002)(186003)(8936002)(38350700002)(5660300002)(66946007)(6666004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xm1nftIkwsZz7aclRzI1CHsU0fV6R9P/h7Olb1/+1BVXiuA3nUhfA0U7biWw?= =?us-ascii?Q?540EeDN1EUlJR0hnrfbBUNlJRUwc/hgxLn3CU3318Jm/1Uhm29K3pO9LLhZB?= =?us-ascii?Q?reqKDXJ1nP4uFpF4yZc5p1jZJT8fCFi7cUFKjEV7r8k413JN56wVVDTPBrd6?= =?us-ascii?Q?q+0skyzbZ5r708VjNnNwko4GETY5EQpv45CEYrLJSyFrADTEOmZQ2fK0aYL8?= =?us-ascii?Q?t869msDHQkxqYe1LF9lx307vdCeiTyPG7iLjbtqkZErHGGttMikphvwwUmNL?= =?us-ascii?Q?GA5lOBhbaC3vQQysxdSglLfY/HkG4a/QuYsJnE+EcAZ4w03C2zpvpx2V87dD?= =?us-ascii?Q?7GRf9hfNsaSd7urbE9xFuWL022iYNkf4uLDL2iHLwBCho802isU9GIla9iCB?= =?us-ascii?Q?rFKHrIUziWbTJKwl3m7Q3r0KCoB7MVsCsQVeCGhWV/dzWBH7JFg9hCf8W5vS?= =?us-ascii?Q?ZlHHYMHmNJhdQLmdxigjbuPdHSR12vYjNP8Owg9jBuFmWvV20GCSXPpbWJ8+?= =?us-ascii?Q?elCj2UIdUXkqqy3YqJpt7wEkJg9wyAe2/O5F18OCRTfm09w2JXI+kGt9cRix?= =?us-ascii?Q?CSPG2DUKqwD0gJw4ReHcFIZrggvw5Np6TntUpfFeM/jM9MOBxKoCboxl7er+?= =?us-ascii?Q?JpTgjsAqoazeT6BN9PO6ay6uNEkLJ/ghfvFAxrZcnDr9O+REYgyA5c9LBImH?= =?us-ascii?Q?MB0q2Yr0gRm/ZS3kIlPRuHgFBZIAxa7tt7t5xlwYydPwU8zHt0aRgfRVdNDG?= =?us-ascii?Q?KpdKlUYPlgtQ3vW+w2JfgGpes6UOewfNqedB3v0YuPN1ZSWhv95rwEXHkaPF?= =?us-ascii?Q?+PCp6Ctjqq6A3IXZQCang1cu9XEVweo8MHJteHBksmI7Ou8rLM7RFxp3B7u7?= =?us-ascii?Q?4iFbvHlrcuj67orkFskmKi5yo8yxuOw72lZEAjKrO/z+C+a2l3NQO8qEhU+g?= =?us-ascii?Q?T/9V2alLQCAiLwaPQsH187ztJD6HQIhOFwb+tyXViT/9ojKZQfajh9/3gWoY?= =?us-ascii?Q?iPB+g8mpzUxMp154Xf10WOIHyvum0wEo5UeRapRFxSxrnvRPaTTDspcabNxC?= =?us-ascii?Q?O+9w50sn7a/kCHcEgMmQf1V2xVGzyMGxdv3p7yAmw1+uMC6ezWFMJ5ovg62k?= =?us-ascii?Q?dvt5YXmHOUBMaS+Zcopqa6BWAixgP1ODN3zSQQNxwnzi1o+I96p/x/DVP/s6?= =?us-ascii?Q?6mSL177ECMCcnlzsguhHq2K0BkzwFkmPKCt+S4tIWb8z4XB7oOFNMd8xv3RH?= =?us-ascii?Q?2F+7pVP7i/cgbavUlr+A7l8GN5ZSp6KtOv9Km5FvLBXCXw4a9eL6g+PWyoqG?= =?us-ascii?Q?YYmysScLKYKK2Kbb8T6Dl6zb?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b480aff9-715e-4d38-92dd-08d946266e5e X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2228.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2021 17:48:33.1454 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QVCnmx5jch5NaUCu2AKhRpl6iQS42PSLzlfYtnFhBcMFemTAupoUvmlv0hKDUtS8Zv+Sn0XUReqP5jaTOVw5Xw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1939 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10044 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 bulkscore=0 mlxscore=0 suspectscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2107130111 X-Proofpoint-GUID: Onb-98YcqsTsXNtEbbwytlK7okyq9q6- X-Proofpoint-ORIG-GUID: Onb-98YcqsTsXNtEbbwytlK7okyq9q6- Received-SPF: pass client-ip=205.220.177.32; envelope-from=daniel.kiper@oracle.com; helo=mx0b-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jul 2021 17:48:50 -0000 On Thu, Jul 08, 2021 at 05:55:58PM +0200, Petr Vorel wrote: > From: Jeff Mahoney > > sysfs_partition_path calls udevadm to resolve the sysfs path for > a block device. That can be accomplished by stating the device node > and using the major/minor to follow the symlinks in /sys/dev/block/. > > This cuts the execution time of grub2-mkconfig from 10s to 2s on > my system. > > Signed-off-by: Jeff Mahoney > [ pvorel: include grub/osdep/major.h ] > Signed-off-by: Petr Vorel > --- > grub-core/osdep/linux/hostdisk.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/grub-core/osdep/linux/hostdisk.c b/grub-core/osdep/linux/hostdisk.c > index da62f924e..43dc4b0ba 100644 > --- a/grub-core/osdep/linux/hostdisk.c > +++ b/grub-core/osdep/linux/hostdisk.c > @@ -31,6 +31,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -105,6 +106,13 @@ sysfs_partition_path (const char *dev, const char *entry) > char *buf = NULL; > size_t len = 0; > char *path = NULL; > + struct stat st; > + int ret; > + > + ret = stat(dev, &st); Missing space between "stat" and "(". > + if (ret == 0 && S_ISBLK(st.st_mode)) Same for S_ISBLK... > + return xasprintf ("/sys/dev/block/%u:%u/%s", > + major (st.st_rdev), minor (st.st_rdev), entry); > > argv[0] = "udevadm"; > argv[1] = "info"; Do we really need udevadm fallback mechanism? If something went wrong here for us I do not expect it will work for udevadm either. Daniel