From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F7D7C07E95 for ; Tue, 13 Jul 2021 20:48:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3142861369 for ; Tue, 13 Jul 2021 20:48:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235423AbhGMUut (ORCPT ); Tue, 13 Jul 2021 16:50:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:35510 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234172AbhGMUut (ORCPT ); Tue, 13 Jul 2021 16:50:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626209278; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=edgULd724qxW2wczl2lL2drDkUNp/TtLehg+wvSDn60=; b=Ar4ojXmG6Q2dkV0Jpk/t4opwXDoPvp8YcsUOXGwFqL68Ia0SroRRh/i8jGFvd7FuhXBdon VRIiR+q48SU5cZO4ukljvADEq1yYwykubo88VPUYqXOkyf/74Yc/fQY/PGSbm87wjUPCNx aNufL5LYJNU2YO4BnI4bzHiEluAQoy8= Received: from mail-il1-f197.google.com (mail-il1-f197.google.com [209.85.166.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-460-XhlHF-M0PPGNFtBWrIPYpg-1; Tue, 13 Jul 2021 16:47:57 -0400 X-MC-Unique: XhlHF-M0PPGNFtBWrIPYpg-1 Received: by mail-il1-f197.google.com with SMTP id h17-20020a056e021d91b02902004a17fb0aso15587397ila.3 for ; Tue, 13 Jul 2021 13:47:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=edgULd724qxW2wczl2lL2drDkUNp/TtLehg+wvSDn60=; b=I09LR9+tJOsAh8tAX6JtQU8bt8hrjUC/P4deFpMMuonUumBJSbtHCM0Vx95s0j2zlR 4RTzvIsPfOJLUUS7vD3LB0pEyz3dkDrugqH3OcvqL0kvrVz0juhmn4S01Z7B1YtrTi9L DEQgukjFeaXSslTb5jnzf+oeMcFcpPekVMu1VnDcEnnyfUaOsmSed5BphZQE/yUUgJ50 wc/8ITYBcnSHLSWXJMRhCXXOHQ1qWvmemXv2YQql06ZPc6hHs92biCSJ75EBJCcga9dC zfYGOBVhX8K9w/HM5Mb53rZvCJz1DBMRHFIpSzi0RDPI4fMdWzlnoGP+0IdBnBuecCFn WAdw== X-Gm-Message-State: AOAM530XVNfldvjaNiQkCSQgjG7RRx4tzf5WVXXSLPWBILwMmh/dTduy 0DrbhkBxnxdY0GuIzVJdwWmXwMVzHU1VtY4rTzh6q7OSipplZ0fHMV9iprkOwF37wcLNOR8Sujr 8rWVkk2bEXqt8 X-Received: by 2002:a92:db4e:: with SMTP id w14mr4382867ilq.188.1626209277264; Tue, 13 Jul 2021 13:47:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlRTk8ZYwTep6uQ3YEemMecev8TKW7q7hnLoZpmdpPTnuZHGlGP2olwGFrF73D7gKpIhoktA== X-Received: by 2002:a92:db4e:: with SMTP id w14mr4382859ilq.188.1626209277118; Tue, 13 Jul 2021 13:47:57 -0700 (PDT) Received: from gator ([140.82.166.162]) by smtp.gmail.com with ESMTPSA id s6sm22547ilv.76.2021.07.13.13.47.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jul 2021 13:47:56 -0700 (PDT) Date: Tue, 13 Jul 2021 22:47:54 +0200 From: Andrew Jones To: Alex =?utf-8?Q?Benn=C3=A9e?= Cc: kvm@vger.kernel.org, maz@kernel.org, shashi.mallela@linaro.org, qemu-arm@nongnu.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, pbonzini@redhat.com Subject: Re: [kvm-unit-tests PATCH v2 2/4] scripts/arch-run: don't use deprecated server/nowait options Message-ID: <20210713204754.xg3eawok4m6q7ulk@gator> References: <20210525172628.2088-1-alex.bennee@linaro.org> <20210525172628.2088-3-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210525172628.2088-3-alex.bennee@linaro.org> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, May 25, 2021 at 06:26:26PM +0100, Alex Bennée wrote: > The very fact that QEMU drops the deprecation warning while running is > enough to confuse the its-migration test into failing. The boolean > options server and wait have accepted the long form options for a long > time. > > Signed-off-by: Alex Bennée > Cc: Shashi Mallela > --- > scripts/arch-run.bash | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash > index 5997e38..70693f2 100644 > --- a/scripts/arch-run.bash > +++ b/scripts/arch-run.bash > @@ -122,14 +122,14 @@ run_migration () > trap 'kill 0; exit 2' INT TERM > trap 'rm -f ${migout1} ${migsock} ${qmp1} ${qmp2} ${fifo}' RETURN EXIT > > - eval "$@" -chardev socket,id=mon1,path=${qmp1},server,nowait \ > + eval "$@" -chardev socket,id=mon1,path=${qmp1},server=on,wait=off \ > -mon chardev=mon1,mode=control | tee ${migout1} & > > # We have to use cat to open the named FIFO, because named FIFO's, unlike > # pipes, will block on open() until the other end is also opened, and that > # totally breaks QEMU... > mkfifo ${fifo} > - eval "$@" -chardev socket,id=mon2,path=${qmp2},server,nowait \ > + eval "$@" -chardev socket,id=mon2,path=${qmp2},server=on,wait=off \ > -mon chardev=mon2,mode=control -incoming unix:${migsock} < <(cat ${fifo}) & > incoming_pid=`jobs -l %+ | awk '{print$2}'` > > -- > 2.20.1 > > _______________________________________________ > kvmarm mailing list > kvmarm@lists.cs.columbia.edu > https://lists.cs.columbia.edu/mailman/listinfo/kvmarm Applied to misc/queue https://gitlab.com/rhdrjones/kvm-unit-tests/-/commits/misc/queue Thanks, drew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72C28C07E95 for ; Tue, 13 Jul 2021 20:48:05 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id E0A4C61369 for ; Tue, 13 Jul 2021 20:48:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0A4C61369 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 69EC94A173; Tue, 13 Jul 2021 16:48:04 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CJC1MSmxNwcv; Tue, 13 Jul 2021 16:48:03 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 6C8C24A524; Tue, 13 Jul 2021 16:48:03 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 8C7DF4A4BE for ; Tue, 13 Jul 2021 16:48:02 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kzPq+m1ujGaZ for ; Tue, 13 Jul 2021 16:48:01 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 7906449F5F for ; Tue, 13 Jul 2021 16:48:01 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626209281; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=edgULd724qxW2wczl2lL2drDkUNp/TtLehg+wvSDn60=; b=Km7/Ni0OrKc8z1HJ+HXACh6hets7CcM3aLdqYvksZebOJunQC2RQ2q9j0j8bRXTGzyI+uA 5pa+fuv+ua2BvfoNCDiHk687jWw2A4GbXRw8VhqoJYPV27Oq3HEGiDIGRnPm+3Y1mypVQy rn3IAMb6YVFGhI5ngX4DVJJJzaVxLx8= Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-462--YDt2YGGPgOXKGLSjncdbg-1; Tue, 13 Jul 2021 16:47:57 -0400 X-MC-Unique: -YDt2YGGPgOXKGLSjncdbg-1 Received: by mail-il1-f198.google.com with SMTP id i11-20020a056e02004bb029020269661e11so14310076ilr.13 for ; Tue, 13 Jul 2021 13:47:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=edgULd724qxW2wczl2lL2drDkUNp/TtLehg+wvSDn60=; b=PX6UHdd7wbFvVXe9Mp6cvPfqMiQgZOjhzHIdE09jYWggy58MOq7Zdnrw3m0U9vaqUm jZ5P12GMfiiH58XtmPmJSu+d3EmTbuNSUHWOWZXMa50QQka6XvcgkCb+7UtJdu74fiY2 dwZ8ce2Aqp1/b6I0/2MGIvaQ/akoe9xa1J9CJM+YIUq6TMVOm7k1uWre1OY30vZW9Bql wCqWS+d32L418/4EefcN9GThQkDxYKfK8wgRLTFnn6bRi4PKu8rrjyGGBkmSM/CZN/ar 62Cm5y1JzY39g4H6SPoEmpDGViF6DQ5rwnQ4oBH/SK9byeobhMsxOh22bhIv/9BKXZS8 vtLw== X-Gm-Message-State: AOAM530ZVUZCNCYis85RetdKxKlWDUXDK1HVaHbMVkNGpdgKzTIBsiD7 okDtTs3aJl2QH5vmGqGx6nwscj0Y9po17Sv5ksL7N6pGhWgMUil+r1l5kvQl6VOUqZmSYAUxqpq zBzcCWPdKW3XZ9GeU7ydpN5cl X-Received: by 2002:a92:db4e:: with SMTP id w14mr4382864ilq.188.1626209277264; Tue, 13 Jul 2021 13:47:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlRTk8ZYwTep6uQ3YEemMecev8TKW7q7hnLoZpmdpPTnuZHGlGP2olwGFrF73D7gKpIhoktA== X-Received: by 2002:a92:db4e:: with SMTP id w14mr4382859ilq.188.1626209277118; Tue, 13 Jul 2021 13:47:57 -0700 (PDT) Received: from gator ([140.82.166.162]) by smtp.gmail.com with ESMTPSA id s6sm22547ilv.76.2021.07.13.13.47.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jul 2021 13:47:56 -0700 (PDT) Date: Tue, 13 Jul 2021 22:47:54 +0200 From: Andrew Jones To: Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [kvm-unit-tests PATCH v2 2/4] scripts/arch-run: don't use deprecated server/nowait options Message-ID: <20210713204754.xg3eawok4m6q7ulk@gator> References: <20210525172628.2088-1-alex.bennee@linaro.org> <20210525172628.2088-3-alex.bennee@linaro.org> MIME-Version: 1.0 In-Reply-To: <20210525172628.2088-3-alex.bennee@linaro.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=drjones@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: kvm@vger.kernel.org, maz@kernel.org, shashi.mallela@linaro.org, qemu-arm@nongnu.org, pbonzini@redhat.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Tue, May 25, 2021 at 06:26:26PM +0100, Alex Benn=E9e wrote: > The very fact that QEMU drops the deprecation warning while running is > enough to confuse the its-migration test into failing. The boolean > options server and wait have accepted the long form options for a long > time. > = > Signed-off-by: Alex Benn=E9e > Cc: Shashi Mallela > --- > scripts/arch-run.bash | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > = > diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash > index 5997e38..70693f2 100644 > --- a/scripts/arch-run.bash > +++ b/scripts/arch-run.bash > @@ -122,14 +122,14 @@ run_migration () > trap 'kill 0; exit 2' INT TERM > trap 'rm -f ${migout1} ${migsock} ${qmp1} ${qmp2} ${fifo}' RETURN EXIT > = > - eval "$@" -chardev socket,id=3Dmon1,path=3D${qmp1},server,nowait \ > + eval "$@" -chardev socket,id=3Dmon1,path=3D${qmp1},server=3Don,wait=3Do= ff \ > -mon chardev=3Dmon1,mode=3Dcontrol | tee ${migout1} & > = > # We have to use cat to open the named FIFO, because named FIFO's, unli= ke > # pipes, will block on open() until the other end is also opened, and t= hat > # totally breaks QEMU... > mkfifo ${fifo} > - eval "$@" -chardev socket,id=3Dmon2,path=3D${qmp2},server,nowait \ > + eval "$@" -chardev socket,id=3Dmon2,path=3D${qmp2},server=3Don,wait=3Do= ff \ > -mon chardev=3Dmon2,mode=3Dcontrol -incoming unix:${migsock} < <(cat $= {fifo}) & > incoming_pid=3D`jobs -l %+ | awk '{print$2}'` > = > -- = > 2.20.1 > = > _______________________________________________ > kvmarm mailing list > kvmarm@lists.cs.columbia.edu > https://lists.cs.columbia.edu/mailman/listinfo/kvmarm Applied to misc/queue https://gitlab.com/rhdrjones/kvm-unit-tests/-/commits/misc/queue Thanks, drew _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83D42C07E95 for ; Tue, 13 Jul 2021 20:49:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 498F861358 for ; Tue, 13 Jul 2021 20:49:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 498F861358 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=10q0skFbKL5Ed9K7LHoTSNAhynCGiUgFRyl3qgTYXH8=; b=jCfoJxJm2Dmm9c 6vB9YHCZY67QrFHaZNiBdrOypt+RhoPMLNcFqbAL7l1udAUPbyOcShtbXF/cQIKFyPioMAmA5H8mX CllKH6hheAcF3yq0++bhgdBmG4zM2aijSKsAy1y89/ZqQSI9dxikEF2guG7blLnFIZh3aB2K/cb+y cdFHtITBj4U8CY6Sb/R3C4rLF+WFPu3SKhoeowa25FXjpZGKkAGC+Rn6qGuu7FtWmX0E3T1/+QwLQ qgoFYELZnHqJGnhD1XSePmNG7/fJk26mN9zjT8O+tUqouRWsLLHDoy09x0WWLJJdaqsH7Av6Gp17A sw9lMPZy2qyxvM76lBEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3PK5-00BLlk-Bs; Tue, 13 Jul 2021 20:48:09 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3PK0-00BLku-Ni for linux-arm-kernel@lists.infradead.org; Tue, 13 Jul 2021 20:48:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626209280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=edgULd724qxW2wczl2lL2drDkUNp/TtLehg+wvSDn60=; b=gCHmhmbEVojusEDSQMeyVIMZT5dYt93N7hvXUzWpT0zEKhSySIXBky5Px//wvFJtHAAQDy YJkFwAqfWwsGTgUmdDQiWiAw1MVWnQpRnXnyIapjCEDm7B/9CrdHQsgF0ZmgUF/chtvWvG I0VYb3UdrrxcxLTCoQ9G2ETDgAELsD8= Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-460-A7Gqh1sKOKOhm7LL22XL-w-1; Tue, 13 Jul 2021 16:47:57 -0400 X-MC-Unique: A7Gqh1sKOKOhm7LL22XL-w-1 Received: by mail-il1-f198.google.com with SMTP id t12-20020a92c0cc0000b0290210d3ffca31so391052ilf.21 for ; Tue, 13 Jul 2021 13:47:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=edgULd724qxW2wczl2lL2drDkUNp/TtLehg+wvSDn60=; b=nHe/GWG1eIFPpkDJ09GLzB57IdUB/OD/6p6gx9rA4cI+zWp/MOpOU5eisgdRkGtlG+ 3UC6yzn1ZuGdberCMmnffIHo8C/3R2mSeVVdKD0b3LLCfwE0BtovYMrGZmkLjf7gO1HS JDZcLYpWH8w42iItdgk/up4dqIxWFCF6ewiL58Yb/oVSeo8zfyGsde4XRktjc+cb5g28 2wBogh4nc369x/Xq1bgNtrRHf0fkjstJNci9wjV1RPBErEK9cujGNWt38xuM8k/zxWHC UKF6h6n6sknpgzmP+MdQXXieGk/QnVz+JIWHesXzu5gZ+nbtafuMYHEAHDfikn0FzH89 oPQQ== X-Gm-Message-State: AOAM531e+9NWTN50vtZsB9aJefXtML+ewPSyx1xIONxkpnUv9Eb5xGB1 12uJYXndlv7VMlWhVvbpb8itsasBDwJSJ2lBe5tINb853CDidM+x4wrk4eBaPvvR12a4l3rhpc3 x6h7Arw11uva+YC1OtqXKlkUPzRHIbflL8Fs= X-Received: by 2002:a92:db4e:: with SMTP id w14mr4382866ilq.188.1626209277264; Tue, 13 Jul 2021 13:47:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlRTk8ZYwTep6uQ3YEemMecev8TKW7q7hnLoZpmdpPTnuZHGlGP2olwGFrF73D7gKpIhoktA== X-Received: by 2002:a92:db4e:: with SMTP id w14mr4382859ilq.188.1626209277118; Tue, 13 Jul 2021 13:47:57 -0700 (PDT) Received: from gator ([140.82.166.162]) by smtp.gmail.com with ESMTPSA id s6sm22547ilv.76.2021.07.13.13.47.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jul 2021 13:47:56 -0700 (PDT) Date: Tue, 13 Jul 2021 22:47:54 +0200 From: Andrew Jones To: Alex =?utf-8?Q?Benn=C3=A9e?= Cc: kvm@vger.kernel.org, maz@kernel.org, shashi.mallela@linaro.org, qemu-arm@nongnu.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, pbonzini@redhat.com Subject: Re: [kvm-unit-tests PATCH v2 2/4] scripts/arch-run: don't use deprecated server/nowait options Message-ID: <20210713204754.xg3eawok4m6q7ulk@gator> References: <20210525172628.2088-1-alex.bennee@linaro.org> <20210525172628.2088-3-alex.bennee@linaro.org> MIME-Version: 1.0 In-Reply-To: <20210525172628.2088-3-alex.bennee@linaro.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=drjones@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210713_134804_895418_D7B716F6 X-CRM114-Status: GOOD ( 18.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 25, 2021 at 06:26:26PM +0100, Alex Benn=E9e wrote: > The very fact that QEMU drops the deprecation warning while running is > enough to confuse the its-migration test into failing. The boolean > options server and wait have accepted the long form options for a long > time. > = > Signed-off-by: Alex Benn=E9e > Cc: Shashi Mallela > --- > scripts/arch-run.bash | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > = > diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash > index 5997e38..70693f2 100644 > --- a/scripts/arch-run.bash > +++ b/scripts/arch-run.bash > @@ -122,14 +122,14 @@ run_migration () > trap 'kill 0; exit 2' INT TERM > trap 'rm -f ${migout1} ${migsock} ${qmp1} ${qmp2} ${fifo}' RETURN EXIT > = > - eval "$@" -chardev socket,id=3Dmon1,path=3D${qmp1},server,nowait \ > + eval "$@" -chardev socket,id=3Dmon1,path=3D${qmp1},server=3Don,wait=3Do= ff \ > -mon chardev=3Dmon1,mode=3Dcontrol | tee ${migout1} & > = > # We have to use cat to open the named FIFO, because named FIFO's, unli= ke > # pipes, will block on open() until the other end is also opened, and t= hat > # totally breaks QEMU... > mkfifo ${fifo} > - eval "$@" -chardev socket,id=3Dmon2,path=3D${qmp2},server,nowait \ > + eval "$@" -chardev socket,id=3Dmon2,path=3D${qmp2},server=3Don,wait=3Do= ff \ > -mon chardev=3Dmon2,mode=3Dcontrol -incoming unix:${migsock} < <(cat $= {fifo}) & > incoming_pid=3D`jobs -l %+ | awk '{print$2}'` > = > -- = > 2.20.1 > = > _______________________________________________ > kvmarm mailing list > kvmarm@lists.cs.columbia.edu > https://lists.cs.columbia.edu/mailman/listinfo/kvmarm Applied to misc/queue https://gitlab.com/rhdrjones/kvm-unit-tests/-/commits/misc/queue Thanks, drew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel