From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============6750289246667255220==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: misc: fix swap.cocci warnings Date: Wed, 14 Jul 2021 07:11:03 +0800 Message-ID: <20210713231103.GA123407@d4adf3bbfab1> In-Reply-To: <202107140738.POR2lqk8-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============6750289246667255220== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Denis Efremov CC: Julia Lawall CC: Edward Cree CC: Martin Habets CC: Jakub Kicinski CC: netdev(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/net/ethernet/sfc/efx_channels.c:804:36-37: WARNING opportunity for = swap() drivers/net/ethernet/sfc/efx_channels.c:850:36-37: WARNING opportunity for = swap() Check for opencoded swap() implementation. Generated by: scripts/coccinelle/misc/swap.cocci CC: Denis Efremov Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: 40226a3d96ef8ab8980f032681c8bfd46d63874e commit: 7845daa8bd72efa8bbc1de122edfce6e058bbe41 coccinelle: misc: add swap= script :::::: branch date: 4 hours ago :::::: commit date: 2 months ago Please take the patch only if it's a positive warning. Thanks! efx_channels.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) --- a/drivers/net/ethernet/sfc/efx_channels.c +++ b/drivers/net/ethernet/sfc/efx_channels.c @@ -799,11 +799,9 @@ int efx_realloc_channels(struct efx_nic old_txq_entries =3D efx->txq_entries; efx->rxq_entries =3D rxq_entries; efx->txq_entries =3D txq_entries; - for (i =3D 0; i < efx->n_channels; i++) { - channel =3D efx->channel[i]; - efx->channel[i] =3D other_channel[i]; - other_channel[i] =3D channel; - } + for (i =3D 0; i < efx->n_channels; i++) + = + swap(efx->channel[i], other_channel[i]); = /* Restart buffer table allocation */ efx->next_buffer_table =3D next_buffer_table; @@ -845,11 +843,9 @@ rollback: /* Swap back */ efx->rxq_entries =3D old_rxq_entries; efx->txq_entries =3D old_txq_entries; - for (i =3D 0; i < efx->n_channels; i++) { - channel =3D efx->channel[i]; - efx->channel[i] =3D other_channel[i]; - other_channel[i] =3D channel; - } + for (i =3D 0; i < efx->n_channels; i++) + = + swap(efx->channel[i], other_channel[i]); goto out; } =20 --===============6750289246667255220==--