From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, "Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH] configure: Drop obsolete check for the alloc_size attribute
Date: Wed, 14 Jul 2021 09:28:55 +0200 [thread overview]
Message-ID: <20210714072855.785566-1-thuth@redhat.com> (raw)
We recently bumped our requirement for Clang to at least version 6.0.
And according to:
https://releases.llvm.org/6.0.0/tools/clang/docs/AttributeReference.html
Clang v6.0 supports the alloc_size attribute. Thus we can drop this
check in the configure script now.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
configure | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/configure b/configure
index a0a32c427c..eee1356814 100755
--- a/configure
+++ b/configure
@@ -3184,18 +3184,6 @@ if ! compile_prog "$glib_cflags" "$glib_libs" ; then
"build target"
fi
-# Silence clang 3.5.0 warnings about glib attribute __alloc_size__ usage
-cat > $TMPC << EOF
-#include <glib.h>
-int main(void) { return 0; }
-EOF
-if ! compile_prog "$glib_cflags -Werror" "$glib_libs" ; then
- if cc_has_warning_flag "-Wno-unknown-attributes"; then
- glib_cflags="-Wno-unknown-attributes $glib_cflags"
- CONFIGURE_CFLAGS="-Wno-unknown-attributes $CONFIGURE_CFLAGS"
- fi
-fi
-
# Silence clang warnings triggered by glib < 2.57.2
cat > $TMPC << EOF
#include <glib.h>
--
2.27.0
next reply other threads:[~2021-07-14 7:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 7:28 Thomas Huth [this message]
2021-07-14 8:32 ` [PATCH] configure: Drop obsolete check for the alloc_size attribute Daniel P. Berrangé
2021-07-14 14:56 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210714072855.785566-1-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.