From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0502C11F68 for ; Wed, 14 Jul 2021 11:05:40 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A108C60200 for ; Wed, 14 Jul 2021 11:05:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A108C60200 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nfc-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id DE347100F2253; Wed, 14 Jul 2021 04:05:34 -0700 (PDT) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=185.125.188.121; helo=smtp-relay-canonical-1.canonical.com; envelope-from=krzysztof.kozlowski@canonical.com; receiver= Received: from smtp-relay-canonical-1.canonical.com (smtp-relay-canonical-1.canonical.com [185.125.188.121]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A8AED100EB352 for ; Wed, 14 Jul 2021 04:05:33 -0700 (PDT) Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPS id 8A66040616 for ; Wed, 14 Jul 2021 11:05:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1626260732; bh=Rh/QcZl0YJ3xFLkYpvUV7nz6p1mNkKwNhlIJoaNEb+Y=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=r3mb0XofOvQU+ziEw/zZvH0xaS4NMEWlee+g3k6jMlyocHMlh9jFfH7X7CmuH4vMy P+R0HuxxY4jqfjgtionYq9aOSs57LTeiEN+t6GWypS5cP4Puo6o3sQdAP0/54MYLia Bo8PaAIRqeWCmfTfPm1tfOKNxgVN0rSEQl2DoLyQ8R5c+POo7DwUsIli8N5V9ymYrn FiqlCZSCdQOD7HrXpkuXNeSbEJv4slfhEU81AWW4oJMHrpZdOQ3jq52KnQ08a60kUZ bmLvRVpsL9HILNMoEpgGcG44C2BsW6b+W/MDUvFGbVlTKRdzr1LRGzq4aJhRwhAh0J Q3uHYu8jhsfwg== Received: by mail-ed1-f71.google.com with SMTP id m21-20020a50ef150000b029039c013d5b80so1063954eds.7 for ; Wed, 14 Jul 2021 04:05:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Rh/QcZl0YJ3xFLkYpvUV7nz6p1mNkKwNhlIJoaNEb+Y=; b=DnIqPijD0w68yMleLWkvX4KSGTsfUdi/DDfcryQcF/V2aRE+yYkmANaZlbdLTAW3AL TorbbOpWfTQ2eciLTVxnL9tFK3QZnKKFamW3GpegQtFa3z7glpkscC5eERInO8dX5eGR ZAMRCVJD2kyB3TI712QLK6IHasZkxoSfPklwbOumA7S3XZJmoozF+/DCI1n6TMRRSB4P G1NsbAOr5oAkUvLMElXSYFWY+OxBSpigTNOGzxCnkbeVa8CRyqHj+g54pjbZQpFh52OA gsdCDZv/oppe0C+7yOydPteUcVCOVHl5nuh8Ai7GwyfkztfarC3Fei/HDubDH41urZUW b1BQ== X-Gm-Message-State: AOAM5339cs1y5pArjf83N0U3q0oBcgKfaAB/IsBZls14H1pLD/9d26HH Jid3D8/7MyMmsQxUtRy4cR9SfPcJs9jDoY90Lah5wrhybiH/opfvrEx1Q5J36aFijii64VAVsp2 /PAwqrLfeVBumi+NqcIc6RAeLPc/G7PQaqQ== X-Received: by 2002:a17:906:60d3:: with SMTP id f19mr11926774ejk.413.1626260731860; Wed, 14 Jul 2021 04:05:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwoMyS8QqTi8iv7rGpz5EcjhnOMvp578aKM6RnWHNSFgQwgDqq1odNRbHHP09kP2xAZwqSYZQ== X-Received: by 2002:a17:906:60d3:: with SMTP id f19mr11926765ejk.413.1626260731717; Wed, 14 Jul 2021 04:05:31 -0700 (PDT) Received: from kozik-lap.lan (xdsl-188-155-177-222.adslplus.ch. [188.155.177.222]) by smtp.gmail.com with ESMTPSA id qp12sm637689ejb.90.2021.07.14.04.05.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jul 2021 04:05:31 -0700 (PDT) From: Krzysztof Kozlowski To: linux-nfc@lists.01.org Date: Wed, 14 Jul 2021 13:05:07 +0200 Message-Id: <20210714110518.104655-6-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210714110518.104655-1-krzysztof.kozlowski@canonical.com> References: <20210714110518.104655-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Message-ID-Hash: D4CHPKV6C3QAQK3WKARFQNLPAHAARXEX X-Message-ID-Hash: D4CHPKV6C3QAQK3WKARFQNLPAHAARXEX X-MailFrom: krzysztof.kozlowski@canonical.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Krzysztof Kozlowski X-Mailman-Version: 3.1.1 Precedence: list Subject: [linux-nfc] [neard][PATCH 05/16] build: enable -Wunsafe-loop-optimizations and -Wstrict-overflow=2 warnings List-Id: NFC on Linux Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Enable basic overflow in optimization checks (portability related) and missed loop optimizations. The latter (-Wunsafe-loop-optimizations) does not work well with GCC v7.5 so simply skip it there. Signed-off-by: Krzysztof Kozlowski --- accflags.m4 | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/accflags.m4 b/accflags.m4 index 57cc48beecc2..0030ac339c86 100644 --- a/accflags.m4 +++ b/accflags.m4 @@ -24,6 +24,7 @@ AC_DEFUN([NEARD_COMPILER_FLAGS], [ AX_CHECK_COMPILE_FLAG([-Wjump-misses-init], [CFLAGS="$CFLAGS -Wjump-misses-init"]) AX_CHECK_COMPILE_FLAG([-Wpointer-arith], [CFLAGS="$CFLAGS -Wpointer-arith"]) AX_CHECK_COMPILE_FLAG([-Wshadow], [CFLAGS="$CFLAGS -Wshadow"]) + AX_CHECK_COMPILE_FLAG([-Wstrict-overflow=2], [CFLAGS="$CFLAGS -Wstrict-overflow=2"]) # GCC v5.0 AX_CHECK_COMPILE_FLAG([-Wformat-signedness], [CFLAGS="$CFLAGS -Wformat-signedness"]) @@ -36,10 +37,16 @@ AC_DEFUN([NEARD_COMPILER_FLAGS], [ AX_CHECK_COMPILE_FLAG([-Walloc-zero], [CFLAGS="$CFLAGS -Walloc-zero"]) # GCC v8.0 AX_CHECK_COMPILE_FLAG([-Wstringop-truncation], [CFLAGS="$CFLAGS -Wstringop-truncation"]) + + # GCC v7.5 from Ubuntu Bionic incorrectly assumes several loops can overflow, so enable + # -Wunsafe-loop-optimizations only on newer GCC. + CC_VERSION=`$CC --version | head -n 1 | sed -e 's/.*\ $@<:@0-9@:>@\+\.@<:@0-9@:>@\+\.@<:@0-9@:>@\+$$-@<:@0-9@:>@\+$\?$/\1/'` + AX_COMPARE_VERSION([$CC_VERSION],[ge],[8.0.0], + [AX_CHECK_COMPILE_FLAG([-Wunsafe-loop-optimizations], [CFLAGS="$CFLAGS -Wunsafe-loop-optimizations"])], []) fi if (test "$USE_MAINTAINER_MODE" = "pedantic"); then - AX_CHECK_COMPILE_FLAG([-Wstrict-overflow=3], [CFLAGS="$CFLAGS -Wstrict-overflow=3"]) AX_CHECK_COMPILE_FLAG([-Wcast-qual], [CFLAGS="$CFLAGS -Wcast-qual"]) - AX_CHECK_COMPILE_FLAG([-Wunsafe-loop-optimizations], [CFLAGS="$CFLAGS -Wunsafe-loop-optimizations"]) + # Instead of -Wstrict-overflow=2 + AX_CHECK_COMPILE_FLAG([-Wstrict-overflow=3], [CFLAGS="$CFLAGS -Wstrict-overflow=3"]) fi ]) -- 2.27.0 _______________________________________________ Linux-nfc mailing list -- linux-nfc@lists.01.org To unsubscribe send an email to linux-nfc-leave@lists.01.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1445339055499534039==" MIME-Version: 1.0 From: Krzysztof Kozlowski To: linux-nfc@lists.01.org Subject: [neard][PATCH 05/16] build: enable -Wunsafe-loop-optimizations and -Wstrict-overflow=2 warnings Date: Wed, 14 Jul 2021 13:05:07 +0200 Message-ID: <20210714110518.104655-6-krzysztof.kozlowski@canonical.com> In-Reply-To: <20210714110518.104655-1-krzysztof.kozlowski@canonical.com> List-Id: --===============1445339055499534039== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Enable basic overflow in optimization checks (portability related) and missed loop optimizations. The latter (-Wunsafe-loop-optimizations) does not work well with GCC v7.5 so simply skip it there. Signed-off-by: Krzysztof Kozlowski --- accflags.m4 | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/accflags.m4 b/accflags.m4 index 57cc48beecc2..0030ac339c86 100644 --- a/accflags.m4 +++ b/accflags.m4 @@ -24,6 +24,7 @@ AC_DEFUN([NEARD_COMPILER_FLAGS], [ AX_CHECK_COMPILE_FLAG([-Wjump-misses-init], [CFLAGS=3D"$CFLAGS -Wjump-mi= sses-init"]) AX_CHECK_COMPILE_FLAG([-Wpointer-arith], [CFLAGS=3D"$CFLAGS -Wpointer-ar= ith"]) AX_CHECK_COMPILE_FLAG([-Wshadow], [CFLAGS=3D"$CFLAGS -Wshadow"]) + AX_CHECK_COMPILE_FLAG([-Wstrict-overflow=3D2], [CFLAGS=3D"$CFLAGS -Wstri= ct-overflow=3D2"]) = # GCC v5.0 AX_CHECK_COMPILE_FLAG([-Wformat-signedness], [CFLAGS=3D"$CFLAGS -Wformat= -signedness"]) @@ -36,10 +37,16 @@ AC_DEFUN([NEARD_COMPILER_FLAGS], [ AX_CHECK_COMPILE_FLAG([-Walloc-zero], [CFLAGS=3D"$CFLAGS -Walloc-zero"]) # GCC v8.0 AX_CHECK_COMPILE_FLAG([-Wstringop-truncation], [CFLAGS=3D"$CFLAGS -Wstri= ngop-truncation"]) + + # GCC v7.5 from Ubuntu Bionic incorrectly assumes several loops can over= flow, so enable + # -Wunsafe-loop-optimizations only on newer GCC. + CC_VERSION=3D`$CC --version | head -n 1 | sed -e 's/.*\ $@<:@0-9@:>@\+\= .@<:@0-9@:>@\+\.@<:@0-9@:>@\+$$-@<:@0-9@:>@\+$\?$/\1/'` + AX_COMPARE_VERSION([$CC_VERSION],[ge],[8.0.0], + [AX_CHECK_COMPILE_FLAG([-Wunsafe-loop-optimizations], [CFLAGS=3D"$CFLAG= S -Wunsafe-loop-optimizations"])], []) fi if (test "$USE_MAINTAINER_MODE" =3D "pedantic"); then - AX_CHECK_COMPILE_FLAG([-Wstrict-overflow=3D3], [CFLAGS=3D"$CFLAGS -Wstri= ct-overflow=3D3"]) AX_CHECK_COMPILE_FLAG([-Wcast-qual], [CFLAGS=3D"$CFLAGS -Wcast-qual"]) - AX_CHECK_COMPILE_FLAG([-Wunsafe-loop-optimizations], [CFLAGS=3D"$CFLAGS = -Wunsafe-loop-optimizations"]) + # Instead of -Wstrict-overflow=3D2 + AX_CHECK_COMPILE_FLAG([-Wstrict-overflow=3D3], [CFLAGS=3D"$CFLAGS -Wstri= ct-overflow=3D3"]) fi ]) -- = 2.27.0 --===============1445339055499534039==--