From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D1CFC47E4D for ; Wed, 14 Jul 2021 19:54:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89FC3613C3 for ; Wed, 14 Jul 2021 19:54:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237168AbhGNT5S (ORCPT ); Wed, 14 Jul 2021 15:57:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:45586 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241181AbhGNTu0 (ORCPT ); Wed, 14 Jul 2021 15:50:26 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 88A84613E4; Wed, 14 Jul 2021 19:47:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626292030; bh=SQaQxcoYPD2WkNoTMDKDF1nlZWKMRoqYQhtnlrvxRHw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SPZHnanGevVDraDPERweTW2DJ0soxpaFZizWb2U/mrpZyoGaXMRQbi1Kwx93YoYbI OpiRFEgDr0tT2z7Bl/QPvLKiw/n4OpPmvlOK6V/yTjGb9UWlkFSdZ4r++vG+Ep44Mk MYquQ5DS7J5EUpZOTDCS85NN+9OJiHQae0EtgnIWdSLCd2JIdKdafB34Bd4Lavmv6z 5R+C1pig6MYEJLHB3eWp+CnNzosXo7DMtskwyzc4mX8OocahjBmkQDDmA+NUZ1ld5I 5KZPJa8cxV1xViCW9f/d4+PZzIhPXQieB1dKu+WXec5eab4CUwioaHGyJv0Xw3Ot5y 2UMJDdgl3LJ/Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Mian Yousaf Kaukab , Shawn Guo , Sasha Levin , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 31/39] arm64: dts: ls208xa: remove bus-num from dspi node Date: Wed, 14 Jul 2021 15:46:16 -0400 Message-Id: <20210714194625.55303-31-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210714194625.55303-1-sashal@kernel.org> References: <20210714194625.55303-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mian Yousaf Kaukab [ Upstream commit 8240c972c1798ea013cbb407722295fc826b3584 ] On LS2088A-RDB board, if the spi-fsl-dspi driver is built as module then its probe fails with the following warning: [ 10.471363] couldn't get idr [ 10.471381] WARNING: CPU: 4 PID: 488 at drivers/spi/spi.c:2689 spi_register_controller+0x73c/0x8d0 ... [ 10.471651] fsl-dspi 2100000.spi: Problem registering DSPI ctlr [ 10.471708] fsl-dspi: probe of 2100000.spi failed with error -16 Reason for the failure is that bus-num property is set for dspi node. However, bus-num property is not set for the qspi node. If probe for spi-fsl-qspi happens first then id 0 is dynamically allocated to it. Call to spi_register_controller() from spi-fsl-dspi driver then fails. Since commit 29d2daf2c33c ("spi: spi-fsl-dspi: Make bus-num property optional") bus-num property is optional. Remove bus-num property from dspi node to fix the issue. Signed-off-by: Mian Yousaf Kaukab Signed-off-by: Shawn Guo Signed-off-by: Sasha Levin --- arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi index ebe0cd4bf2b7..8c22ce904e65 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi @@ -479,7 +479,6 @@ dspi: spi@2100000 { clocks = <&clockgen 4 3>; clock-names = "dspi"; spi-num-chipselects = <5>; - bus-num = <0>; }; esdhc: esdhc@2140000 { -- 2.30.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0434EC12002 for ; Wed, 14 Jul 2021 22:55:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1C42610CB for ; Wed, 14 Jul 2021 22:55:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1C42610CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=THPkj87mbbpf3W6t0PNopZpE/tKs8ZF6YxPngLIl55k=; b=XaFviwajwDhT4h riD1ThHbGcGg8t97LX2xcMUa/dDn0Z+tqTvq7otQdTq9jqDUg2dRJsH4VlmjVt6xXpdP1ONaooH8T 88VtPUV2MLBCVcxrTiEo+weP1ghSLfCh6NOnkVtGD/JB5e4gFlEA8JrYouZqgu7NRqc9w8h941Mkg n8epLMfmXKi4rxKxSU+HtxYL9qvGgxP+FFzD8cjFTx0M6q1ucswtMPM8ZOtZY6UyRd068yoFWAGZj De+iqSuq5EFQ9E34J6A+auUsQgh46+ufYsA3HkfByUdH16ys69fYIXRbBdK36PMs0Hm3CPfXMSOAy DHmvVcG/JnGZ89ZqOZqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3nko-00G2KC-2o; Wed, 14 Jul 2021 22:53:22 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3kqc-00Egf4-OH for linux-arm-kernel@lists.infradead.org; Wed, 14 Jul 2021 19:47:12 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 88A84613E4; Wed, 14 Jul 2021 19:47:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626292030; bh=SQaQxcoYPD2WkNoTMDKDF1nlZWKMRoqYQhtnlrvxRHw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SPZHnanGevVDraDPERweTW2DJ0soxpaFZizWb2U/mrpZyoGaXMRQbi1Kwx93YoYbI OpiRFEgDr0tT2z7Bl/QPvLKiw/n4OpPmvlOK6V/yTjGb9UWlkFSdZ4r++vG+Ep44Mk MYquQ5DS7J5EUpZOTDCS85NN+9OJiHQae0EtgnIWdSLCd2JIdKdafB34Bd4Lavmv6z 5R+C1pig6MYEJLHB3eWp+CnNzosXo7DMtskwyzc4mX8OocahjBmkQDDmA+NUZ1ld5I 5KZPJa8cxV1xViCW9f/d4+PZzIhPXQieB1dKu+WXec5eab4CUwioaHGyJv0Xw3Ot5y 2UMJDdgl3LJ/Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Mian Yousaf Kaukab , Shawn Guo , Sasha Levin , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 31/39] arm64: dts: ls208xa: remove bus-num from dspi node Date: Wed, 14 Jul 2021 15:46:16 -0400 Message-Id: <20210714194625.55303-31-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210714194625.55303-1-sashal@kernel.org> References: <20210714194625.55303-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210714_124710_866740_D8EB85F8 X-CRM114-Status: GOOD ( 10.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Mian Yousaf Kaukab [ Upstream commit 8240c972c1798ea013cbb407722295fc826b3584 ] On LS2088A-RDB board, if the spi-fsl-dspi driver is built as module then its probe fails with the following warning: [ 10.471363] couldn't get idr [ 10.471381] WARNING: CPU: 4 PID: 488 at drivers/spi/spi.c:2689 spi_register_controller+0x73c/0x8d0 ... [ 10.471651] fsl-dspi 2100000.spi: Problem registering DSPI ctlr [ 10.471708] fsl-dspi: probe of 2100000.spi failed with error -16 Reason for the failure is that bus-num property is set for dspi node. However, bus-num property is not set for the qspi node. If probe for spi-fsl-qspi happens first then id 0 is dynamically allocated to it. Call to spi_register_controller() from spi-fsl-dspi driver then fails. Since commit 29d2daf2c33c ("spi: spi-fsl-dspi: Make bus-num property optional") bus-num property is optional. Remove bus-num property from dspi node to fix the issue. Signed-off-by: Mian Yousaf Kaukab Signed-off-by: Shawn Guo Signed-off-by: Sasha Levin --- arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi index ebe0cd4bf2b7..8c22ce904e65 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi @@ -479,7 +479,6 @@ dspi: spi@2100000 { clocks = <&clockgen 4 3>; clock-names = "dspi"; spi-num-chipselects = <5>; - bus-num = <0>; }; esdhc: esdhc@2140000 { -- 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel