From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B388C07E96 for ; Thu, 15 Jul 2021 08:07:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F3576610D1 for ; Thu, 15 Jul 2021 08:07:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233350AbhGOIKh (ORCPT ); Thu, 15 Jul 2021 04:10:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:41612 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229810AbhGOIKg (ORCPT ); Thu, 15 Jul 2021 04:10:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0F4FB61362; Thu, 15 Jul 2021 08:07:40 +0000 (UTC) Date: Thu, 15 Jul 2021 10:07:38 +0200 From: Christian Brauner To: Carlos Llamas Cc: Greg Kroah-Hartman , Arve =?utf-8?B?SGrDuG5uZXbDpWc=?= , Todd Kjos , Martijn Coenen , Christian Brauner , Joel Fernandes , Steven Moreland , kernel-team@android.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] binderfs: add support for feature files Message-ID: <20210715080738.oumkwhbcz7lxej65@wittgenstein> References: <20210707162419.15510-1-cmllamas@google.com> <20210715031805.1725878-1-cmllamas@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210715031805.1725878-1-cmllamas@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 15, 2021 at 03:18:03AM +0000, Carlos Llamas wrote: > Provide userspace with a mechanism to discover features supported by > the binder driver to refrain from using any unsupported ones in the > first place. Starting with "oneway_spam_detection" only new features > are to be listed under binderfs and all previous ones are assumed to > be supported. > > Assuming an instance of binderfs has been mounted at /dev/binderfs, > binder feature files can be found under /dev/binderfs/features/. > Usage example: > > $ mkdir /dev/binderfs > $ mount -t binder binder /dev/binderfs > $ cat /dev/binderfs/features/oneway_spam_detection > 1 > > Signed-off-by: Carlos Llamas > --- Looks good, Acked-by: Christian Brauner