Hi Daniel,

I love your patch! Perhaps something to improve:

[auto build test WARNING on asoc/for-next]
[also build test WARNING on sound/for-next robh/for-next v5.14-rc1 next-20210715]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Daniel-Baluta/Read-firmware-tplg-and-machine-driver-name-from-dts-node/20210715-221927
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: m68k-buildonly-randconfig-r006-20210715 (attached as .config)
compiler: m68k-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/f334d71a2e2f944458fcdfa43566fb298ea5411e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Daniel-Baluta/Read-firmware-tplg-and-machine-driver-name-from-dts-node/20210715-221927
        git checkout f334d71a2e2f944458fcdfa43566fb298ea5411e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> sound/soc/sof/sof-of-dev.c:68:5: warning: no previous prototype for 'sof_of_parse' [-Wmissing-prototypes]
      68 | int sof_of_parse(struct platform_device *pdev)
         |     ^~~~~~~~~~~~


vim +/sof_of_parse +68 sound/soc/sof/sof-of-dev.c

    67	
  > 68	int sof_of_parse(struct platform_device *pdev)
    69	{
    70		struct snd_sof_pdata *sof_pdata = platform_get_drvdata(pdev);
    71		struct device_node *np = pdev->dev.of_node;
    72		int ret;
    73	
    74		/* firmware-name is optional in DT */
    75		of_property_read_string(np, "firmware-name", &sof_pdata->fw_filename);
    76	
    77		ret = of_property_read_string(np, "tplg-name", &sof_pdata->tplg_filename);
    78		if (ret < 0)
    79			return ret;
    80	
    81		return 0;
    82	}
    83	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org