[PATCH] crypto: fix flexible_array.cocci warnings

[PATCH] crypto: fix flexible_array.cocci warnings

[Julia Lawall]

From: kernel test robot <lkp@intel.com>

Zero-length and one-element arrays are deprecated, see
Documentation/process/deprecated.rst
Flexible-array members should be used instead.

Generated by: scripts/coccinelle/misc/flexible_array.cocci

Fixes: 7540b2861e52 ("crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ")
CC: Megha Dey <megha.dey@intel.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

tree:   https://github.com/meghadey/crypto for_crypto_avx512
head:   a89c5880f0d6260dd593bf579df26f2a2d56ac32
commit: 7540b2861e5292b5993f8e693fc69510b2a7277a [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
:::::: branch date: 7 hours ago
:::::: commit date: 7 hours ago

 aesni-intel_glue.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/x86/crypto/aesni-intel_glue.c
+++ b/arch/x86/crypto/aesni-intel_glue.c
@@ -87,7 +87,7 @@ struct gcm_context_data {
 	u64 partial_block_len;
 	u64 unused;
 	/* Allocate space for hash_keys later */
-	u8 hash_keys[0];
+	u8 hash_keys[];
 };

 asmlinkage int aesni_set_key(struct crypto_aes_ctx *ctx, const u8 *in_key,

[PATCH] crypto: fix flexible_array.cocci warnings

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]

From: kernel test robot <lkp@intel.com>

Zero-length and one-element arrays are deprecated, see
Documentation/process/deprecated.rst
Flexible-array members should be used instead.

Generated by: scripts/coccinelle/misc/flexible_array.cocci

Fixes: 7540b2861e52 ("crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ")
CC: Megha Dey <megha.dey@intel.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

tree:   https://github.com/meghadey/crypto for_crypto_avx512
head:   a89c5880f0d6260dd593bf579df26f2a2d56ac32
commit: 7540b2861e5292b5993f8e693fc69510b2a7277a [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
:::::: branch date: 7 hours ago
:::::: commit date: 7 hours ago

 aesni-intel_glue.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/x86/crypto/aesni-intel_glue.c
+++ b/arch/x86/crypto/aesni-intel_glue.c
@@ -87,7 +87,7 @@ struct gcm_context_data {
 	u64 partial_block_len;
 	u64 unused;
 	/* Allocate space for hash_keys later */
-	u8 hash_keys[0];
+	u8 hash_keys[];
 };

 asmlinkage int aesni_set_key(struct crypto_aes_ctx *ctx, const u8 *in_key,

Re: [PATCH] crypto: fix flexible_array.cocci warnings

[Herbert Xu]

On Tue, Jun 29, 2021 at 01:48:01PM +0200, Julia Lawall wrote:
> From: kernel test robot <lkp@intel.com>
> 
> Zero-length and one-element arrays are deprecated, see
> Documentation/process/deprecated.rst
> Flexible-array members should be used instead.
> 
> Generated by: scripts/coccinelle/misc/flexible_array.cocci
> 
> Fixes: 7540b2861e52 ("crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ")
> CC: Megha Dey <megha.dey@intel.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> ---
> 
> tree:   https://github.com/meghadey/crypto for_crypto_avx512
> head:   a89c5880f0d6260dd593bf579df26f2a2d56ac32
> commit: 7540b2861e5292b5993f8e693fc69510b2a7277a [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
> :::::: branch date: 7 hours ago
> :::::: commit date: 7 hours ago
> 
>  aesni-intel_glue.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/arch/x86/crypto/aesni-intel_glue.c
> +++ b/arch/x86/crypto/aesni-intel_glue.c
> @@ -87,7 +87,7 @@ struct gcm_context_data {
>  	u64 partial_block_len;
>  	u64 unused;
>  	/* Allocate space for hash_keys later */
> -	u8 hash_keys[0];
> +	u8 hash_keys[];

Unfortunately this patch doesn't apply to the current crypto tree.
But the good news is that the current tree no longer has a zero-
length array in that struct.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: fix flexible_array.cocci warnings

[Herbert Xu]

[-- Attachment #1: Type: text/plain, Size: 1623 bytes --]

On Tue, Jun 29, 2021 at 01:48:01PM +0200, Julia Lawall wrote:
> From: kernel test robot <lkp@intel.com>
> 
> Zero-length and one-element arrays are deprecated, see
> Documentation/process/deprecated.rst
> Flexible-array members should be used instead.
> 
> Generated by: scripts/coccinelle/misc/flexible_array.cocci
> 
> Fixes: 7540b2861e52 ("crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ")
> CC: Megha Dey <megha.dey@intel.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> ---
> 
> tree:   https://github.com/meghadey/crypto for_crypto_avx512
> head:   a89c5880f0d6260dd593bf579df26f2a2d56ac32
> commit: 7540b2861e5292b5993f8e693fc69510b2a7277a [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
> :::::: branch date: 7 hours ago
> :::::: commit date: 7 hours ago
> 
>  aesni-intel_glue.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/arch/x86/crypto/aesni-intel_glue.c
> +++ b/arch/x86/crypto/aesni-intel_glue.c
> @@ -87,7 +87,7 @@ struct gcm_context_data {
>  	u64 partial_block_len;
>  	u64 unused;
>  	/* Allocate space for hash_keys later */
> -	u8 hash_keys[0];
> +	u8 hash_keys[];

Unfortunately this patch doesn't apply to the current crypto tree.
But the good news is that the current tree no longer has a zero-
length array in that struct.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: fix flexible_array.cocci warnings

[Chen, Rong A]

[-- Attachment #1: Type: text/plain, Size: 1604 bytes --]

Hi Herbert,

On 11/20/2021 12:06 PM, Herbert Xu wrote:
> On Fri, Nov 12, 2021 at 11:56:22AM +0100, Julia Lawall wrote:
>> From: kernel test robot <lkp@intel.com>
>>
>>   Zero-length and one-element arrays are deprecated, see
>>   Documentation/process/deprecated.rst
>>   Flexible-array members should be used instead.
>>
>> Generated by: scripts/coccinelle/misc/flexible_array.cocci
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
>> ---
>>
>> tree:   https://github.com/meghadey/crypto crypto-avx512
>> head:   9c8c2ca77f6e2575a130bddb9767d068e1162d71
>> commit: 377aede9f10ee28be954473668bc6d33c6c9db75 [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ

Sorry for the noise, this patch tries to fix the above commit, it seems
the commit is still in the private tree, we have fixed it to avoid 
sending to maintainers.

Best Regards,
Rong Chen

>> :::::: branch date: 7 weeks ago
>> :::::: commit date: 7 weeks ago
>>
>>   aesni-intel_glue.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/arch/x86/crypto/aesni-intel_glue.c
>> +++ b/arch/x86/crypto/aesni-intel_glue.c
>> @@ -87,7 +87,7 @@ struct gcm_context_data {
>>   	u64 partial_block_len;
>>   	u64 unused;
>>   	/* Allocate space for hash_keys later */
>> -	u8 hash_keys[0];
>> +	u8 hash_keys[];
> 
> Which tree did this come from? Not only is this not zero in my
> tree, but it seems to have never been zero in the git history.
> 
> Thanks,
> 

Re: [PATCH] crypto: fix flexible_array.cocci warnings

[Herbert Xu]

On Fri, Nov 12, 2021 at 11:56:22AM +0100, Julia Lawall wrote:
> From: kernel test robot <lkp@intel.com>
> 
>  Zero-length and one-element arrays are deprecated, see
>  Documentation/process/deprecated.rst
>  Flexible-array members should be used instead.
> 
> Generated by: scripts/coccinelle/misc/flexible_array.cocci
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> ---
> 
> tree:   https://github.com/meghadey/crypto crypto-avx512
> head:   9c8c2ca77f6e2575a130bddb9767d068e1162d71
> commit: 377aede9f10ee28be954473668bc6d33c6c9db75 [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
> :::::: branch date: 7 weeks ago
> :::::: commit date: 7 weeks ago
> 
>  aesni-intel_glue.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/arch/x86/crypto/aesni-intel_glue.c
> +++ b/arch/x86/crypto/aesni-intel_glue.c
> @@ -87,7 +87,7 @@ struct gcm_context_data {
>  	u64 partial_block_len;
>  	u64 unused;
>  	/* Allocate space for hash_keys later */
> -	u8 hash_keys[0];
> +	u8 hash_keys[];

Which tree did this come from? Not only is this not zero in my
tree, but it seems to have never been zero in the git history.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: fix flexible_array.cocci warnings

[Herbert Xu]

[-- Attachment #1: Type: text/plain, Size: 1459 bytes --]

On Fri, Nov 12, 2021 at 11:56:22AM +0100, Julia Lawall wrote:
> From: kernel test robot <lkp@intel.com>
> 
>  Zero-length and one-element arrays are deprecated, see
>  Documentation/process/deprecated.rst
>  Flexible-array members should be used instead.
> 
> Generated by: scripts/coccinelle/misc/flexible_array.cocci
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> ---
> 
> tree:   https://github.com/meghadey/crypto crypto-avx512
> head:   9c8c2ca77f6e2575a130bddb9767d068e1162d71
> commit: 377aede9f10ee28be954473668bc6d33c6c9db75 [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
> :::::: branch date: 7 weeks ago
> :::::: commit date: 7 weeks ago
> 
>  aesni-intel_glue.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/arch/x86/crypto/aesni-intel_glue.c
> +++ b/arch/x86/crypto/aesni-intel_glue.c
> @@ -87,7 +87,7 @@ struct gcm_context_data {
>  	u64 partial_block_len;
>  	u64 unused;
>  	/* Allocate space for hash_keys later */
> -	u8 hash_keys[0];
> +	u8 hash_keys[];

Which tree did this come from? Not only is this not zero in my
tree, but it seems to have never been zero in the git history.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[PATCH] crypto: fix flexible_array.cocci warnings

[Julia Lawall]

From: kernel test robot <lkp@intel.com>

 Zero-length and one-element arrays are deprecated, see
 Documentation/process/deprecated.rst
 Flexible-array members should be used instead.

Generated by: scripts/coccinelle/misc/flexible_array.cocci

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

tree:   https://github.com/meghadey/crypto crypto-avx512
head:   9c8c2ca77f6e2575a130bddb9767d068e1162d71
commit: 377aede9f10ee28be954473668bc6d33c6c9db75 [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
:::::: branch date: 7 weeks ago
:::::: commit date: 7 weeks ago

 aesni-intel_glue.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/x86/crypto/aesni-intel_glue.c
+++ b/arch/x86/crypto/aesni-intel_glue.c
@@ -87,7 +87,7 @@ struct gcm_context_data {
 	u64 partial_block_len;
 	u64 unused;
 	/* Allocate space for hash_keys later */
-	u8 hash_keys[0];
+	u8 hash_keys[];
 };

 asmlinkage int aesni_set_key(struct crypto_aes_ctx *ctx, const u8 *in_key,

[PATCH] crypto: fix flexible_array.cocci warnings

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]

From: kernel test robot <lkp@intel.com>

 Zero-length and one-element arrays are deprecated, see
 Documentation/process/deprecated.rst
 Flexible-array members should be used instead.

Generated by: scripts/coccinelle/misc/flexible_array.cocci

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

tree:   https://github.com/meghadey/crypto crypto-avx512
head:   9c8c2ca77f6e2575a130bddb9767d068e1162d71
commit: 377aede9f10ee28be954473668bc6d33c6c9db75 [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
:::::: branch date: 7 weeks ago
:::::: commit date: 7 weeks ago

 aesni-intel_glue.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/x86/crypto/aesni-intel_glue.c
+++ b/arch/x86/crypto/aesni-intel_glue.c
@@ -87,7 +87,7 @@ struct gcm_context_data {
 	u64 partial_block_len;
 	u64 unused;
 	/* Allocate space for hash_keys later */
-	u8 hash_keys[0];
+	u8 hash_keys[];
 };

 asmlinkage int aesni_set_key(struct crypto_aes_ctx *ctx, const u8 *in_key,

[PATCH] crypto: fix flexible_array.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1771 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Megha Dey <megha.dey@intel.com>
CC: Tomasz Kantecki <tomasz.kantecki@intel.com>
CC: Herbert Xu <herbert@gondor.apana.org.au>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: Ingo Molnar <mingo@redhat.com>
CC: Borislav Petkov <bp@alien8.de>
CC: x86(a)kernel.org
CC: "H. Peter Anvin" <hpa@zytor.com>
CC: linux-crypto(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

arch/x86/crypto/aesni-intel_glue.c:90:4-13: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)


 Zero-length and one-element arrays are deprecated, see
 Documentation/process/deprecated.rst
 Flexible-array members should be used instead.

Generated by: scripts/coccinelle/misc/flexible_array.cocci

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/meghadey/crypto crypto-avx512
head:   9c8c2ca77f6e2575a130bddb9767d068e1162d71
commit: 377aede9f10ee28be954473668bc6d33c6c9db75 [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
:::::: branch date: 7 weeks ago
:::::: commit date: 7 weeks ago

Please take the patch only if it's a positive warning. Thanks!

 aesni-intel_glue.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/x86/crypto/aesni-intel_glue.c
+++ b/arch/x86/crypto/aesni-intel_glue.c
@@ -87,7 +87,7 @@ struct gcm_context_data {
 	u64 partial_block_len;
 	u64 unused;
 	/* Allocate space for hash_keys later */
-	u8 hash_keys[0];
+	u8 hash_keys[];
 };
 
 asmlinkage int aesni_set_key(struct crypto_aes_ctx *ctx, const u8 *in_key,

[PATCH] crypto: fix flexible_array.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1771 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Megha Dey <megha.dey@intel.com>
CC: Tomasz Kantecki <tomasz.kantecki@intel.com>
CC: Herbert Xu <herbert@gondor.apana.org.au>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: Ingo Molnar <mingo@redhat.com>
CC: Borislav Petkov <bp@alien8.de>
CC: x86(a)kernel.org
CC: "H. Peter Anvin" <hpa@zytor.com>
CC: linux-crypto(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

arch/x86/crypto/aesni-intel_glue.c:90:4-13: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)


 Zero-length and one-element arrays are deprecated, see
 Documentation/process/deprecated.rst
 Flexible-array members should be used instead.

Generated by: scripts/coccinelle/misc/flexible_array.cocci

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/meghadey/crypto crypto-avx512
head:   9c8c2ca77f6e2575a130bddb9767d068e1162d71
commit: 377aede9f10ee28be954473668bc6d33c6c9db75 [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
:::::: branch date: 5 weeks ago
:::::: commit date: 5 weeks ago

Please take the patch only if it's a positive warning. Thanks!

 aesni-intel_glue.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/x86/crypto/aesni-intel_glue.c
+++ b/arch/x86/crypto/aesni-intel_glue.c
@@ -87,7 +87,7 @@ struct gcm_context_data {
 	u64 partial_block_len;
 	u64 unused;
 	/* Allocate space for hash_keys later */
-	u8 hash_keys[0];
+	u8 hash_keys[];
 };
 
 asmlinkage int aesni_set_key(struct crypto_aes_ctx *ctx, const u8 *in_key,

[PATCH] crypto: fix flexible_array.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1769 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Megha Dey <megha.dey@intel.com>
CC: Tomasz Kantecki <tomasz.kantecki@intel.com>
CC: Herbert Xu <herbert@gondor.apana.org.au>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: Ingo Molnar <mingo@redhat.com>
CC: Borislav Petkov <bp@alien8.de>
CC: x86(a)kernel.org
CC: "H. Peter Anvin" <hpa@zytor.com>
CC: linux-crypto(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

arch/x86/crypto/aesni-intel_glue.c:90:4-13: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)


 Zero-length and one-element arrays are deprecated, see
 Documentation/process/deprecated.rst
 Flexible-array members should be used instead.

Generated by: scripts/coccinelle/misc/flexible_array.cocci

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/meghadey/crypto crypto-avx512
head:   9c8c2ca77f6e2575a130bddb9767d068e1162d71
commit: 377aede9f10ee28be954473668bc6d33c6c9db75 [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
:::::: branch date: 8 days ago
:::::: commit date: 8 days ago

Please take the patch only if it's a positive warning. Thanks!

 aesni-intel_glue.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/x86/crypto/aesni-intel_glue.c
+++ b/arch/x86/crypto/aesni-intel_glue.c
@@ -87,7 +87,7 @@ struct gcm_context_data {
 	u64 partial_block_len;
 	u64 unused;
 	/* Allocate space for hash_keys later */
-	u8 hash_keys[0];
+	u8 hash_keys[];
 };
 
 asmlinkage int aesni_set_key(struct crypto_aes_ctx *ctx, const u8 *in_key,

[PATCH] crypto: fix flexible_array.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1883 bytes --]

CC: kbuild-all(a)lists.01.org
TO: Megha Dey <megha.dey@intel.com>
CC: labuser <labuser@ssp-romleySNB-cdi172.jf.intel.com>
CC: Tomasz Kantecki <tomasz.kantecki@intel.com>
CC: Herbert Xu <herbert@gondor.apana.org.au>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: Ingo Molnar <mingo@redhat.com>
CC: Borislav Petkov <bp@alien8.de>
CC: x86(a)kernel.org
CC: "H. Peter Anvin" <hpa@zytor.com>
CC: linux-crypto(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

arch/x86/crypto/aesni-intel_glue.c:90:4-13: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)


 Zero-length and one-element arrays are deprecated, see
 Documentation/process/deprecated.rst
 Flexible-array members should be used instead.

Generated by: scripts/coccinelle/misc/flexible_array.cocci

Fixes: 7540b2861e52 ("crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ")
CC: Megha Dey <megha.dey@intel.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/meghadey/crypto for_crypto_avx512
head:   a89c5880f0d6260dd593bf579df26f2a2d56ac32
commit: 7540b2861e5292b5993f8e693fc69510b2a7277a [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
:::::: branch date: 7 hours ago
:::::: commit date: 7 hours ago

Please take the patch only if it's a positive warning. Thanks!

 aesni-intel_glue.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/x86/crypto/aesni-intel_glue.c
+++ b/arch/x86/crypto/aesni-intel_glue.c
@@ -87,7 +87,7 @@ struct gcm_context_data {
 	u64 partial_block_len;
 	u64 unused;
 	/* Allocate space for hash_keys later */
-	u8 hash_keys[0];
+	u8 hash_keys[];
 };
 
 asmlinkage int aesni_set_key(struct crypto_aes_ctx *ctx, const u8 *in_key,

[PATCH] crypto: fix flexible_array.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1867 bytes --]

CC: kbuild-all(a)lists.01.org
TO: Megha Dey <megha.dey@intel.com>
CC: Kyung Min Park <kyung.min.park@intel.com>
CC: Tomasz Kantecki <tomasz.kantecki@intel.com>
CC: Herbert Xu <herbert@gondor.apana.org.au>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: Ingo Molnar <mingo@redhat.com>
CC: Borislav Petkov <bp@alien8.de>
CC: x86(a)kernel.org
CC: "H. Peter Anvin" <hpa@zytor.com>
CC: linux-crypto(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

arch/x86/crypto/aesni-intel_glue.c:90:4-13: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)


 Zero-length and one-element arrays are deprecated, see
 Documentation/process/deprecated.rst
 Flexible-array members should be used instead.

Generated by: scripts/coccinelle/misc/flexible_array.cocci

Fixes: 18c54c55949f ("crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ")
CC: Megha Dey <megha.dey@intel.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/km13park/linux-1.git master
head:   18c54c55949fc48a63e5b8cdcb1e883a5aa490e3
commit: 18c54c55949fc48a63e5b8cdcb1e883a5aa490e3 [7/7] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
:::::: branch date: 8 hours ago
:::::: commit date: 8 hours ago

Please take the patch only if it's a positive warning. Thanks!

 aesni-intel_glue.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/x86/crypto/aesni-intel_glue.c
+++ b/arch/x86/crypto/aesni-intel_glue.c
@@ -87,7 +87,7 @@ struct gcm_context_data {
 	u64 partial_block_len;
 	u64 unused;
 	/* Allocate space for hash_keys later */
-	u8 hash_keys[0];
+	u8 hash_keys[];
 };
 
 asmlinkage int aesni_set_key(struct crypto_aes_ctx *ctx, const u8 *in_key,