Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on 4d00e2309398147acdbfefbe1deb4b0e78868466] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Provide-framebuffer-vmap-helpers/20210716-020508 base: 4d00e2309398147acdbfefbe1deb4b0e78868466 config: arm64-randconfig-r035-20210715 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 0e49c54a8cbd3e779e5526a5888c683c01cc3c50) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu # https://github.com/0day-ci/linux/commit/8a0708f4cf232e7fbc4eb6f58cf782200be8912e git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Thomas-Zimmermann/drm-Provide-framebuffer-vmap-helpers/20210716-020508 git checkout 8a0708f4cf232e7fbc4eb6f58cf782200be8912e # save the attached .config to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/gpu/drm/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c:11: >> include/drm/drm_gem_framebuffer_helper.h:39:72: error: use of undeclared identifier 'DRM_FORMAT_MAX_PLANES' int drm_gem_fb_vmap(struct drm_framebuffer *fb, struct dma_buf_map map[DRM_FORMAT_MAX_PLANES]); ^ include/drm/drm_gem_framebuffer_helper.h:40:75: error: use of undeclared identifier 'DRM_FORMAT_MAX_PLANES' void drm_gem_fb_vunmap(struct drm_framebuffer *fb, struct dma_buf_map map[DRM_FORMAT_MAX_PLANES]); ^ 2 errors generated. vim +/DRM_FORMAT_MAX_PLANES +39 include/drm/drm_gem_framebuffer_helper.h 16 17 struct drm_gem_object *drm_gem_fb_get_obj(struct drm_framebuffer *fb, 18 unsigned int plane); 19 void drm_gem_fb_destroy(struct drm_framebuffer *fb); 20 int drm_gem_fb_create_handle(struct drm_framebuffer *fb, struct drm_file *file, 21 unsigned int *handle); 22 23 int drm_gem_fb_init_with_funcs(struct drm_device *dev, 24 struct drm_framebuffer *fb, 25 struct drm_file *file, 26 const struct drm_mode_fb_cmd2 *mode_cmd, 27 const struct drm_framebuffer_funcs *funcs); 28 struct drm_framebuffer * 29 drm_gem_fb_create_with_funcs(struct drm_device *dev, struct drm_file *file, 30 const struct drm_mode_fb_cmd2 *mode_cmd, 31 const struct drm_framebuffer_funcs *funcs); 32 struct drm_framebuffer * 33 drm_gem_fb_create(struct drm_device *dev, struct drm_file *file, 34 const struct drm_mode_fb_cmd2 *mode_cmd); 35 struct drm_framebuffer * 36 drm_gem_fb_create_with_dirty(struct drm_device *dev, struct drm_file *file, 37 const struct drm_mode_fb_cmd2 *mode_cmd); 38 > 39 int drm_gem_fb_vmap(struct drm_framebuffer *fb, struct dma_buf_map map[DRM_FORMAT_MAX_PLANES]); 40 void drm_gem_fb_vunmap(struct drm_framebuffer *fb, struct dma_buf_map map[DRM_FORMAT_MAX_PLANES]); 41 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org