From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/3] netns_helper.sh: Check veth with TST_NEEDS_DRIVERS
Date: Fri, 16 Jul 2021 12:04:14 +0200 [thread overview]
Message-ID: <20210716100415.27410-3-pvorel@suse.cz> (raw)
In-Reply-To: <20210716100415.27410-1-pvorel@suse.cz>
instead loading it with modprobe. ip link can load veth itself
(use the same approach as in tst_net.sh).
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
testcases/kernel/containers/netns/netns_helper.sh | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/testcases/kernel/containers/netns/netns_helper.sh b/testcases/kernel/containers/netns/netns_helper.sh
index 218fcef8c..c296b8726 100755
--- a/testcases/kernel/containers/netns/netns_helper.sh
+++ b/testcases/kernel/containers/netns/netns_helper.sh
@@ -5,7 +5,8 @@
TST_CLEANUP=netns_ns_exec_cleanup
TST_NEEDS_ROOT=1
-TST_NEEDS_CMDS="ip modprobe ping"
+TST_NEEDS_CMDS="ip ping"
+TST_NEEDS_DRIVERS="veth"
. tst_test.sh
# Set to 1 only for test cases using ifconfig (ioctl).
@@ -75,9 +76,6 @@ IFCONF_IN6_ARG=
# On success function returns, on error tst_brk is called and TC is terminated.
netns_setup()
{
-
- modprobe veth > /dev/null 2>&1
-
case "$1" in
ns_exec)
setns_check
--
2.32.0
next prev parent reply other threads:[~2021-07-16 10:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 10:04 [LTP] [PATCH 0/3] netns_helper.sh: cleanup Petr Vorel
2021-07-16 10:04 ` [LTP] [PATCH 1/3] netns_helper.sh: Check for ping Petr Vorel
2021-07-16 10:04 ` Petr Vorel [this message]
2021-07-16 10:04 ` [LTP] [PATCH 3/3] netns_helper.sh: Formatting and style cleanup Petr Vorel
2021-08-02 17:41 ` [LTP] [PATCH 0/3] netns_helper.sh: cleanup Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210716100415.27410-3-pvorel@suse.cz \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.