* Re: [PATCH v2] bus: mhi: core: Improve debug messages for power up
2021-05-03 20:00 [PATCH v2] bus: mhi: core: Improve debug messages for power up Bhaumik Bhatt
@ 2021-05-03 22:33 ` Hemant Kumar
2021-05-04 17:16 ` Jeffrey Hugo
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Hemant Kumar @ 2021-05-03 22:33 UTC (permalink / raw)
To: Bhaumik Bhatt, manivannan.sadhasivam
Cc: linux-arm-msm, jhugo, linux-kernel, loic.poulain
On 5/3/21 1:00 PM, Bhaumik Bhatt wrote:
> Improve error message to be more descriptive if a failure occurs
> with an invalid power up execution environment. Additionally, add
> a debug log to print the execution environment and MHI state
> before a power up is attempted to confirm if the device is in an
> expected state. This helps clarify reasons for power up failures
> such as the device being found in a PBL or Emergency Download
> Mode execution environment and the host expected a full power up
> with Pass-Through and no image loading involved.
>
> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
Reviewed-by: Hemant Kumar <hemantk@codeaurora.org>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] bus: mhi: core: Improve debug messages for power up
2021-05-03 20:00 [PATCH v2] bus: mhi: core: Improve debug messages for power up Bhaumik Bhatt
2021-05-03 22:33 ` Hemant Kumar
@ 2021-05-04 17:16 ` Jeffrey Hugo
2021-05-21 13:14 ` Manivannan Sadhasivam
2021-07-16 11:55 ` Manivannan Sadhasivam
3 siblings, 0 replies; 5+ messages in thread
From: Jeffrey Hugo @ 2021-05-04 17:16 UTC (permalink / raw)
To: Bhaumik Bhatt, manivannan.sadhasivam
Cc: linux-arm-msm, hemantk, linux-kernel, loic.poulain
On 5/3/2021 2:00 PM, Bhaumik Bhatt wrote:
> Improve error message to be more descriptive if a failure occurs
> with an invalid power up execution environment. Additionally, add
> a debug log to print the execution environment and MHI state
> before a power up is attempted to confirm if the device is in an
> expected state. This helps clarify reasons for power up failures
> such as the device being found in a PBL or Emergency Download
> Mode execution environment and the host expected a full power up
> with Pass-Through and no image loading involved.
>
> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] bus: mhi: core: Improve debug messages for power up
2021-05-03 20:00 [PATCH v2] bus: mhi: core: Improve debug messages for power up Bhaumik Bhatt
2021-05-03 22:33 ` Hemant Kumar
2021-05-04 17:16 ` Jeffrey Hugo
@ 2021-05-21 13:14 ` Manivannan Sadhasivam
2021-07-16 11:55 ` Manivannan Sadhasivam
3 siblings, 0 replies; 5+ messages in thread
From: Manivannan Sadhasivam @ 2021-05-21 13:14 UTC (permalink / raw)
To: Bhaumik Bhatt; +Cc: linux-arm-msm, hemantk, jhugo, linux-kernel, loic.poulain
On Mon, May 03, 2021 at 01:00:38PM -0700, Bhaumik Bhatt wrote:
> Improve error message to be more descriptive if a failure occurs
> with an invalid power up execution environment. Additionally, add
> a debug log to print the execution environment and MHI state
> before a power up is attempted to confirm if the device is in an
> expected state. This helps clarify reasons for power up failures
> such as the device being found in a PBL or Emergency Download
> Mode execution environment and the host expected a full power up
> with Pass-Through and no image loading involved.
>
> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
> ---
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> v2: Use power up instead of power on and update commit text with an example.
>
> drivers/bus/mhi/core/pm.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
> index adf426c..f4a8b9a 100644
> --- a/drivers/bus/mhi/core/pm.c
> +++ b/drivers/bus/mhi/core/pm.c
> @@ -1076,12 +1076,16 @@ int mhi_async_power_up(struct mhi_controller *mhi_cntrl)
>
> /* Confirm that the device is in valid exec env */
> if (!MHI_IN_PBL(current_ee) && current_ee != MHI_EE_AMSS) {
> - dev_err(dev, "Not a valid EE for power on\n");
> + dev_err(dev, "%s is not a valid EE for power on\n",
> + TO_MHI_EXEC_STR(current_ee));
> ret = -EIO;
> goto error_async_power_up;
> }
>
> state = mhi_get_mhi_state(mhi_cntrl);
> + dev_dbg(dev, "Attempting power on with EE: %s, state: %s\n",
> + TO_MHI_EXEC_STR(current_ee), TO_MHI_STATE_STR(state));
> +
> if (state == MHI_STATE_SYS_ERR) {
> mhi_set_mhi_state(mhi_cntrl, MHI_STATE_RESET);
> ret = wait_event_timeout(mhi_cntrl->state_event,
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] bus: mhi: core: Improve debug messages for power up
2021-05-03 20:00 [PATCH v2] bus: mhi: core: Improve debug messages for power up Bhaumik Bhatt
` (2 preceding siblings ...)
2021-05-21 13:14 ` Manivannan Sadhasivam
@ 2021-07-16 11:55 ` Manivannan Sadhasivam
3 siblings, 0 replies; 5+ messages in thread
From: Manivannan Sadhasivam @ 2021-07-16 11:55 UTC (permalink / raw)
To: Bhaumik Bhatt; +Cc: linux-arm-msm, hemantk, jhugo, linux-kernel, loic.poulain
On Mon, May 03, 2021 at 01:00:38PM -0700, Bhaumik Bhatt wrote:
> Improve error message to be more descriptive if a failure occurs
> with an invalid power up execution environment. Additionally, add
> a debug log to print the execution environment and MHI state
> before a power up is attempted to confirm if the device is in an
> expected state. This helps clarify reasons for power up failures
> such as the device being found in a PBL or Emergency Download
> Mode execution environment and the host expected a full power up
> with Pass-Through and no image loading involved.
>
> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
Applied to mhi-next!
Thanks,
Mani
> ---
> v2: Use power up instead of power on and update commit text with an example.
>
> drivers/bus/mhi/core/pm.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
> index adf426c..f4a8b9a 100644
> --- a/drivers/bus/mhi/core/pm.c
> +++ b/drivers/bus/mhi/core/pm.c
> @@ -1076,12 +1076,16 @@ int mhi_async_power_up(struct mhi_controller *mhi_cntrl)
>
> /* Confirm that the device is in valid exec env */
> if (!MHI_IN_PBL(current_ee) && current_ee != MHI_EE_AMSS) {
> - dev_err(dev, "Not a valid EE for power on\n");
> + dev_err(dev, "%s is not a valid EE for power on\n",
> + TO_MHI_EXEC_STR(current_ee));
> ret = -EIO;
> goto error_async_power_up;
> }
>
> state = mhi_get_mhi_state(mhi_cntrl);
> + dev_dbg(dev, "Attempting power on with EE: %s, state: %s\n",
> + TO_MHI_EXEC_STR(current_ee), TO_MHI_STATE_STR(state));
> +
> if (state == MHI_STATE_SYS_ERR) {
> mhi_set_mhi_state(mhi_cntrl, MHI_STATE_RESET);
> ret = wait_event_timeout(mhi_cntrl->state_event,
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
^ permalink raw reply [flat|nested] 5+ messages in thread