From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA97DC07E95 for ; Fri, 16 Jul 2021 13:22:03 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 5A2DC613F5 for ; Fri, 16 Jul 2021 13:22:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A2DC613F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B36164067B; Fri, 16 Jul 2021 15:22:02 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 2842F40151; Fri, 16 Jul 2021 15:22:01 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10046"; a="190408956" X-IronPort-AV: E=Sophos;i="5.84,245,1620716400"; d="scan'208";a="190408956" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2021 06:21:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,245,1620716400"; d="scan'208";a="506893246" Received: from silpixa00401122.ir.intel.com ([10.55.128.10]) by fmsmga002.fm.intel.com with ESMTP; 16 Jul 2021 06:21:58 -0700 From: Kevin Laatz To: dev@dpdk.org Cc: stable@dpdk.org, bruce.richardson@intel.com, konstantin.ananyev@intel.com, Kevin Laatz Date: Fri, 16 Jul 2021 13:21:55 +0000 Message-Id: <20210716132155.1498858-1-kevin.laatz@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] raw/ioat: fix config script queue size calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The queue size calculation is currently based on "max_tokens" rather than "max_work_queues_size". This is resulting in the queue size being incorrectly configured when using the script to configure devices bound to the IDXD kernel driver. This patch fixes this miscalculation so devices are configured with appropriate queue size. Fixes: 01863b9d2354 ("raw/ioat: include example configuration script") Cc: stable@dpdk.org Reported-by: Konstantin Ananyev Signed-off-by: Kevin Laatz --- drivers/raw/ioat/dpdk_idxd_cfg.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/raw/ioat/dpdk_idxd_cfg.py b/drivers/raw/ioat/dpdk_idxd_cfg.py index 83ef4817db..fcc27822ef 100755 --- a/drivers/raw/ioat/dpdk_idxd_cfg.py +++ b/drivers/raw/ioat/dpdk_idxd_cfg.py @@ -63,7 +63,7 @@ def configure_dsa(dsa_id, queues, prefix): max_groups = dsa_dir.read_int("max_groups") max_engines = dsa_dir.read_int("max_engines") max_queues = dsa_dir.read_int("max_work_queues") - max_tokens = dsa_dir.read_int("max_tokens") + max_work_queues_size = dsa_dir.read_int("max_work_queues_size") nb_queues = min(queues, max_queues) if queues > nb_queues: @@ -82,7 +82,7 @@ def configure_dsa(dsa_id, queues, prefix): "mode": "dedicated", "name": f"{prefix}_wq{dsa_id}.{q}", "priority": 1, - "size": int(max_tokens / nb_queues)}) + "size": int(max_work_queues_size / nb_queues)}) # enable device and then queues drv_dir.write_values({"bind": f"dsa{dsa_id}"}) -- 2.25.1