From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 515F6C07E95 for ; Fri, 16 Jul 2021 13:39:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D1E4613CF for ; Fri, 16 Jul 2021 13:39:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D1E4613CF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PNAyUjuU6hbKBrF8cU3DuvBxu+sITfLgZWIikEYqWeE=; b=MftAK3OMAcCHwa n/73LzMJTmbtLni3SZTsL7kSwng13zRvsSDPKKdqwcoiA6Y6Gx96Ah3CN8Qe6yV+VSBvvalfvh981 vkf6i/6c4KLd1hO53lv36u+6vBykFw/Nzb3P0QMkBmtHZ9jGQr2DFIYwo0aX4GIxqXpIIrfFTXGvR G7ZMB3uN5opAMu1UEi5sRVXYUSFFzFPokALqflSsAZO9VWpDdmv7gg/j1dRgi/AG7QfE2FiivaL/M mjBbX6dcnz+hGmBy4Vl5+AIBJ4eq+GzPAj5gemQwidbmtmViOXPZAgYfw6aVRfMptH/RbikV0BSlQ OhZQU5BmTGOAIsM3PTnw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4O2i-004UxZ-7C; Fri, 16 Jul 2021 13:38:16 +0000 Received: from mail-vs1-xe36.google.com ([2607:f8b0:4864:20::e36]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4O27-004Uo2-V1 for linux-arm-kernel@lists.infradead.org; Fri, 16 Jul 2021 13:37:41 +0000 Received: by mail-vs1-xe36.google.com with SMTP id j2so4997651vsi.6 for ; Fri, 16 Jul 2021 06:37:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=29tGu7Jw6R+XmEZO+EF4/Zlq4E8B9TGPW6KpGfcZ3+4=; b=NycHxGd14rekKl1LJSNVnrhvD8hRFYQvmAzYPEsP7ErZLTFfmpFiL5uvtBztc0jLut 1tCdlvoNiOyfO4i+3vQVYpmtRzB4HagMefbkJFqwnq2GCigHi+ZEaK9yEjAzpkhGOH6B ApDuTIsNqc1AtBO273YgklEoBHMfOkjWS3sveuFzVHudNIzkFmCVevFTMeb1WNzS6Skj qvfYRx0b8gaVExLR3pB8PYNrVJMkapZ5BwC1ZmRv+WGhIEGmqA9KZOGOTlcBsuEegQZT Au39yz2fPjP/2ijsskXf5g2ZxFwWQZHPJpiqb3iRc7YL1FmK68GqGFU/urnRax+tyO4c u7SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=29tGu7Jw6R+XmEZO+EF4/Zlq4E8B9TGPW6KpGfcZ3+4=; b=nAyW8NEs0w1RGV/agvJAfd24LYI9uv7e13Xupmf6hGlZ0FTPD5tNk8HnIZUJx6P2tO 7iYWBDHMQ5RtPmtcAUGhEMoRtCFmY0SF58Tdqqhhp9fZeCooEzzzMiJZ9EPKQjsKoXvQ 7rFKeyj9Yvr2tAqxLEDPCy1KxJNfIYNEKD45t0RkVvh4IGBzG35x6fUqsHcTG8vGGfoF 5J4Xqap99RTBsuAeFUsvPf6NmXb9rtGuoli1FrmneJJ8aq+A18mgBDqVGlIONSByvnRp bYI9kKnJcCv4B6HXBbxY1syKytgTSQTJ0vHGd8R7ux2ZM7HcBwe7C0vpNZaaMoUYMw7K IqfA== X-Gm-Message-State: AOAM533oW/cA+hHyroqvoCvs/0ZgLcKIklWMqWXWJ4vNaaLdCXW1wC5Y 8Su+yxEOI6TfCuLPeifdblg= X-Google-Smtp-Source: ABdhPJzpWWzTBi1aYmFC0Da8cwdMWjJFTvwryix11VOUHM9KoooHjf3lPfSF1Wyqu+7Ovh7xwVvhJQ== X-Received: by 2002:a67:e24d:: with SMTP id w13mr12197208vse.0.1626442658787; Fri, 16 Jul 2021 06:37:38 -0700 (PDT) Received: from localhost.localdomain ([2804:14c:485:504a:9f0b:cb12:835a:e9f9]) by smtp.gmail.com with ESMTPSA id 184sm1352572vks.33.2021.07.16.06.37.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jul 2021 06:37:38 -0700 (PDT) From: Fabio Estevam To: shawnguo@kernel.org Cc: linux-arm-kernel@lists.infradead.org, o.rempel@pengutronix.de, Markus.Niebel@tq-group.com, Fabio Estevam Subject: [PATCH 4/4] ARM: dts: imx7d-sdb: Fix the SPI chipselect polarity Date: Fri, 16 Jul 2021 10:36:59 -0300 Message-Id: <20210716133659.3372047-4-festevam@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210716133659.3372047-1-festevam@gmail.com> References: <20210716133659.3372047-1-festevam@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210716_063740_039533_F4429655 X-CRM114-Status: GOOD ( 15.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The following warning is seen when the SPI GPIO driver probes: gpio-expander@0 enforce active low on chipselect handle The reason for this warning is clearly explained in the comments inside drivers/gpio/gpiolib-of.c: * SPI children have active low chip selects * by default. This can be specified negatively * by just omitting "spi-cs-high" in the * device node, or actively by tagging on * GPIO_ACTIVE_LOW as flag in the device * tree. If the line is simultaneously * tagged as active low in the device tree * and has the "spi-cs-high" set, we get a * conflict and the "spi-cs-high" flag will * take precedence. To properly represent the SPI chipselect polarity, change it to active-low when the "spi-cs-high" property is absent. Signed-off-by: Fabio Estevam --- arch/arm/boot/dts/imx7d-sdb.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-sdb.dts index 4a0d83784d7d..7813ef960f6e 100644 --- a/arch/arm/boot/dts/imx7d-sdb.dts +++ b/arch/arm/boot/dts/imx7d-sdb.dts @@ -45,7 +45,7 @@ spi4 { pinctrl-0 = <&pinctrl_spi4>; gpio-sck = <&gpio1 13 GPIO_ACTIVE_HIGH>; gpio-mosi = <&gpio1 9 GPIO_ACTIVE_HIGH>; - cs-gpios = <&gpio1 12 GPIO_ACTIVE_HIGH>; + cs-gpios = <&gpio1 12 GPIO_ACTIVE_LOW>; num-chipselects = <1>; #address-cells = <1>; #size-cells = <0>; -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel