From: Greg Kurz <groug@kaod.org>
To: Daniel Henrique Barboza <danielhb413@gmail.com>
Cc: armbru@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
eblake@redhat.com, david@gibson.dropbear.id.au
Subject: Re: [PATCH v5 4/7] qapi/qdev.json: fix DEVICE_DELETED parameters doc
Date: Fri, 16 Jul 2021 14:47:57 +0200 [thread overview]
Message-ID: <20210716144757.6c53cec3@bahia.lan> (raw)
In-Reply-To: <20210712194339.813152-5-danielhb413@gmail.com>
On Mon, 12 Jul 2021 16:43:36 -0300
Daniel Henrique Barboza <danielhb413@gmail.com> wrote:
> Clarify that @device is optional and that 'path' is the device
> path from QOM.
>
> This change follows Markus' suggestion verbatim, provided in full
> context here:
>
> https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg01891.html
>
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
> ---
Reviewed-by: Greg Kurz <groug@kaod.org>
> qapi/qdev.json | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/qdev.json b/qapi/qdev.json
> index b83178220b..d1d3681a50 100644
> --- a/qapi/qdev.json
> +++ b/qapi/qdev.json
> @@ -108,9 +108,9 @@
> # At this point, it's safe to reuse the specified device ID. Device removal can
> # be initiated by the guest or by HMP/QMP commands.
> #
> -# @device: device name
> +# @device: the device's ID if it has one
> #
> -# @path: device path
> +# @path: the device's path within the object model
> #
> # Since: 1.5
> #
next prev parent reply other threads:[~2021-07-16 12:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 19:43 [PATCH v5 0/7] DEVICE_UNPLUG_ERROR QAPI event Daniel Henrique Barboza
2021-07-12 19:43 ` [PATCH v5 1/7] hw/acpi/memory_hotplug.c: avoid sending MEM_UNPLUG_ERROR if dev->id is NULL Daniel Henrique Barboza
2021-07-16 11:20 ` Greg Kurz
2021-07-12 19:43 ` [PATCH v5 2/7] spapr.c: " Daniel Henrique Barboza
2021-07-16 11:21 ` Greg Kurz
2021-07-12 19:43 ` [PATCH v5 3/7] spapr_drc.c: do not error_report() when drc->dev->id == NULL Daniel Henrique Barboza
2021-07-16 12:44 ` Greg Kurz
2021-07-12 19:43 ` [PATCH v5 4/7] qapi/qdev.json: fix DEVICE_DELETED parameters doc Daniel Henrique Barboza
2021-07-16 12:47 ` Greg Kurz [this message]
2021-07-12 19:43 ` [PATCH v5 5/7] qapi/qdev.json: add DEVICE_UNPLUG_ERROR QAPI event Daniel Henrique Barboza
2021-07-16 13:04 ` Greg Kurz
2021-07-19 4:07 ` David Gibson
2021-07-12 19:43 ` [PATCH v5 6/7] spapr: use DEVICE_UNPLUG_ERROR to report unplug errors Daniel Henrique Barboza
2021-07-16 13:12 ` Greg Kurz
2021-07-12 19:43 ` [PATCH v5 7/7] memory_hotplug.c: send DEVICE_UNPLUG_ERROR in acpi_memory_hotplug_write() Daniel Henrique Barboza
2021-07-16 13:14 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210716144757.6c53cec3@bahia.lan \
--to=groug@kaod.org \
--cc=armbru@redhat.com \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.