From: Tom Rini <trini@konsulko.com>
To: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Cc: u-boot@lists.denx.de, Heinrich Schuchardt <xypron.glpk@gmx.de>,
Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH v2 3/3] lib/vsprintf.c: remove unused ip6_addr_string()
Date: Fri, 16 Jul 2021 11:52:29 -0400 [thread overview]
Message-ID: <20210716155229.GW9379@bill-the-cat> (raw)
In-Reply-To: <20210527222046.1276246-4-rasmus.villemoes@prevas.dk>
[-- Attachment #1: Type: text/plain, Size: 708 bytes --]
On Fri, May 28, 2021 at 12:20:46AM +0200, Rasmus Villemoes wrote:
> There's currently no user of %p[iI]6, so including ip6_addr_string()
> in the image is a waste of bytes. It's easy enough to have the
> compiler elide it without removing the code completely.
>
> The closest I can find to anybody "handling" ipv6 in U-Boot currently
> is in efi_net.c which does
>
> if (ipv6) {
> ret = EFI_UNSUPPORTED;
>
> As indicated in the comment, it can easily be put back, but preferably
> under a config knob.
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2021-07-16 15:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 22:20 [PATCH v2 0/3] trivial printf patches Rasmus Villemoes
2021-05-27 22:20 ` [PATCH v2 1/3] lib/vsprintf.c: implement printf() in terms of vprintf() Rasmus Villemoes
2021-07-16 15:52 ` Tom Rini
2021-05-27 22:20 ` [PATCH v2 2/3] lib/vsprintf.c: remove stale comment Rasmus Villemoes
2021-07-16 15:52 ` Tom Rini
2021-05-27 22:20 ` [PATCH v2 3/3] lib/vsprintf.c: remove unused ip6_addr_string() Rasmus Villemoes
2021-07-16 15:52 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210716155229.GW9379@bill-the-cat \
--to=trini@konsulko.com \
--cc=rasmus.villemoes@prevas.dk \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.