From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81BCBC636CA for ; Fri, 16 Jul 2021 22:23:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4224A613DF for ; Fri, 16 Jul 2021 22:23:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4224A613DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 844146E9DC; Fri, 16 Jul 2021 22:23:33 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id BAE5E6E8C8; Fri, 16 Jul 2021 22:23:31 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10047"; a="210849575" X-IronPort-AV: E=Sophos;i="5.84,246,1620716400"; d="scan'208";a="210849575" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2021 15:23:31 -0700 X-IronPort-AV: E=Sophos;i="5.84,246,1620716400"; d="scan'208";a="413571892" Received: from dut151-iclu.fm.intel.com ([10.105.23.43]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2021 15:23:30 -0700 Date: Fri, 16 Jul 2021 22:23:27 +0000 From: Matthew Brost To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 49/51] drm/i915/selftest: Bump selftest timeouts for hangcheck Message-ID: <20210716222327.GA10146@DUT151-ICLU.fm.intel.com> References: <20210716201724.54804-1-matthew.brost@intel.com> <20210716201724.54804-50-matthew.brost@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210716201724.54804-50-matthew.brost@intel.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: daniele.ceraolospurio@intel.com, john.c.harrison@intel.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Jul 16, 2021 at 01:17:22PM -0700, Matthew Brost wrote: > From: John Harrison > > Some testing environments and some heavier tests are slower than > previous limits allowed for. For example, it can take multiple seconds > for the 'context has been reset' notification handler to reach the > 'kill the requests' code in the 'active' version of the 'reset > engines' test. During which time the selftest gets bored, gives up > waiting and fails the test. > > There is also an async thread that the selftest uses to pump work > through the hardware in parallel to the context that is marked for > reset. That also could get bored waiting for completions and kill the > test off. > > Lastly, the flush at the of various test sections can also see > timeouts due to the large amount of work backed up. This is also true > of the live_hwsp_read test. > > Signed-off-by: John Harrison > Signed-off-by: Matthew Brost > Cc: Daniele Ceraolo Spurio Reviewed-by: Matthew Brost > --- > drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 2 +- > drivers/gpu/drm/i915/selftests/igt_flush_test.c | 2 +- > drivers/gpu/drm/i915/selftests/intel_scheduler_helpers.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c > index 971c0c249eb0..a93a9b0d258e 100644 > --- a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c > +++ b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c > @@ -876,7 +876,7 @@ static int active_request_put(struct i915_request *rq) > if (!rq) > return 0; > > - if (i915_request_wait(rq, 0, 5 * HZ) < 0) { > + if (i915_request_wait(rq, 0, 10 * HZ) < 0) { > GEM_TRACE("%s timed out waiting for completion of fence %llx:%lld\n", > rq->engine->name, > rq->fence.context, > diff --git a/drivers/gpu/drm/i915/selftests/igt_flush_test.c b/drivers/gpu/drm/i915/selftests/igt_flush_test.c > index 7b0939e3f007..a6c71fca61aa 100644 > --- a/drivers/gpu/drm/i915/selftests/igt_flush_test.c > +++ b/drivers/gpu/drm/i915/selftests/igt_flush_test.c > @@ -19,7 +19,7 @@ int igt_flush_test(struct drm_i915_private *i915) > > cond_resched(); > > - if (intel_gt_wait_for_idle(gt, HZ / 5) == -ETIME) { > + if (intel_gt_wait_for_idle(gt, HZ) == -ETIME) { > pr_err("%pS timed out, cancelling all further testing.\n", > __builtin_return_address(0)); > > diff --git a/drivers/gpu/drm/i915/selftests/intel_scheduler_helpers.c b/drivers/gpu/drm/i915/selftests/intel_scheduler_helpers.c > index 69db139f9e0d..ebd6d69b3315 100644 > --- a/drivers/gpu/drm/i915/selftests/intel_scheduler_helpers.c > +++ b/drivers/gpu/drm/i915/selftests/intel_scheduler_helpers.c > @@ -13,7 +13,7 @@ > > #define REDUCED_TIMESLICE 5 > #define REDUCED_PREEMPT 10 > -#define WAIT_FOR_RESET_TIME 1000 > +#define WAIT_FOR_RESET_TIME 10000 > > int intel_selftest_modify_policy(struct intel_engine_cs *engine, > struct intel_selftest_saved_policy *saved, > -- > 2.28.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C13AFC12002 for ; Fri, 16 Jul 2021 22:23:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70646613DF for ; Fri, 16 Jul 2021 22:23:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70646613DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 18E0B6E8C8; Fri, 16 Jul 2021 22:23:33 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id BAE5E6E8C8; Fri, 16 Jul 2021 22:23:31 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10047"; a="210849575" X-IronPort-AV: E=Sophos;i="5.84,246,1620716400"; d="scan'208";a="210849575" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2021 15:23:31 -0700 X-IronPort-AV: E=Sophos;i="5.84,246,1620716400"; d="scan'208";a="413571892" Received: from dut151-iclu.fm.intel.com ([10.105.23.43]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2021 15:23:30 -0700 Date: Fri, 16 Jul 2021 22:23:27 +0000 From: Matthew Brost To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Message-ID: <20210716222327.GA10146@DUT151-ICLU.fm.intel.com> References: <20210716201724.54804-1-matthew.brost@intel.com> <20210716201724.54804-50-matthew.brost@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210716201724.54804-50-matthew.brost@intel.com> Subject: Re: [Intel-gfx] [PATCH 49/51] drm/i915/selftest: Bump selftest timeouts for hangcheck X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Jul 16, 2021 at 01:17:22PM -0700, Matthew Brost wrote: > From: John Harrison > > Some testing environments and some heavier tests are slower than > previous limits allowed for. For example, it can take multiple seconds > for the 'context has been reset' notification handler to reach the > 'kill the requests' code in the 'active' version of the 'reset > engines' test. During which time the selftest gets bored, gives up > waiting and fails the test. > > There is also an async thread that the selftest uses to pump work > through the hardware in parallel to the context that is marked for > reset. That also could get bored waiting for completions and kill the > test off. > > Lastly, the flush at the of various test sections can also see > timeouts due to the large amount of work backed up. This is also true > of the live_hwsp_read test. > > Signed-off-by: John Harrison > Signed-off-by: Matthew Brost > Cc: Daniele Ceraolo Spurio Reviewed-by: Matthew Brost > --- > drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 2 +- > drivers/gpu/drm/i915/selftests/igt_flush_test.c | 2 +- > drivers/gpu/drm/i915/selftests/intel_scheduler_helpers.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c > index 971c0c249eb0..a93a9b0d258e 100644 > --- a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c > +++ b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c > @@ -876,7 +876,7 @@ static int active_request_put(struct i915_request *rq) > if (!rq) > return 0; > > - if (i915_request_wait(rq, 0, 5 * HZ) < 0) { > + if (i915_request_wait(rq, 0, 10 * HZ) < 0) { > GEM_TRACE("%s timed out waiting for completion of fence %llx:%lld\n", > rq->engine->name, > rq->fence.context, > diff --git a/drivers/gpu/drm/i915/selftests/igt_flush_test.c b/drivers/gpu/drm/i915/selftests/igt_flush_test.c > index 7b0939e3f007..a6c71fca61aa 100644 > --- a/drivers/gpu/drm/i915/selftests/igt_flush_test.c > +++ b/drivers/gpu/drm/i915/selftests/igt_flush_test.c > @@ -19,7 +19,7 @@ int igt_flush_test(struct drm_i915_private *i915) > > cond_resched(); > > - if (intel_gt_wait_for_idle(gt, HZ / 5) == -ETIME) { > + if (intel_gt_wait_for_idle(gt, HZ) == -ETIME) { > pr_err("%pS timed out, cancelling all further testing.\n", > __builtin_return_address(0)); > > diff --git a/drivers/gpu/drm/i915/selftests/intel_scheduler_helpers.c b/drivers/gpu/drm/i915/selftests/intel_scheduler_helpers.c > index 69db139f9e0d..ebd6d69b3315 100644 > --- a/drivers/gpu/drm/i915/selftests/intel_scheduler_helpers.c > +++ b/drivers/gpu/drm/i915/selftests/intel_scheduler_helpers.c > @@ -13,7 +13,7 @@ > > #define REDUCED_TIMESLICE 5 > #define REDUCED_PREEMPT 10 > -#define WAIT_FOR_RESET_TIME 1000 > +#define WAIT_FOR_RESET_TIME 10000 > > int intel_selftest_modify_policy(struct intel_engine_cs *engine, > struct intel_selftest_saved_policy *saved, > -- > 2.28.0 > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx