All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/qemu: virtfs needs system
Date: Fri, 16 Jul 2021 23:19:34 +0200	[thread overview]
Message-ID: <20210716231934.18eb81ee@windsurf> (raw)
In-Reply-To: <20210710155409.1333292-1-fontaine.fabrice@gmail.com>

On Sat, 10 Jul 2021 17:54:09 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

>  config BR2_PACKAGE_HOST_QEMU_VIRTFS
>  	bool "Virtual filesystem support"
> +	depends on BR2_PACKAGE_HOST_QEMU_SYSTEM_ARCH_SUPPORTS
> +	select BR2_PACKAGE_HOST_QEMU_SYSTEM_MODE

I think a:

	depends on BR2_PACKAGE_HOST_QEMU_SYSTEM_MODE

made more sense here. Indeed, if the user wants the "user mode", it's a
bit weird to force the user to also have the "system mode". I believe a
"depends on" in this case is more appropriate.

Applied with this change. Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2021-07-16 21:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-10 15:54 [Buildroot] [PATCH 1/1] package/qemu: virtfs needs system Fabrice Fontaine
2021-07-16 21:19 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210716231934.18eb81ee@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.