From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD267C636CA for ; Sat, 17 Jul 2021 10:19:18 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 67E306124B for ; Sat, 17 Jul 2021 10:19:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67E306124B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58178 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m4hPh-00023f-JC for qemu-devel@archiver.kernel.org; Sat, 17 Jul 2021 06:19:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35708) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4hH4-0007lm-IC for qemu-devel@nongnu.org; Sat, 17 Jul 2021 06:10:22 -0400 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:39665) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m4hH0-0007TR-AR for qemu-devel@nongnu.org; Sat, 17 Jul 2021 06:10:22 -0400 Received: by mail-wr1-x433.google.com with SMTP id f17so14984839wrt.6 for ; Sat, 17 Jul 2021 03:10:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qWN2HIRs01eKm6dhCHQnthOBil+q+4JpNVw/kRffS9E=; b=D8Rd1wtV9jDH3ODltaV8pm7t/cjt6cgrOEn35a1lSGPUy1jhVKtZPcSVfRR9z3F3Z8 ytSOPOf5y3Qq9NkRry4sgvzpxNhwNllRClWVx5Mxg0A+JupujooLNWiaIlZp5B35ueJa lc/z6p29oCjYlBHOM6QNYomdRNU6Hp6olb+cz0nhX4GQbCGjcfBzGpRGjzLJKyoXZilF l/5Foc+c1+MYecQEmQ/HeVLpMJYMZ+Qw+FubSDuQ+qm8rhrQvlnXq3mk2mpqtHkNpJ58 +0yRJ5ksd3vVds4sWr10XtbxkhtHiQnjWH6iC1DElmqaxBNU1lLmZDrGxjMNquqMOuWQ NSBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qWN2HIRs01eKm6dhCHQnthOBil+q+4JpNVw/kRffS9E=; b=Q0KsNeUbtSw6ABIJVgoX33j+d8qlwwt43wfXeXZ8SgM9Qo/Ef8ltB9qheojFVlrXkM ib4vwZf/DXArVm2wXigz/7zfbRYrwcpWyJEsot+sBtxbHCwQiPzcji3qDLsl/8twtXC8 X9LyiJ8TjnmLoj2X82zOqkkz9xNZS3x/3bD+5c+GxEMkuHJNm6Ff3v+Q5n+qMQkEUIaG MLfYFMjhiU2s2topU7bQWUEsVw2gqvTSSHaYgkcW2z/I8BTLUO1d6H3mHZ5tk9dDmwoS U8qhXN+5nDD0Vxx4exL+TpHNJiaQ1MtYNFhKvodM1hxWGEZiaAf4lgFZa9SMJdKddbgi lpyg== X-Gm-Message-State: AOAM53051Lwil8Cgfcn7XNtCVKW8T0Q4t205oo/evIemxwJqna+5pGCG i29+ewZeh/EAvr2mntsbmsoPV2rv01A= X-Google-Smtp-Source: ABdhPJwyeCsSFZl3e5c//9b0Lm2GtOIeFLhkpZ08jv8JlhcPAfuS8esqXGsK62z2GtFxUR6ukaib3Q== X-Received: by 2002:a5d:4d01:: with SMTP id z1mr17628099wrt.34.1626516613711; Sat, 17 Jul 2021 03:10:13 -0700 (PDT) Received: from localhost.localdomain ([41.34.125.69]) by smtp.gmail.com with ESMTPSA id 11sm13846923wmo.10.2021.07.17.03.10.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Jul 2021 03:10:13 -0700 (PDT) From: Mahmoud Mandour To: qemu-devel@nongnu.org Subject: [PATCH 04/13] plugins/hotblocks: Added correct boolean argument parsing Date: Sat, 17 Jul 2021 12:09:11 +0200 Message-Id: <20210717100920.240793-5-ma.mandourr@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210717100920.240793-1-ma.mandourr@gmail.com> References: <20210717100920.240793-1-ma.mandourr@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=ma.mandourr@gmail.com; helo=mail-wr1-x433.google.com X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mahmoud Mandour , cota@braap.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Mahmoud Mandour --- contrib/plugins/hotblocks.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c index 4b08340143..062200a7a4 100644 --- a/contrib/plugins/hotblocks.c +++ b/contrib/plugins/hotblocks.c @@ -133,8 +133,18 @@ QEMU_PLUGIN_EXPORT int qemu_plugin_install(qemu_plugin_id_t id, const qemu_info_t *info, int argc, char **argv) { - if (argc && strcmp(argv[0], "inline") == 0) { - do_inline = true; + for (int i = 0; i < argc; i++) { + char *opt = argv[i]; + g_autofree char **tokens = g_strsplit(opt, "=", 2); + if (g_strcmp0(tokens[0], "inline") == 0) { + if (!qemu_plugin_bool_parse(tokens[0], tokens[1], &do_inline)) { + fprintf(stderr, "boolean argument parsing failed: %s\n", opt); + return -1; + } + } else { + fprintf(stderr, "option parsing failed: %s\n", opt); + return -1; + } } plugin_init(); -- 2.25.1