From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DD99C636CB for ; Sat, 17 Jul 2021 15:36:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F0E361156 for ; Sat, 17 Jul 2021 15:36:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236676AbhGQPjk (ORCPT ); Sat, 17 Jul 2021 11:39:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:54900 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236355AbhGQPjh (ORCPT ); Sat, 17 Jul 2021 11:39:37 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 165BB6109E; Sat, 17 Jul 2021 15:36:37 +0000 (UTC) Date: Sat, 17 Jul 2021 16:39:00 +0100 From: Jonathan Cameron To: Andrea Merello Cc: lars@metafoo.de, robh+dt@kernel.org, matt.ranostay@konsulko.com, andriy.shevchenko@linux.intel.com, vlad.dogaru@intel.com, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Andrea Merello Subject: Re: [PATCH 3/4] dt-bindings: iio: imu: add bosch BNO055 serdev driver bindings Message-ID: <20210717163900.657ec48b@jic23-huawei> In-Reply-To: <20210715141742.15072-4-andrea.merello@gmail.com> References: <20210715141742.15072-1-andrea.merello@gmail.com> <20210715141742.15072-4-andrea.merello@gmail.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Jul 2021 16:17:41 +0200 Andrea Merello wrote: > Introduce new documentation file for the BNO055 serdev driver that will dt bindings are for the device not the driver (so don't mention driver in the binding or the patch description). > be included in next patches of this same series > > Signed-off-by: Andrea Merello > Cc: Andrea Merello > Cc: Rob Herring > Cc: Matt Ranostay > Cc: Andy Shevchenko > Cc: Vlad Dogaru > Cc: linux-kernel@vger.kernel.org > Cc: linux-iio@vger.kernel.org > --- > .../bindings/iio/imu/bosch,bno055-serial.yaml | 40 +++++++++++++++++++ > 1 file changed, 40 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/imu/bosch,bno055-serial.yaml > > diff --git a/Documentation/devicetree/bindings/iio/imu/bosch,bno055-serial.yaml b/Documentation/devicetree/bindings/iio/imu/bosch,bno055-serial.yaml > new file mode 100644 > index 000000000000..743c784ebc94 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/imu/bosch,bno055-serial.yaml Better to have just one doc covering this interface and i2c if that gets added. > @@ -0,0 +1,40 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/imu/bosch,bno055-serial.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Serial-attached Bosch BNO055 > + > +maintainers: > + - Jonathan Cameron That's just mean! I have plenty of these to look after already! Joking aside, you'd be a better maintainer for this than me as more likely to pay attention. > + > +description: | > + Inertial Measurement Unit with Accelerometer, Gyroscope, Magnetometer and > + internal MCU for sensor fusion > + https://www.bosch-sensortec.com/products/smart-sensors/bno055/ > + > +properties: > + compatible: > + enum: > + - bosch,bno055-serial > + > + reset-gpios: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > +required: > + - compatible > + > +additionalProperties: false > + > +examples: > + - | > + #include > + bno055 { name needs to be the one for the device type found in the device tree spec or if it's not there, something in same 'spirit'. Probably imu here > + compatible = "bosch,bno055-serial"; Don't need the -serial. It will bind based on the bus this is under. Speaking of which, it's normal to provide that bus info as part of the example. See for example chemical/sensiron,scd30.yaml > + reset-gpios = <&gpio0 54 GPIO_ACTIVE_LOW>; > + clocks = <&imu_clk>; > + };