* [ti:ti-rt-linux-5.10.y 6720/6782] drivers/media/mc/mc-entity.c:443 __media_pipeline_start() error: uninitialized symbol 'ret'.
@ 2021-07-19 6:50 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2021-07-18 9:50 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 17537 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Sakari Ailus <sakari.ailus@linux.intel.com>
CC: Vignesh Raghavendra <vigneshr@ti.com>
CC: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
CC: Jacopo Mondi <jacopo+renesas@jmondi.org>
CC: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
CC: Pratyush Yadav <p.yadav@ti.com>
CC: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
tree: git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-rt-linux-5.10.y
head: bee192299392dc41c94f4603968b7a3c02f17a1d
commit: 80dac899053d08524a40f195905022bb08e6104c [6720/6782] media: entity: Move the pipeline from entity to pads
:::::: branch date: 2 days ago
:::::: commit date: 4 days ago
config: i386-randconfig-m021-20210718 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/media/mc/mc-entity.c:443 __media_pipeline_start() error: uninitialized symbol 'ret'.
vim +/ret +443 drivers/media/mc/mc-entity.c
d295c6a460cd2a drivers/media/media-entity.c Niklas Söderlund 2017-06-15 401
e02188c90f6ef6 drivers/media/media-entity.c Laurent Pinchart 2010-08-25 402 /* -----------------------------------------------------------------------------
e02188c90f6ef6 drivers/media/media-entity.c Laurent Pinchart 2010-08-25 403 * Pipeline management
e02188c90f6ef6 drivers/media/media-entity.c Laurent Pinchart 2010-08-25 404 */
e02188c90f6ef6 drivers/media/media-entity.c Laurent Pinchart 2010-08-25 405
20b852273642f4 drivers/media/media-entity.c Sakari Ailus 2016-11-21 406 __must_check int __media_pipeline_start(struct media_entity *entity,
e02188c90f6ef6 drivers/media/media-entity.c Laurent Pinchart 2010-08-25 407 struct media_pipeline *pipe)
e02188c90f6ef6 drivers/media/media-entity.c Laurent Pinchart 2010-08-25 408 {
d10c98949d1a1f drivers/media/media-entity.c Javier Martinez Canillas 2015-08-19 409 struct media_device *mdev = entity->graph_obj.mdev;
20b852273642f4 drivers/media/media-entity.c Sakari Ailus 2016-11-21 410 struct media_graph *graph = &pipe->graph;
cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 411 struct media_pad *pad = entity->pads;
cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 412 struct media_pad *pad_err = pad;
57208e5e25f263 drivers/media/media-entity.c Mauro Carvalho Chehab 2015-08-07 413 struct media_link *link;
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 414 int ret;
e02188c90f6ef6 drivers/media/media-entity.c Laurent Pinchart 2010-08-25 415
74a4133079f739 drivers/media/media-entity.c Sakari Ailus 2015-12-16 416 if (!pipe->streaming_count++) {
20b852273642f4 drivers/media/media-entity.c Sakari Ailus 2016-11-21 417 ret = media_graph_walk_init(&pipe->graph, mdev);
74a4133079f739 drivers/media/media-entity.c Sakari Ailus 2015-12-16 418 if (ret)
74a4133079f739 drivers/media/media-entity.c Sakari Ailus 2015-12-16 419 goto error_graph_walk_start;
106b9907c368e3 drivers/media/media-entity.c Sakari Ailus 2015-12-16 420 }
106b9907c368e3 drivers/media/media-entity.c Sakari Ailus 2015-12-16 421
cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 422 media_graph_walk_start(&pipe->graph, pad);
cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 423
cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 424 while ((pad = media_graph_walk_next(graph))) {
cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 425 struct media_entity *entity = pad->entity;
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 426 bool skip_validation = pad->pipe != NULL;
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 427 struct media_pad *iter;
e02188c90f6ef6 drivers/media/media-entity.c Laurent Pinchart 2010-08-25 428
ef69ee1bc2c10f drivers/media/media-entity.c Mauro Carvalho Chehab 2015-10-01 429 DECLARE_BITMAP(active, MEDIA_ENTITY_MAX_PADS);
ef69ee1bc2c10f drivers/media/media-entity.c Mauro Carvalho Chehab 2015-10-01 430 DECLARE_BITMAP(has_no_links, MEDIA_ENTITY_MAX_PADS);
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 431
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 432 media_entity_for_each_pad(entity, iter) {
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 433 if (iter->pipe && iter->pipe != pipe) {
3eb87773dee633 drivers/media/media-entity.c Shuah Khan 2019-02-22 434 pr_err("Pipe active for %s. Can't start for %s\n",
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 435 entity->name, iter->entity->name);
8aaf62b5b9bef7 drivers/media/media-entity.c Sakari Ailus 2015-11-29 436 ret = -EBUSY;
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 437 } else {
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 438 iter->pipe = pipe;
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 439 }
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 440 iter->stream_count++;
8aaf62b5b9bef7 drivers/media/media-entity.c Sakari Ailus 2015-11-29 441 }
8aaf62b5b9bef7 drivers/media/media-entity.c Sakari Ailus 2015-11-29 442
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 @443 if (ret)
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 444 goto error;
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 445
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 446 /* Already part of the pipeline, skip validation. */
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 447 if (skip_validation)
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 448 continue;
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 449
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 450 if (!entity->ops || !entity->ops->link_validate)
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 451 continue;
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 452
de49c285a36049 drivers/media/media-entity.c Sakari Ailus 2013-10-13 453 bitmap_zero(active, entity->num_pads);
de49c285a36049 drivers/media/media-entity.c Sakari Ailus 2013-10-13 454 bitmap_fill(has_no_links, entity->num_pads);
de49c285a36049 drivers/media/media-entity.c Sakari Ailus 2013-10-13 455
57208e5e25f263 drivers/media/media-entity.c Mauro Carvalho Chehab 2015-08-07 456 list_for_each_entry(link, &entity->links, list) {
cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 457 struct media_pad *other_pad =
cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 458 link->sink->entity == entity ?
cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 459 link->sink : link->source;
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 460
de49c285a36049 drivers/media/media-entity.c Sakari Ailus 2013-10-13 461 /* Mark that a pad is connected by a link. */
cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 462 bitmap_clear(has_no_links, other_pad->index, 1);
de49c285a36049 drivers/media/media-entity.c Sakari Ailus 2013-10-13 463
de49c285a36049 drivers/media/media-entity.c Sakari Ailus 2013-10-13 464 /*
de49c285a36049 drivers/media/media-entity.c Sakari Ailus 2013-10-13 465 * Pads that either do not need to connect or
de49c285a36049 drivers/media/media-entity.c Sakari Ailus 2013-10-13 466 * are connected through an enabled link are
de49c285a36049 drivers/media/media-entity.c Sakari Ailus 2013-10-13 467 * fine.
de49c285a36049 drivers/media/media-entity.c Sakari Ailus 2013-10-13 468 */
cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 469 if (!(other_pad->flags & MEDIA_PAD_FL_MUST_CONNECT) ||
de49c285a36049 drivers/media/media-entity.c Sakari Ailus 2013-10-13 470 link->flags & MEDIA_LNK_FL_ENABLED)
cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 471 bitmap_set(active, other_pad->index, 1);
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 472
de49c285a36049 drivers/media/media-entity.c Sakari Ailus 2013-10-13 473 /*
de49c285a36049 drivers/media/media-entity.c Sakari Ailus 2013-10-13 474 * Link validation will only take place for
de49c285a36049 drivers/media/media-entity.c Sakari Ailus 2013-10-13 475 * sink ends of the link that are enabled.
de49c285a36049 drivers/media/media-entity.c Sakari Ailus 2013-10-13 476 */
cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 477 if (link->sink != other_pad ||
de49c285a36049 drivers/media/media-entity.c Sakari Ailus 2013-10-13 478 !(link->flags & MEDIA_LNK_FL_ENABLED))
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 479 continue;
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 480
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 481 ret = entity->ops->link_validate(link);
fab9d30b7b4216 drivers/media/media-entity.c Sakari Ailus 2014-10-28 482 if (ret < 0 && ret != -ENOIOCTLCMD) {
d10c98949d1a1f drivers/media/media-entity.c Javier Martinez Canillas 2015-08-19 483 dev_dbg(entity->graph_obj.mdev->dev,
91b619adeb3753 drivers/media/media-entity.c Sakari Ailus 2016-12-08 484 "link validation failed for '%s':%u -> '%s':%u, error %d\n",
823ea2a639611f drivers/media/media-entity.c Sakari Ailus 2015-02-12 485 link->source->entity->name,
823ea2a639611f drivers/media/media-entity.c Sakari Ailus 2015-02-12 486 link->source->index,
823ea2a639611f drivers/media/media-entity.c Sakari Ailus 2015-02-12 487 entity->name, link->sink->index, ret);
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 488 goto error;
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 489 }
fab9d30b7b4216 drivers/media/media-entity.c Sakari Ailus 2014-10-28 490 }
de49c285a36049 drivers/media/media-entity.c Sakari Ailus 2013-10-13 491
de49c285a36049 drivers/media/media-entity.c Sakari Ailus 2013-10-13 492 /* Either no links or validated links are fine. */
de49c285a36049 drivers/media/media-entity.c Sakari Ailus 2013-10-13 493 bitmap_or(active, active, has_no_links, entity->num_pads);
de49c285a36049 drivers/media/media-entity.c Sakari Ailus 2013-10-13 494
de49c285a36049 drivers/media/media-entity.c Sakari Ailus 2013-10-13 495 if (!bitmap_full(active, entity->num_pads)) {
47dfdb3a888733 drivers/media/media-entity.c Helen Mae Koike Fornazier 2015-06-28 496 ret = -ENOLINK;
d10c98949d1a1f drivers/media/media-entity.c Javier Martinez Canillas 2015-08-19 497 dev_dbg(entity->graph_obj.mdev->dev,
91b619adeb3753 drivers/media/media-entity.c Sakari Ailus 2016-12-08 498 "'%s':%u must be connected by an enabled link\n",
fab9d30b7b4216 drivers/media/media-entity.c Sakari Ailus 2014-10-28 499 entity->name,
094f1ca516cd32 drivers/media/media-entity.c Sakari Ailus 2014-11-03 500 (unsigned)find_first_zero_bit(
094f1ca516cd32 drivers/media/media-entity.c Sakari Ailus 2014-11-03 501 active, entity->num_pads));
de49c285a36049 drivers/media/media-entity.c Sakari Ailus 2013-10-13 502 goto error;
de49c285a36049 drivers/media/media-entity.c Sakari Ailus 2013-10-13 503 }
e02188c90f6ef6 drivers/media/media-entity.c Laurent Pinchart 2010-08-25 504 }
e02188c90f6ef6 drivers/media/media-entity.c Laurent Pinchart 2010-08-25 505
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 506 return 0;
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 507
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 508 error:
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 509 /*
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 510 * Link validation on graph failed. We revert what we did and
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 511 * return the error.
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 512 */
cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 513 media_graph_walk_start(graph, pad_err);
cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 514
cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 515 while ((pad_err = media_graph_walk_next(graph))) {
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 516 struct media_entity *entity = pad_err->entity;
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 517 struct media_pad *iter;
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 518
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 519 media_entity_for_each_pad(entity, iter) {
12030f489ef87d drivers/media/media-entity.c Sakari Ailus 2016-07-20 520 /* Sanity check for negative stream_count */
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 521 if (!WARN_ON_ONCE(iter->stream_count <= 0)) {
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 522 --iter->stream_count;
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 523 if (iter->stream_count == 0)
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 524 iter->pipe = NULL;
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 525 }
3801bc7d1b8dd7 drivers/media/media-entity.c Shuah Khan 2016-01-30 526 }
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 527
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 528 /*
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 529 * We haven't increased stream_count further than this
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 530 * so we quit here.
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 531 */
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 532 if (pad_err->entity == pad->entity)
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 533 break;
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 534 }
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 535
74a4133079f739 drivers/media/media-entity.c Sakari Ailus 2015-12-16 536 error_graph_walk_start:
74a4133079f739 drivers/media/media-entity.c Sakari Ailus 2015-12-16 537 if (!--pipe->streaming_count)
20b852273642f4 drivers/media/media-entity.c Sakari Ailus 2016-11-21 538 media_graph_walk_cleanup(graph);
106b9907c368e3 drivers/media/media-entity.c Sakari Ailus 2015-12-16 539
fb49f20438f361 drivers/media/media-entity.c Shuah Khan 2016-02-11 540 return ret;
fb49f20438f361 drivers/media/media-entity.c Shuah Khan 2016-02-11 541 }
20b852273642f4 drivers/media/media-entity.c Sakari Ailus 2016-11-21 542 EXPORT_SYMBOL_GPL(__media_pipeline_start);
fb49f20438f361 drivers/media/media-entity.c Shuah Khan 2016-02-11 543
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 41494 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [ti:ti-rt-linux-5.10.y 6720/6782] drivers/media/mc/mc-entity.c:443 __media_pipeline_start() error: uninitialized symbol 'ret'.
@ 2021-07-19 6:50 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2021-07-19 6:50 UTC (permalink / raw)
To: kbuild, Sakari Ailus
Cc: lkp, kbuild-all, linux-kernel, Vignesh Raghavendra,
Niklas Söderlund, Jacopo Mondi, Tomi Valkeinen,
Pratyush Yadav, Laurent Pinchart
tree: git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-rt-linux-5.10.y
head: bee192299392dc41c94f4603968b7a3c02f17a1d
commit: 80dac899053d08524a40f195905022bb08e6104c [6720/6782] media: entity: Move the pipeline from entity to pads
config: i386-randconfig-m021-20210718 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/media/mc/mc-entity.c:443 __media_pipeline_start() error: uninitialized symbol 'ret'.
vim +/ret +443 drivers/media/mc/mc-entity.c
20b852273642f4 drivers/media/media-entity.c Sakari Ailus 2016-11-21 406 __must_check int __media_pipeline_start(struct media_entity *entity,
e02188c90f6ef6 drivers/media/media-entity.c Laurent Pinchart 2010-08-25 407 struct media_pipeline *pipe)
e02188c90f6ef6 drivers/media/media-entity.c Laurent Pinchart 2010-08-25 408 {
d10c98949d1a1f drivers/media/media-entity.c Javier Martinez Canillas 2015-08-19 409 struct media_device *mdev = entity->graph_obj.mdev;
20b852273642f4 drivers/media/media-entity.c Sakari Ailus 2016-11-21 410 struct media_graph *graph = &pipe->graph;
cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 411 struct media_pad *pad = entity->pads;
cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 412 struct media_pad *pad_err = pad;
57208e5e25f263 drivers/media/media-entity.c Mauro Carvalho Chehab 2015-08-07 413 struct media_link *link;
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 414 int ret;
e02188c90f6ef6 drivers/media/media-entity.c Laurent Pinchart 2010-08-25 415
74a4133079f739 drivers/media/media-entity.c Sakari Ailus 2015-12-16 416 if (!pipe->streaming_count++) {
20b852273642f4 drivers/media/media-entity.c Sakari Ailus 2016-11-21 417 ret = media_graph_walk_init(&pipe->graph, mdev);
74a4133079f739 drivers/media/media-entity.c Sakari Ailus 2015-12-16 418 if (ret)
74a4133079f739 drivers/media/media-entity.c Sakari Ailus 2015-12-16 419 goto error_graph_walk_start;
106b9907c368e3 drivers/media/media-entity.c Sakari Ailus 2015-12-16 420 }
Not initialized on else path
106b9907c368e3 drivers/media/media-entity.c Sakari Ailus 2015-12-16 421
cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 422 media_graph_walk_start(&pipe->graph, pad);
cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 423
cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 424 while ((pad = media_graph_walk_next(graph))) {
cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 425 struct media_entity *entity = pad->entity;
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 426 bool skip_validation = pad->pipe != NULL;
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 427 struct media_pad *iter;
e02188c90f6ef6 drivers/media/media-entity.c Laurent Pinchart 2010-08-25 428
ef69ee1bc2c10f drivers/media/media-entity.c Mauro Carvalho Chehab 2015-10-01 429 DECLARE_BITMAP(active, MEDIA_ENTITY_MAX_PADS);
ef69ee1bc2c10f drivers/media/media-entity.c Mauro Carvalho Chehab 2015-10-01 430 DECLARE_BITMAP(has_no_links, MEDIA_ENTITY_MAX_PADS);
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 431
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 432 media_entity_for_each_pad(entity, iter) {
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 433 if (iter->pipe && iter->pipe != pipe) {
3eb87773dee633 drivers/media/media-entity.c Shuah Khan 2019-02-22 434 pr_err("Pipe active for %s. Can't start for %s\n",
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 435 entity->name, iter->entity->name);
8aaf62b5b9bef7 drivers/media/media-entity.c Sakari Ailus 2015-11-29 436 ret = -EBUSY;
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 437 } else {
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 438 iter->pipe = pipe;
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 439 }
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 440 iter->stream_count++;
8aaf62b5b9bef7 drivers/media/media-entity.c Sakari Ailus 2015-11-29 441 }
8aaf62b5b9bef7 drivers/media/media-entity.c Sakari Ailus 2015-11-29 442
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 @443 if (ret)
Only initialized on failure
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 444 goto error;
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 445
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 446 /* Already part of the pipeline, skip validation. */
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 447 if (skip_validation)
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 448 continue;
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 449
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 450 if (!entity->ops || !entity->ops->link_validate)
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 451 continue;
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 452
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* [ti:ti-rt-linux-5.10.y 6720/6782] drivers/media/mc/mc-entity.c:443 __media_pipeline_start() error: uninitialized symbol 'ret'.
@ 2021-07-19 6:50 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2021-07-19 6:50 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 6233 bytes --]
tree: git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-rt-linux-5.10.y
head: bee192299392dc41c94f4603968b7a3c02f17a1d
commit: 80dac899053d08524a40f195905022bb08e6104c [6720/6782] media: entity: Move the pipeline from entity to pads
config: i386-randconfig-m021-20210718 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/media/mc/mc-entity.c:443 __media_pipeline_start() error: uninitialized symbol 'ret'.
vim +/ret +443 drivers/media/mc/mc-entity.c
20b852273642f4 drivers/media/media-entity.c Sakari Ailus 2016-11-21 406 __must_check int __media_pipeline_start(struct media_entity *entity,
e02188c90f6ef6 drivers/media/media-entity.c Laurent Pinchart 2010-08-25 407 struct media_pipeline *pipe)
e02188c90f6ef6 drivers/media/media-entity.c Laurent Pinchart 2010-08-25 408 {
d10c98949d1a1f drivers/media/media-entity.c Javier Martinez Canillas 2015-08-19 409 struct media_device *mdev = entity->graph_obj.mdev;
20b852273642f4 drivers/media/media-entity.c Sakari Ailus 2016-11-21 410 struct media_graph *graph = &pipe->graph;
cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 411 struct media_pad *pad = entity->pads;
cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 412 struct media_pad *pad_err = pad;
57208e5e25f263 drivers/media/media-entity.c Mauro Carvalho Chehab 2015-08-07 413 struct media_link *link;
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 414 int ret;
e02188c90f6ef6 drivers/media/media-entity.c Laurent Pinchart 2010-08-25 415
74a4133079f739 drivers/media/media-entity.c Sakari Ailus 2015-12-16 416 if (!pipe->streaming_count++) {
20b852273642f4 drivers/media/media-entity.c Sakari Ailus 2016-11-21 417 ret = media_graph_walk_init(&pipe->graph, mdev);
74a4133079f739 drivers/media/media-entity.c Sakari Ailus 2015-12-16 418 if (ret)
74a4133079f739 drivers/media/media-entity.c Sakari Ailus 2015-12-16 419 goto error_graph_walk_start;
106b9907c368e3 drivers/media/media-entity.c Sakari Ailus 2015-12-16 420 }
Not initialized on else path
106b9907c368e3 drivers/media/media-entity.c Sakari Ailus 2015-12-16 421
cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 422 media_graph_walk_start(&pipe->graph, pad);
cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 423
cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 424 while ((pad = media_graph_walk_next(graph))) {
cd448544d8c6d3 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 425 struct media_entity *entity = pad->entity;
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 426 bool skip_validation = pad->pipe != NULL;
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 427 struct media_pad *iter;
e02188c90f6ef6 drivers/media/media-entity.c Laurent Pinchart 2010-08-25 428
ef69ee1bc2c10f drivers/media/media-entity.c Mauro Carvalho Chehab 2015-10-01 429 DECLARE_BITMAP(active, MEDIA_ENTITY_MAX_PADS);
ef69ee1bc2c10f drivers/media/media-entity.c Mauro Carvalho Chehab 2015-10-01 430 DECLARE_BITMAP(has_no_links, MEDIA_ENTITY_MAX_PADS);
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 431
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 432 media_entity_for_each_pad(entity, iter) {
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 433 if (iter->pipe && iter->pipe != pipe) {
3eb87773dee633 drivers/media/media-entity.c Shuah Khan 2019-02-22 434 pr_err("Pipe active for %s. Can't start for %s\n",
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 435 entity->name, iter->entity->name);
8aaf62b5b9bef7 drivers/media/media-entity.c Sakari Ailus 2015-11-29 436 ret = -EBUSY;
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 437 } else {
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 438 iter->pipe = pipe;
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 439 }
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 440 iter->stream_count++;
8aaf62b5b9bef7 drivers/media/media-entity.c Sakari Ailus 2015-11-29 441 }
8aaf62b5b9bef7 drivers/media/media-entity.c Sakari Ailus 2015-11-29 442
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 @443 if (ret)
Only initialized on failure
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 444 goto error;
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 445
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 446 /* Already part of the pipeline, skip validation. */
80dac899053d08 drivers/media/mc/mc-entity.c Sakari Ailus 2021-07-14 447 if (skip_validation)
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 448 continue;
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 449
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 450 if (!entity->ops || !entity->ops->link_validate)
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 451 continue;
af88be3887c1a0 drivers/media/media-entity.c Sakari Ailus 2012-01-11 452
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-19 6:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-18 9:50 [ti:ti-rt-linux-5.10.y 6720/6782] drivers/media/mc/mc-entity.c:443 __media_pipeline_start() error: uninitialized symbol 'ret' kernel test robot
2021-07-19 6:50 ` Dan Carpenter
2021-07-19 6:50 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.