From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1728BC636CA for ; Mon, 19 Jul 2021 01:01:58 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5798A610A2 for ; Mon, 19 Jul 2021 01:01:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5798A610A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3A23B80394; Mon, 19 Jul 2021 03:01:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="h0C1qdMB"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E15AC805E7; Mon, 19 Jul 2021 03:01:53 +0200 (CEST) Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A9A068033E for ; Mon, 19 Jul 2021 03:01:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x830.google.com with SMTP id g8so11919845qtj.1 for ; Sun, 18 Jul 2021 18:01:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=eWxeIDD9EThPM6M1VL2R6vi3BOEbyf3OhMyhV7rnNpw=; b=h0C1qdMBC+OHvd1qgBh09rkMBjA3jufZRpmDt1ERvl+xlPlJuW2D7+4ndOR0uy3MZ5 hxVtMRP1UiBjbH+TSsWjszM5YZUXgxs+2Y3l48lCAg19yUcO6ddKsB4rGbf6woPww99I BvpXsrJWauD31uibISLsBRZyylV1UpX7F7ZfQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=eWxeIDD9EThPM6M1VL2R6vi3BOEbyf3OhMyhV7rnNpw=; b=aLws8dPOnU8r2g9QDQUOfMC9RfGF++rG95YyvwWNgbqU22uEfl6lbImkqjLMMQZVmI zHz8xACdjF2Wrvm94njrT0NfOMIFtC1/1WI4E8NKXeKGv6MaCqAnF0kfNqCxAi40/OZ2 vDmIW73/GqwSc13COESegpCNQe3PVm5j9Zn+4DNjD0Oc+LRaLXrijpo1z5IcQpNrymPj b4RxATYcVCjFcPk7xLWJ++RomOD2s7srl7mcCNBmJMO3Ca01ctHXIIjJ8uEvzm3w7u6M LxV5WDbjmLaTG6rr1C4tzNIJx2LObQmdUaAhPhCM1hYsFW7VZHeeVsOMuJmX1zQeG+5T cE4Q== X-Gm-Message-State: AOAM530N5kq7ppQAf6qs3hnYePA5ZCHXpXDfjqtZ0HNq98DLu4/JjJDI ZQ/VLHN7j7NpYrNrxUfbTU9BpA== X-Google-Smtp-Source: ABdhPJwPF/18MtUnw3IXC0LjrLA5VSVDdkJrHrZWKwQe2I1z0JNDL0Wl9toPIrVz7XmBb+VYcqZRxw== X-Received: by 2002:ac8:68c:: with SMTP id f12mr19928381qth.334.1626656509156; Sun, 18 Jul 2021 18:01:49 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-dda3-b9be-7e18-1472.res6.spectrum.com. [2603:6081:7b01:cbda:dda3:b9be:7e18:1472]) by smtp.gmail.com with ESMTPSA id g4sm7372463qko.89.2021.07.18.18.01.46 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 18 Jul 2021 18:01:47 -0700 (PDT) Date: Sun, 18 Jul 2021 21:01:44 -0400 From: Tom Rini To: Heinrich Schuchardt Cc: Simon Glass , U-Boot Mailing List , Alexander Graf , Ilias Apalodimas Subject: Re: [PATCH v2 4/5] efi: Use 16-bit unicode strings Message-ID: <20210719010144.GF9379@bill-the-cat> References: <20210718201426.759240-1-sjg@chromium.org> <20210718201426.759240-5-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qicme7IxPpkH/pPU" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --qicme7IxPpkH/pPU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 19, 2021 at 02:41:46AM +0200, Heinrich Schuchardt wrote: > On 7/18/21 10:14 PM, Simon Glass wrote: > > At present we use wide characters for unicode but this is not necessary. > > Change the code to use the 'u' literal instead. This helps to fix build > > warnings for sandbox on rpi. > >=20 > > Signed-off-by: Simon Glass > > Suggested-by: Heinrich Schuchardt >=20 > According to https://en.cppreference.com/w/c/language/string_literal u"" > literals are supported since C11. In our Makefile we have CSTD_FLAG :=3D > -std=3Dgnu11. >=20 > Once we have changed all u"" to L"" we can remove -fshort-wchar from our > Makefiles. [snip] > > diff --git a/include/efi_loader.h b/include/efi_loader.h > > index b81180cfda8..cad7961942b 100644 > > --- a/include/efi_loader.h > > +++ b/include/efi_loader.h > > @@ -924,7 +924,7 @@ efi_status_t efi_capsule_authenticate(const void *c= apsule, > > efi_uintn_t capsule_size, > > void **image, efi_uintn_t *image_size); > >=20 > > -#define EFI_CAPSULE_DIR L"\\EFI\\UpdateCapsule\\" > > +#define EFI_CAPSULE_DIR u"\\EFI\\UpdateCapsule\\" This brings us more, not less, instances of u"" rather than L"". Should we perhaps make a coccinelle "spatch" to update everything globally and drop -fshort-wchar ? --=20 Tom --qicme7IxPpkH/pPU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmD0zvUACgkQFHw5/5Y0 tyxCqwv+KDA9HU3GJOK/5q1zogzDyDMD1bJT1dEwYbumZ7GxHMzT9C331wdgpT+A RWXInLgXErVROM/68EMjqipOPCKkqFHMKKnbmJLEvDEJw2XGeufRCAdRFtrkXMZK 6TM4PBysRQmLfd82ili7KJMwgI5a+gohaq/eODVdh/fXIlOpbzJ7NHX6SdCXyD3N n5H5ebgMgfzcEqyl4eIYvABd2MCl2B9mKMNLvLvGxhcFSUKCSmavuLlBHQWrhlvK OTzem68MYVhU1b+dbG1M9omfkBfK4K9AO9WnzMoaARtK6XN5vf2tDuoOm8MPqxxx 8H/DTdc+MfGZq6zxidzUU4R45KBMFuB140NZPTYmGGb7ma5v3PmjAZYhHYBPPVH6 8j+WgDbSswR8IFZ11b6vPFPDGDOpLAC/kRn/Q1Ng1kZ2iKQ09L4zDlbuLID/Av9U cjZQY3FrSnUU14G5fxHUpl8e4ycWXYcVDPkk+dfvI0j05/cE+Br2COjOsbyhEe7L Gq+kDbfP =5B7S -----END PGP SIGNATURE----- --qicme7IxPpkH/pPU--