linux-next: Fixes tag needs some work in the crypto tree

linux-next: Fixes tag needs some work in the crypto tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

Hi all,

In commit

  5261cdf457ce ("crypto: drbg - select SHA512")

Fixes tag

  Fixes: 9b7b94683a9b "crypto: DRBG - switch to HMAC SHA512 DRBG as default

has these problem(s):

  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the crypto tree

[Stephan Mueller]

Am Montag, dem 19.07.2021 um 08:13 +1000 schrieb Stephen Rothwell:
> Hi all,

Hi Stephen, Herbert
> 
> In commit
> 
>   5261cdf457ce ("crypto: drbg - select SHA512")
> 
> Fixes tag
> 
>   Fixes: 9b7b94683a9b "crypto: DRBG - switch to HMAC SHA512 DRBG as default
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than one line.
> 

Thank you for the report.

Herbert, how do we go about this fix? I can surely prepare another patch. But
considering that the old patch is already in the git tree, are you considering
to revert it?

Thanks
Stephan

Re: linux-next: Fixes tag needs some work in the crypto tree

[Herbert Xu]

On Mon, Jul 19, 2021 at 07:43:29AM +0200, Stephan Mueller wrote:
>
> Herbert, how do we go about this fix? I can surely prepare another patch. But
> considering that the old patch is already in the git tree, are you considering
> to revert it?

I think we should keep this in mind for future submissions.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

linux-next: Fixes tag needs some work in the crypto tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 317 bytes --]

Hi all,

In commit

  29b49013176b ("ipsec: Select CRYPTO_AEAD")

Fixes tag

  Fixes: 1383e2ab102c ("ipsec: Stop using crypto_has_alg")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: a1383e2ab102 ("ipsec: Stop using crypto_has_alg")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the crypto tree

[Weili Qian]

Sorry, my fault. I'll double check this in future submissions.
The correct tag is
Fixes: e3ac4d20e936 ("crypto: hisilicon/qm - enable PF and VFs communication")

@Herbert, Is there any way to modify it?

Regards,
Weili

On 2023/7/24 6:37, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   5cd4ed98cfb7 ("crypto: hisilicon/qm - flush all work before driver removed")
> 
> Fixes tag
> 
>   Fixes: ("crypto: hisilicon/qm - enable PF and VFs communication")
> 
> has these problem(s):
> 
>   - No SHA1 recognised
> 
> Maybe you meant
> 
> Fixes: e3ac4d20e936 ("crypto: hisilicon/qm - enable PF and VFs communication")
> 

linux-next: Fixes tag needs some work in the crypto tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]

Hi all,

In commit

  5cd4ed98cfb7 ("crypto: hisilicon/qm - flush all work before driver removed")

Fixes tag

  Fixes: ("crypto: hisilicon/qm - enable PF and VFs communication")

has these problem(s):

  - No SHA1 recognised

Maybe you meant

Fixes: e3ac4d20e936 ("crypto: hisilicon/qm - enable PF and VFs communication")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the crypto tree

[Herbert Xu]

On Mon, Sep 19, 2022 at 09:38:44AM +0000, Cabiddu, Giovanni wrote:
> My bad. Apologies.
> 
> @Herbert, can this be replaced in your history? The correct tag is
>     Fixes: d370cec32194 ("crypto: qat - Intel(R) QAT crypto interface")

Hi Giovanni:

Please take this into consideration for future submissions.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

RE: linux-next: Fixes tag needs some work in the crypto tree

[Cabiddu, Giovanni]

My bad. Apologies.

@Herbert, can this be replaced in your history? The correct tag is
    Fixes: d370cec32194 ("crypto: qat - Intel(R) QAT crypto interface")

Thanks,

-- 
Giovanni

-----Original Message-----
From: Stephen Rothwell <sfr@canb.auug.org.au> 
Sent: Sunday, September 18, 2022 11:13 PM
To: Herbert Xu <herbert@gondor.apana.org.au>; Linux Crypto List <linux-crypto@vger.kernel.org>
Cc: Muszynski, Damian <damian.muszynski@intel.com>; Cabiddu, Giovanni <giovanni.cabiddu@intel.com>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: linux-next: Fixes tag needs some work in the crypto tree

Hi all,

In commit

  cf5bb835b7c8 ("crypto: qat - fix DMA transfer direction")

Fixes tag

  Fixes: d370cec ("crypto: qat - Intel(R) QAT crypto interface")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

linux-next: Fixes tag needs some work in the crypto tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

Hi all,

In commit

  cf5bb835b7c8 ("crypto: qat - fix DMA transfer direction")

Fixes tag

  Fixes: d370cec ("crypto: qat - Intel(R) QAT crypto interface")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the crypto tree

[Giovanni Cabiddu]

Thanks Stephen.

On Tue, Apr 19, 2022 at 07:17:22AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   c690c7f6312c ("crypto: qat - rework the VF2PF interrupt handling logic")
> 
> Fixes tag
> 
>   Fixes: 993161d ("crypto: qat - fix handling of VF to PF interrupts")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     This can be fixed for the future by setting core.abbrev to 12 (or
>     more) or (for git v2.11 or later) just making sure it is not set
>     (or set to "auto").
Apologies, I missed this during the review of the patch.

@Herbert, should I resend the patch with the correct Fixes tag or can
you amend the commit in your tree.

This should be the correct tag:
    Fixes: 993161d36ab5 ("crypto: qat - fix handling of VF to PF interrupts")

Regards,

-- 
Giovanni

linux-next: Fixes tag needs some work in the crypto tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 458 bytes --]

Hi all,

In commit

  c690c7f6312c ("crypto: qat - rework the VF2PF interrupt handling logic")

Fixes tag

  Fixes: 993161d ("crypto: qat - fix handling of VF to PF interrupts")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the crypto tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

Hi all,

In commit

  36303413885e ("crypto: chelsio - Read rxchannel-id from firmware")

Fixes tag

  Fixes: 567be3a5d227 ("crypto: chelsio - Use multiple txq/rxq per tfm to process the requests)

has these problem(s):

  - Subject has leading but no trailing quotes

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the crypto tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

Hi all,

In commit

  7278fa25aa0e ("crypto: caam - do not reset pointer size from MCFGR register")

Fixes tag

  Fixes: a1cf573ee95 ("crypto: caam - select DMA address size at runtime")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the crypto tree

[Herbert Xu]

On Mon, Nov 18, 2019 at 07:12:23PM +1100, Stephen Rothwell wrote:
> 
> Unless Herbert wants to rebase the crypto tree (and I think this is not
> a good reason to do that), you should just consider this a learning
> experience. :-)

Right.  It just so happens that I screwed up one of the patches
applied prior to the one in question so I had to rebase the tree.
The problem should now be fixed.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: linux-next: Fixes tag needs some work in the crypto tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 665 bytes --]

Hi Pascal,

On Mon, 18 Nov 2019 07:58:42 +0000 Pascal Van Leeuwen <pvanleeuwen@verimatrix.com> wrote:
>
> My bad, I didn't know the Fixes tag should not be broken over
> lines (and that rather conflicted with the 75 characters per
> line rule here, which is why I did break it up).
> 
> I'm willing to fix that - except that I don't know how to create
> a patch that _only_ fixes the commit description of something 
> already pulled into the cryptodev tree?

Unless Herbert wants to rebase the crypto tree (and I think this is not
a good reason to do that), you should just consider this a learning
experience. :-)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: linux-next: Fixes tag needs some work in the crypto tree

[Pascal Van Leeuwen]

Stephen, Herbert,

My bad, I didn't know the Fixes tag should not be broken over
lines (and that rather conflicted with the 75 characters per
line rule here, which is why I did break it up).

I'm willing to fix that - except that I don't know how to create
a patch that _only_ fixes the commit description of something 
already pulled into the cryptodev tree?

Regards,
Pascal van Leeuwen
Silicon IP Architect, Multi-Protocol Engines @ Verimatrix
www.insidesecure.com

> -----Original Message-----
> From: linux-crypto-owner@vger.kernel.org <linux-crypto-owner@vger.kernel.org> On Behalf Of
> Stephen Rothwell
> Sent: Saturday, November 16, 2019 12:20 AM
> To: Herbert Xu <herbert@gondor.apana.org.au>; Linux Crypto List <linux-crypto@vger.kernel.org>
> Cc: Linux Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel Mailing List <linux-
> kernel@vger.kernel.org>; Pascal van Leeuwen <pascalvanl@gmail.com>
> Subject: linux-next: Fixes tag needs some work in the crypto tree
> 
> Hi all,
> 
> In commit
> 
>   8c2c43a5be3d ("crypto: inside-secure - Fixed authenc w/ (3)DES fails on Macchiatobin")
> 
> Fixes tag
> 
>   Fixes: 13a1bb93f7b1c9 ("crypto: inside-secure - Fixed warnings on
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than one line.
> 
> --
> Cheers,
> Stephen Rothwell

linux-next: Fixes tag needs some work in the crypto tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

Hi all,

In commit

  8c2c43a5be3d ("crypto: inside-secure - Fixed authenc w/ (3)DES fails on Macchiatobin")

Fixes tag

  Fixes: 13a1bb93f7b1c9 ("crypto: inside-secure - Fixed warnings on

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the crypto tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 415 bytes --]

Hi all,

In commit

  1b82feb6c5e1 ("crypto: qat - Silence smp_processor_id() warning")

Fixes tag

  Fixes: ed8ccaef52 ("crypto: qat - Add support for SRIOV")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the crypto tree

[Herbert Xu]

On Tue, Apr 23, 2019 at 07:30:36AM +1000, Stephen Rothwell wrote:
> 
> In commit
> 
>   f5a2aeb8b254 ("crypto: ccp - Do not free psp_master when PLATFORM_INIT fails")
> 
> Fixes tag
> 
>   Fixes: 200664d5237f ("crypto: ccp: Add SEV support")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'

Thanks for the heads up Stephen.

I have taken a look and it seems to be a rephrasing of the original
commit subject which seems to make sense.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

linux-next: Fixes tag needs some work in the crypto tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 343 bytes --]

Hi all,

In commit

  f5a2aeb8b254 ("crypto: ccp - Do not free psp_master when PLATFORM_INIT fails")

Fixes tag

  Fixes: 200664d5237f ("crypto: ccp: Add SEV support")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the crypto tree

[Herbert Xu]

On Tue, Apr 16, 2019 at 07:23:42AM +1000, Stephen Rothwell wrote:
> Hi Herbert,
> 
> In commit
> 
>   2e53582d158e ("crypto: mxc-scc - Remove broken driver")
> 
> Fixes tag
> 
>   Fixes: d293b640ebd ("crypto: mxc-scc - add basic driver for the...")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").

Thanks Stephen, it should be fixed now.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

linux-next: Fixes tag needs some work in the crypto tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

Hi Herbert,

In commit

  2e53582d158e ("crypto: mxc-scc - Remove broken driver")

Fixes tag

  Fixes: d293b640ebd ("crypto: mxc-scc - add basic driver for the...")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]