From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A483C12002 for ; Mon, 19 Jul 2021 11:09:09 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E770561029 for ; Mon, 19 Jul 2021 11:09:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E770561029 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nfc-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id E9431100EB323; Mon, 19 Jul 2021 04:09:06 -0700 (PDT) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=185.125.188.120; helo=smtp-relay-canonical-0.canonical.com; envelope-from=krzysztof.kozlowski@canonical.com; receiver= Received: from smtp-relay-canonical-0.canonical.com (smtp-relay-canonical-0.canonical.com [185.125.188.120]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EEE87100EB33C for ; Mon, 19 Jul 2021 04:09:05 -0700 (PDT) Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPS id 0AF09408B2 for ; Mon, 19 Jul 2021 11:09:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1626692945; bh=FnGOMkb6vm1N6nQJ/tXcyc0bIWiCO0YVJqND2woVkxw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=iEmfubGpNNlJG6o5HoXK/Luy/yn9bxfzZtzTVCCnDkqmcYXjr1WlIZp3Ffl7i4I2k ayGzkhWAem+ukQU0TGD1DYC3zXDr5J5Ies0IFDZthqtRo8By+mTBAj8GEGzv99reV7 L0l2j5HclBriyobhyOVYpjnewsfyNEzqHBoAd/RLyMV3Dl8uYj3UmFk4dumYEpm67o hGchTphKViHQykd/Ey2/tra26lpWQpUSDF0udKeCZ2qgk7ZDUpVnw7HGweOIJX+tMI CKvJ2O6fFY67qOXLMaZh95m5HCcGgQagQQ4skWrWqM6yYjzRJXWqeMcMQVvoktRrP5 86Gjt9sg1jL7Q== Received: by mail-lf1-f71.google.com with SMTP id n10-20020a196f4a0000b0290379403f4d35so3265649lfk.12 for ; Mon, 19 Jul 2021 04:09:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FnGOMkb6vm1N6nQJ/tXcyc0bIWiCO0YVJqND2woVkxw=; b=G6Jl1xl/JFnviCFWpXbenPcyXYLlvNJWF6lvbKrl7UfV7p0tpCSRSpzgX7c0MBKRcB grm3N4GNqpDSQs27g55eldnbmy8L37G6x93WphU+FAfsuhnTzEW1WNsQq+pMVdJWDiP3 n6u6/0yUcuf1slh9kmcGzGjpUg4x+bvwXtgB51wxnMCjU+ACWM4f9gXMDV2e60BxRbeC WUz0x55KYzg/6BB8uCWY6Jo1In8AulH97UyaBJ9t35altI0WmqDc6orkPDozeb7aK2DE GfFHOr7WPPxgsPrfbO4+XzAeLbq7GzPE7CSFzwT3e9CPSd/y1VrD+IGMsEeKSZscHPQ3 WLtA== X-Gm-Message-State: AOAM532qHYrbUy8+rv51QWAQ07SsKtDAq9VCdnpZc1Kyp6MNfy0mcIem kPC7Jf4u5OEVbKe4X7ZJhPcYGf7Zd0Db6SbdmhXnHPg5/KGpzfOvbNgODPv8x2Xlr94T5oF+fGf McMKT7wqv2QBWLUe4TLN3XwmKNbNGy4iu2Q== X-Received: by 2002:a05:651c:b2b:: with SMTP id b43mr7985670ljr.476.1626692944280; Mon, 19 Jul 2021 04:09:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzRd9FQr2Fsm8qDkrPI7pdY5F6zz53Q/6Ve/+8C517hsmKM4AKZcTQ/lZGj5RrrjonGfcW6zw== X-Received: by 2002:a05:651c:b2b:: with SMTP id b43mr7985664ljr.476.1626692944126; Mon, 19 Jul 2021 04:09:04 -0700 (PDT) Received: from localhost.localdomain (m193-217-114-158.cust.tele2.hr. [193.217.114.158]) by smtp.gmail.com with ESMTPSA id z25sm1264701lfh.283.2021.07.19.04.09.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jul 2021 04:09:03 -0700 (PDT) From: Krzysztof Kozlowski To: linux-nfc@lists.01.org Date: Mon, 19 Jul 2021 13:07:32 +0200 Message-Id: <20210719110819.27340-27-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210719110819.27340-1-krzysztof.kozlowski@canonical.com> References: <20210719110819.27340-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Message-ID-Hash: NP7J25B62CUTUWEAZR3EOJ4O5EEIWGCW X-Message-ID-Hash: NP7J25B62CUTUWEAZR3EOJ4O5EEIWGCW X-MailFrom: krzysztof.kozlowski@canonical.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Krzysztof Kozlowski X-Mailman-Version: 3.1.1 Precedence: list Subject: [linux-nfc] [neard][PATCH v2 26/73] nfctype2: use proper format for integers (-Wformat) List-Id: NFC on Linux Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 UHJvcGVybHkgcHJpbnQgc2lnbmVkIGFuZCB1bnNpZ25lZCBpbnRlZ2Vycy4gIFRoaXMgZml4ZXMg d2FybmluZ3MgbGlrZToNCg0KICAgIEluIGZpbGUgaW5jbHVkZWQgZnJvbSBwbHVnaW5zL25mY3R5 cGUyLmM6MzY6DQogICAgcGx1Z2lucy9uZmN0eXBlMi5jOiBJbiBmdW5jdGlvbiDigJhkYXRhX3Jl Y3bigJk6DQogICAgLi9pbmNsdWRlL25lYXIvbG9nLmg6NDU6MTQ6IGVycm9yOiBmb3JtYXQg4oCY JWTigJkgZXhwZWN0cyBhcmd1bWVudCBvZiB0eXBlIOKAmGludOKAmSwgYnV0IGFyZ3VtZW50IDQg aGFzIHR5cGUg4oCYdWludDMyX3TigJkge2FrYSDigJh1bnNpZ25lZCBpbnTigJl9IFstV2Vycm9y PWZvcm1hdD1dDQogICAgICAgNDUgfCAgIG5lYXJfZGVidWcoIiVzOiVzKCkgIiBmbXQsIFwNCiAg ICAgICAgICB8ICAgICAgICAgICAgICBefn5+fn5+fn5+DQogICAgcGx1Z2lucy9uZmN0eXBlMi5j OjE5NToyOiBub3RlOiBpbiBleHBhbnNpb24gb2YgbWFjcm8g4oCYREJH4oCZDQogICAgICAxOTUg fCAgREJHKCJhZGFwdGVyICVkIiwgYWRhcHRlcl9pZHgpOw0KICAgICAgICAgIHwgIF5+fg0KDQog ICAgcGx1Z2lucy9uZmN0eXBlMi5jOiBJbiBmdW5jdGlvbiDigJhuZmN0eXBlMl93cml0ZeKAmToN CiAgICBwbHVnaW5zL25mY3R5cGUyLmM6NDU4OjQzOiBlcnJvcjogZm9ybWF0IOKAmCV6ZOKAmSBl eHBlY3RzIGFyZ3VtZW50IG9mIHR5cGUg4oCYc2lnbmVkIHNpemVfdOKAmSwgYnV0IGFyZ3VtZW50 IDIgaGFzIHR5cGUg4oCYc2l6ZV904oCZIHtha2Eg4oCYbG9uZyB1bnNpZ25lZCBpbnTigJl9IFst V2Vycm9yPWZvcm1hdD1dDQogICAgICA0NTggfCAgICAgbmVhcl9lcnJvcigiTm90IGVub3VnaCBz cGFjZSBvbiB0YWcgJXpkICV6ZCIsDQogICAgICAgICAgfCAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgfn5eDQogICAgICAgICAgfCAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB8DQogICAgICAgICAgfCAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBsb25nIGludA0KICAgICAgICAgIHwgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICVsZA0KICAgICAgNDU5IHwgICAgICAgbmRlZi0+bGVu Z3RoLA0KICAgICAgICAgIHwgICAgICAgfn5+fn5+fn5+fn5+DQogICAgICAgICAgfCAgICAgICAg ICAgfA0KICAgICAgICAgIHwgICAgICAgICAgIHNpemVfdCB7YWthIGxvbmcgdW5zaWduZWQgaW50 fQ0KDQpTaWduZWQtb2ZmLWJ5OiBLcnp5c3p0b2YgS296bG93c2tpIDxrcnp5c3p0b2Yua296bG93 c2tpQGNhbm9uaWNhbC5jb20+DQotLS0NCiBwbHVnaW5zL25mY3R5cGUyLmMgfCAxMiArKysrKyst LS0tLS0NCiAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQ0K DQpkaWZmIC0tZ2l0IGEvcGx1Z2lucy9uZmN0eXBlMi5jIGIvcGx1Z2lucy9uZmN0eXBlMi5jDQpp bmRleCBkZWM5NjE1YjY5YWYuLjM2MThjYTE3NzM2MyAxMDA2NDQNCi0tLSBhL3BsdWdpbnMvbmZj dHlwZTIuYw0KKysrIGIvcGx1Z2lucy9uZmN0eXBlMi5jDQpAQCAtMTkyLDcgKzE5Miw3IEBAIHN0 YXRpYyBpbnQgZGF0YV9yZWN2KHVpbnQ4X3QgKnJlc3AsIGludCBsZW5ndGgsIHZvaWQgKmRhdGEp DQogCWNtZC5jbWQgPSBDTURfUkVBRDsNCiAJY21kLmJsb2NrID0gREFUQV9CTE9DS19TVEFSVCAr IHRhZy0+Y3VycmVudF9ibG9jazsNCiANCi0JREJHKCJhZGFwdGVyICVkIiwgYWRhcHRlcl9pZHgp Ow0KKwlEQkcoImFkYXB0ZXIgJXUiLCBhZGFwdGVyX2lkeCk7DQogDQogCXJldHVybiBuZWFyX2Fk YXB0ZXJfc2VuZChhZGFwdGVyX2lkeCwNCiAJCQkJKHVpbnQ4X3QgKikgJmNtZCwgQ01EX1JFQURf U0laRSwNCkBAIC0zNDEsNyArMzQxLDcgQEAgc3RhdGljIGludCBuZmN0eXBlMl9yZWFkKHVpbnQz Ml90IGFkYXB0ZXJfaWR4LA0KIAkJCWNiLCB0Z3Rfc3VidHlwZSk7DQogDQogCWRlZmF1bHQ6DQot CQlEQkcoIlVua25vd24gVGFnIFR5cGUgMiBzdWJ0eXBlICVkIiwgdGd0X3N1YnR5cGUpOw0KKwkJ REJHKCJVbmtub3duIFRhZyBUeXBlIDIgc3VidHlwZSAldSIsIHRndF9zdWJ0eXBlKTsNCiAJCXJl dHVybiAtMTsNCiAJfQ0KIH0NCkBAIC00NTUsNyArNDU1LDcgQEAgc3RhdGljIGludCBuZmN0eXBl Ml93cml0ZSh1aW50MzJfdCBhZGFwdGVyX2lkeCwgdWludDMyX3QgdGFyZ2V0X2lkeCwNCiAJCSAq Lw0KIAkJaWYgKG5lYXJfdGFnX2dldF9tZW1vcnlfbGF5b3V0KHRhZykgPT0gTkVBUl9UQUdfTUVN T1JZX1NUQVRJQykgew0KIAkJCWlmICgobmRlZi0+bGVuZ3RoICsgMykgPiBuZWFyX3RhZ19nZXRf ZGF0YV9sZW5ndGgodGFnKSkgew0KLQkJCQluZWFyX2Vycm9yKCJOb3QgZW5vdWdoIHNwYWNlIG9u IHRhZyAlemQgJXpkIiwNCisJCQkJbmVhcl9lcnJvcigiTm90IGVub3VnaCBzcGFjZSBvbiB0YWcg JXp1ICV6dSIsDQogCQkJCQkJbmRlZi0+bGVuZ3RoLA0KIAkJCQkJCW5lYXJfdGFnX2dldF9kYXRh X2xlbmd0aCh0YWcpKTsNCiAJCQkJZXJyID0gLUVOT1NQQzsNCkBAIC00NzEsNyArNDcxLDcgQEAg c3RhdGljIGludCBuZmN0eXBlMl93cml0ZSh1aW50MzJfdCBhZGFwdGVyX2lkeCwgdWludDMyX3Qg dGFyZ2V0X2lkeCwNCiAJCXJldHVybiBtaWZhcmVfd3JpdGUoYWRhcHRlcl9pZHgsIHRhcmdldF9p ZHgsIG5kZWYsDQogCQkJCWNiLCB0Z3Rfc3VidHlwZSk7DQogCWRlZmF1bHQ6DQotCQlEQkcoIlVu a25vd24gVEFHIFR5cGUgMiBzdWJ0eXBlICVkIiwgdGd0X3N1YnR5cGUpOw0KKwkJREJHKCJVbmtu b3duIFRBRyBUeXBlIDIgc3VidHlwZSAldSIsIHRndF9zdWJ0eXBlKTsNCiAJCWVyciA9IC1FSU5W QUw7DQogCQlnb3RvIG91dF9lcnI7DQogCX0NCkBAIC01MzMsNyArNTMzLDcgQEAgc3RhdGljIGlu dCBuZmN0eXBlMl9jaGVja19wcmVzZW5jZSh1aW50MzJfdCBhZGFwdGVyX2lkeCwgdWludDMyX3Qg dGFyZ2V0X2lkeCwNCiAJCQkJCQkJY2IsIHRndF9zdWJ0eXBlKTsNCiANCiAJZGVmYXVsdDoNCi0J CURCRygiVW5rbm93biBUQUcgVHlwZSAyIHN1YnR5cGUgJWQiLCB0Z3Rfc3VidHlwZSk7DQorCQlE QkcoIlVua25vd24gVEFHIFR5cGUgMiBzdWJ0eXBlICV1IiwgdGd0X3N1YnR5cGUpOw0KIA0KIAkJ cmV0dXJuIC0xOw0KIAl9DQpAQCAtNTg2LDcgKzU4Niw3IEBAIHN0YXRpYyBpbnQgbmZjdHlwZTJf Zm9ybWF0KHVpbnQzMl90IGFkYXB0ZXJfaWR4LCB1aW50MzJfdCB0YXJnZXRfaWR4LA0KIAl0Z3Rf c3VidHlwZSA9IG5lYXJfdGFnX2dldF9zdWJ0eXBlKGFkYXB0ZXJfaWR4LCB0YXJnZXRfaWR4KTsN CiANCiAJaWYgKHRndF9zdWJ0eXBlICE9IE5FQVJfVEFHX05GQ19UMl9NSUZBUkVfVUxUUkFMSUdI VCkgew0KLQkJREJHKCJVbmtub3duIFRhZyBUeXBlIDIgc3VidHlwZSAlZCIsIHRndF9zdWJ0eXBl KTsNCisJCURCRygiVW5rbm93biBUYWcgVHlwZSAyIHN1YnR5cGUgJXUiLCB0Z3Rfc3VidHlwZSk7 DQogCQlyZXR1cm4gLTE7DQogCX0NCiANCi0tIA0KMi4yNy4wDQpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1uZmMgbWFpbGluZyBsaXN0IC0tIGxp bnV4LW5mY0BsaXN0cy4wMS5vcmcKVG8gdW5zdWJzY3JpYmUgc2VuZCBhbiBlbWFpbCB0byBsaW51 eC1uZmMtbGVhdmVAbGlzdHMuMDEub3JnCiUod2ViX3BhZ2VfdXJsKXNsaXN0aW5mbyUoY2dpZXh0 KXMvJShfaW50ZXJuYWxfbmFtZSlz From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============0623749652080610945==" MIME-Version: 1.0 From: Krzysztof Kozlowski To: linux-nfc@lists.01.org Subject: [neard][PATCH v2 26/73] nfctype2: use proper format for integers (-Wformat) Date: Mon, 19 Jul 2021 13:07:32 +0200 Message-ID: <20210719110819.27340-27-krzysztof.kozlowski@canonical.com> In-Reply-To: <20210719110819.27340-1-krzysztof.kozlowski@canonical.com> List-Id: --===============0623749652080610945== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Properly print signed and unsigned integers. This fixes warnings like: In file included from plugins/nfctype2.c:36: plugins/nfctype2.c: In function =E2=80=98data_recv=E2=80=99: ./include/near/log.h:45:14: error: format =E2=80=98%d=E2=80=99 expects = argument of type =E2=80=98int=E2=80=99, but argument 4 has type =E2=80=98ui= nt32_t=E2=80=99 {aka =E2=80=98unsigned int=E2=80=99} [-Werror=3Dformat=3D] 45 | near_debug("%s:%s() " fmt, \ | ^~~~~~~~~~ plugins/nfctype2.c:195:2: note: in expansion of macro =E2=80=98DBG=E2= =80=99 195 | DBG("adapter %d", adapter_idx); | ^~~ plugins/nfctype2.c: In function =E2=80=98nfctype2_write=E2=80=99: plugins/nfctype2.c:458:43: error: format =E2=80=98%zd=E2=80=99 expects = argument of type =E2=80=98signed size_t=E2=80=99, but argument 2 has type = =E2=80=98size_t=E2=80=99 {aka =E2=80=98long unsigned int=E2=80=99} [-Werror= =3Dformat=3D] 458 | near_error("Not enough space on tag %zd %zd", | ~~^ | | | long int | %ld 459 | ndef->length, | ~~~~~~~~~~~~ | | | size_t {aka long unsigned int} Signed-off-by: Krzysztof Kozlowski --- plugins/nfctype2.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/plugins/nfctype2.c b/plugins/nfctype2.c index dec9615b69af..3618ca177363 100644 --- a/plugins/nfctype2.c +++ b/plugins/nfctype2.c @@ -192,7 +192,7 @@ static int data_recv(uint8_t *resp, int length, void *d= ata) cmd.cmd =3D CMD_READ; cmd.block =3D DATA_BLOCK_START + tag->current_block; = - DBG("adapter %d", adapter_idx); + DBG("adapter %u", adapter_idx); = return near_adapter_send(adapter_idx, (uint8_t *) &cmd, CMD_READ_SIZE, @@ -341,7 +341,7 @@ static int nfctype2_read(uint32_t adapter_idx, cb, tgt_subtype); = default: - DBG("Unknown Tag Type 2 subtype %d", tgt_subtype); + DBG("Unknown Tag Type 2 subtype %u", tgt_subtype); return -1; } } @@ -455,7 +455,7 @@ static int nfctype2_write(uint32_t adapter_idx, uint32_= t target_idx, */ if (near_tag_get_memory_layout(tag) =3D=3D NEAR_TAG_MEMORY_STATIC) { if ((ndef->length + 3) > near_tag_get_data_length(tag)) { - near_error("Not enough space on tag %zd %zd", + near_error("Not enough space on tag %zu %zu", ndef->length, near_tag_get_data_length(tag)); err =3D -ENOSPC; @@ -471,7 +471,7 @@ static int nfctype2_write(uint32_t adapter_idx, uint32_= t target_idx, return mifare_write(adapter_idx, target_idx, ndef, cb, tgt_subtype); default: - DBG("Unknown TAG Type 2 subtype %d", tgt_subtype); + DBG("Unknown TAG Type 2 subtype %u", tgt_subtype); err =3D -EINVAL; goto out_err; } @@ -533,7 +533,7 @@ static int nfctype2_check_presence(uint32_t adapter_idx= , uint32_t target_idx, cb, tgt_subtype); = default: - DBG("Unknown TAG Type 2 subtype %d", tgt_subtype); + DBG("Unknown TAG Type 2 subtype %u", tgt_subtype); = return -1; } @@ -586,7 +586,7 @@ static int nfctype2_format(uint32_t adapter_idx, uint32= _t target_idx, tgt_subtype =3D near_tag_get_subtype(adapter_idx, target_idx); = if (tgt_subtype !=3D NEAR_TAG_NFC_T2_MIFARE_ULTRALIGHT) { - DBG("Unknown Tag Type 2 subtype %d", tgt_subtype); + DBG("Unknown Tag Type 2 subtype %u", tgt_subtype); return -1; } = -- = 2.27.0 --===============0623749652080610945==--