CC: kbuild-all(a)lists.01.org In-Reply-To: <1626516381-40440-1-git-send-email-xiyuyang19@fudan.edu.cn> References: <1626516381-40440-1-git-send-email-xiyuyang19@fudan.edu.cn> TO: Xiyu Yang TO: Jeff Layton TO: Ilya Dryomov TO: ceph-devel(a)vger.kernel.org TO: linux-kernel(a)vger.kernel.org CC: yuanxzhang(a)fudan.edu.cn CC: Xiyu Yang CC: Xin Tan Hi Xiyu, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on ceph-client/for-linus] [also build test WARNING on v5.14-rc2 next-20210716] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Xiyu-Yang/ceph-Convert-from-atomic_t-to-refcount_t-on-ceph_snap_realm-nref/20210718-111108 base: https://github.com/ceph/ceph-client.git for-linus :::::: branch date: 24 hours ago :::::: commit date: 24 hours ago config: x86_64-rhel-8.3-kselftests (attached as .config) compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-341-g8af24329-dirty # https://github.com/0day-ci/linux/commit/af8e5c68ccb6a1e5aead78e10d6d0441c032ba66 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Xiyu-Yang/ceph-Convert-from-atomic_t-to-refcount_t-on-ceph_snap_realm-nref/20210718-111108 git checkout af8e5c68ccb6a1e5aead78e10d6d0441c032ba66 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/ceph/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot sparse warnings: (new ones prefixed by >>) fs/ceph/quota.c: note: in included file (through fs/ceph/super.h): include/linux/ceph/ceph_debug.h:5:9: sparse: sparse: preprocessor token pr_fmt redefined fs/ceph/quota.c: note: in included file (through include/linux/kernel.h, include/asm-generic/bug.h, arch/x86/include/asm/bug.h, ...): >> include/linux/printk.h:301:9: sparse: this was the original definition vim +301 include/linux/printk.h 01c313dded34a1 Arnd Bergmann 2017-11-13 286 90c165f0de3ada Ricardo Cañuelo 2020-04-03 287 /** 90c165f0de3ada Ricardo Cañuelo 2020-04-03 288 * pr_fmt - used by the pr_*() macros to generate the printk format string 90c165f0de3ada Ricardo Cañuelo 2020-04-03 289 * @fmt: format string passed from a pr_*() macro 90c165f0de3ada Ricardo Cañuelo 2020-04-03 290 * 90c165f0de3ada Ricardo Cañuelo 2020-04-03 291 * This macro can be used to generate a unified format string for pr_*() 90c165f0de3ada Ricardo Cañuelo 2020-04-03 292 * macros. A common use is to prefix all pr_*() messages in a file with a common 90c165f0de3ada Ricardo Cañuelo 2020-04-03 293 * string. For example, defining this at the top of a source file: 90c165f0de3ada Ricardo Cañuelo 2020-04-03 294 * 90c165f0de3ada Ricardo Cañuelo 2020-04-03 295 * #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt 90c165f0de3ada Ricardo Cañuelo 2020-04-03 296 * 90c165f0de3ada Ricardo Cañuelo 2020-04-03 297 * would prefix all pr_info, pr_emerg... messages in the file with the module 90c165f0de3ada Ricardo Cañuelo 2020-04-03 298 * name. 90c165f0de3ada Ricardo Cañuelo 2020-04-03 299 */ 968ab1838a5d48 Linus Torvalds 2010-11-15 300 #ifndef pr_fmt 968ab1838a5d48 Linus Torvalds 2010-11-15 @301 #define pr_fmt(fmt) fmt 968ab1838a5d48 Linus Torvalds 2010-11-15 302 #endif 968ab1838a5d48 Linus Torvalds 2010-11-15 303 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org