From: Jakub Kicinski <kuba@kernel.org>
To: Kurt Kanzenbach <kurt@linutronix.de>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
davem@davemloft.net, netdev@vger.kernel.org,
sasha.neftin@intel.com, vitaly.lifshits@intel.com,
vinicius.gomes@intel.com,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Dvora Fuxbrumer <dvorax.fuxbrumer@linux.intel.com>
Subject: Re: [PATCH net-next 5/5] igc: Export LEDs
Date: Mon, 19 Jul 2021 11:46:40 +0200 [thread overview]
Message-ID: <20210719114640.157a6f7d@cakuba> (raw)
In-Reply-To: <87sg0ahlof.fsf@kurt>
On Mon, 19 Jul 2021 08:17:36 +0200, Kurt Kanzenbach wrote:
> > If the brightness is being abused to represent the blink mode, this
> > patch is going to get my NACK. Unfortunately, i cannot find a
> > datasheet for this chip to know what the LED control register actually
> > does. So i'm waiting for a reply to my question.
> >
> > There is a broad agreement between the LED maintainers and the PHYLIB
> > maintainers how Ethernet LEDs should be described with the hardware
> > blinking the LED for different reasons. The LED trigger mechanisms
> > should be used, one trigger per mode, and the trigger is then
> > offloaded to the hardware.
>
> OK. I'll look into it. Can you point me to an example maybe?
>
> Unfortunately this patch seems to be merged already. I guess it should
> be reverted.
Yes, please send a revert patch saying in the commit message that Andrew
suggest a different interface etc.
next prev parent reply other threads:[~2021-07-19 9:46 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 21:24 [PATCH net-next 0/5][pull request] 1GbE Intel Wired LAN Driver Updates 2021-07-16 Tony Nguyen
2021-07-16 21:24 ` [PATCH net-next 1/5] igc: Add possibility to add flex filter Tony Nguyen
2021-07-16 21:24 ` [PATCH net-next 2/5] igc: Integrate flex filter into ethtool ops Tony Nguyen
2021-07-16 21:24 ` [PATCH net-next 3/5] igc: Allow for Flex Filters to be installed Tony Nguyen
2021-07-16 21:24 ` [PATCH net-next 4/5] igc: Make flex filter more flexible Tony Nguyen
2021-07-16 21:24 ` [PATCH net-next 5/5] igc: Export LEDs Tony Nguyen
2021-07-16 21:56 ` Andrew Lunn
2021-07-18 22:10 ` Heiner Kallweit
2021-07-18 22:33 ` Andrew Lunn
2021-07-19 6:17 ` Kurt Kanzenbach
2021-07-19 9:46 ` Jakub Kicinski [this message]
2021-07-19 6:06 ` Kurt Kanzenbach
2021-07-19 13:15 ` Andrew Lunn
2021-07-20 8:54 ` Kurt Kanzenbach
2021-07-21 19:18 ` Marek Behún
2021-07-18 22:19 ` Heiner Kallweit
2021-07-19 0:40 ` Andrew Lunn
2021-07-20 15:00 ` Heiner Kallweit
2021-07-20 15:42 ` Andrew Lunn
2021-07-20 20:29 ` Heiner Kallweit
2021-07-21 14:35 ` Andrew Lunn
2021-07-21 16:02 ` Heiner Kallweit
2021-07-21 18:23 ` Pavel Machek
2021-07-21 18:25 ` Pavel Machek
2021-07-21 18:45 ` Marek Behún
2021-07-21 19:50 ` Andrew Lunn
2021-07-21 20:07 ` Marek Behún
2021-07-21 20:54 ` Andrew Lunn
2021-07-21 21:31 ` Marek Behún
2021-07-21 22:45 ` Pavel Machek
2021-07-22 1:45 ` Andrew Lunn
2021-07-22 2:19 ` Marek Behún
2021-07-21 22:34 ` Pavel Machek
2021-07-22 3:52 ` Florian Fainelli
2021-07-26 17:42 ` Jacek Anaszewski
2021-07-26 18:44 ` Marek Behún
2021-07-26 20:59 ` Heiner Kallweit
2021-07-27 0:06 ` Marek Behún
2021-07-27 1:57 ` Andrew Lunn
2021-07-27 8:15 ` Michael Walle
2021-07-27 14:56 ` Marek Behún
2021-07-27 15:03 ` Michael Walle
2021-07-27 15:24 ` Andrew Lunn
2021-07-27 15:28 ` Marek Behún
2021-07-27 15:53 ` Michael Walle
2021-07-27 16:23 ` Andrew Lunn
2021-07-27 16:32 ` Marek Behún
2021-07-27 16:42 ` Andrew Lunn
2021-07-27 19:42 ` Michael Walle
2021-07-28 20:43 ` Heiner Kallweit
2021-07-29 6:39 ` Kurt Kanzenbach
2021-07-29 8:59 ` Marek Behún
2021-07-29 21:54 ` Heiner Kallweit
2021-08-10 17:29 ` Pavel Machek
2021-08-10 17:55 ` Marek Behún
2021-08-10 19:53 ` Pavel Machek
2021-08-10 20:53 ` Marek Behún
2021-08-17 19:02 ` Pavel Machek
2021-08-25 15:26 ` Marek Behún
2021-08-26 12:45 ` Pavel Machek
2021-08-10 20:46 ` Heiner Kallweit
2021-08-10 21:21 ` Andrew Lunn
2021-07-27 13:55 ` Marek Behún
2021-08-10 17:22 ` Documentation for naming LEDs was " Pavel Machek
2021-07-19 21:48 ` Jesse Brandeburg
2021-07-20 13:31 ` Kurt Kanzenbach
2021-07-17 0:30 ` [PATCH net-next 0/5][pull request] 1GbE Intel Wired LAN Driver Updates 2021-07-16 patchwork-bot+netdevbpf
2021-07-17 17:36 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210719114640.157a6f7d@cakuba \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=dvorax.fuxbrumer@linux.intel.com \
--cc=hkallweit1@gmail.com \
--cc=kurt@linutronix.de \
--cc=netdev@vger.kernel.org \
--cc=sasha.neftin@intel.com \
--cc=vinicius.gomes@intel.com \
--cc=vitaly.lifshits@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.