Re: [PATCH v5 2/2] memcg: infrastructure to flush memcg stats

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5013 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210716212137.1391164-2-shakeelb@google.com>
References: <20210716212137.1391164-2-shakeelb@google.com>
TO: Shakeel Butt <shakeelb@google.com>

Hi Shakeel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on cgroup/for-next]
[also build test WARNING on linus/master v5.14-rc2]
[cannot apply to hnaz-linux-mm/master next-20210719]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Shakeel-Butt/memcg-switch-lruvec-stats-to-rstat/20210718-103230
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-next
:::::: branch date: 33 hours ago
:::::: commit date: 33 hours ago
config: parisc-randconfig-s031-20210718 (attached as .config)
compiler: hppa-linux-gcc (GCC) 10.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-341-g8af24329-dirty
        # https://github.com/0day-ci/linux/commit/cda0d205259a7e7c1f8e296130ac091557134a66
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Shakeel-Butt/memcg-switch-lruvec-stats-to-rstat/20210718-103230
        git checkout cda0d205259a7e7c1f8e296130ac091557134a66
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=parisc SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
   mm/memcontrol.c:3904:21: sparse: sparse: incompatible types in comparison expression (different address spaces):
   mm/memcontrol.c:3904:21: sparse:    struct mem_cgroup_threshold_ary [noderef] __rcu *
   mm/memcontrol.c:3904:21: sparse:    struct mem_cgroup_threshold_ary *
   mm/memcontrol.c:3906:21: sparse: sparse: incompatible types in comparison expression (different address spaces):
   mm/memcontrol.c:3906:21: sparse:    struct mem_cgroup_threshold_ary [noderef] __rcu *
   mm/memcontrol.c:3906:21: sparse:    struct mem_cgroup_threshold_ary *
   mm/memcontrol.c:4062:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
   mm/memcontrol.c:4062:9: sparse:    struct mem_cgroup_threshold_ary [noderef] __rcu *
   mm/memcontrol.c:4062:9: sparse:    struct mem_cgroup_threshold_ary *
   mm/memcontrol.c:4156:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
   mm/memcontrol.c:4156:9: sparse:    struct mem_cgroup_threshold_ary [noderef] __rcu *
   mm/memcontrol.c:4156:9: sparse:    struct mem_cgroup_threshold_ary *
   mm/memcontrol.c:5787:23: sparse: sparse: incompatible types in comparison expression (different address spaces):
   mm/memcontrol.c:5787:23: sparse:    struct task_struct [noderef] __rcu *
   mm/memcontrol.c:5787:23: sparse:    struct task_struct *
   mm/memcontrol.c: note: in included file:
   include/linux/memcontrol.h:738:9: sparse: sparse: context imbalance in 'lock_page_lruvec' - wrong count at exit
   include/linux/memcontrol.h:738:9: sparse: sparse: context imbalance in 'lock_page_lruvec_irq' - wrong count at exit
   include/linux/memcontrol.h:738:9: sparse: sparse: context imbalance in 'lock_page_lruvec_irqsave' - wrong count at exit
   mm/memcontrol.c:1955:6: sparse: sparse: context imbalance in 'lock_page_memcg' - wrong count at exit
   mm/memcontrol.c: note: in included file (through include/linux/wait.h, include/linux/pid.h, include/linux/sched.h, include/linux/cgroup.h, ...):
   include/linux/spinlock.h:409:9: sparse: sparse: context imbalance in '__unlock_page_memcg' - unexpected unlock
>> mm/memcontrol.c:5168:6: sparse: sparse: context imbalance in 'mem_cgroup_flush_stats' - wrong count at exit

vim +/mem_cgroup_flush_stats +5168 mm/memcontrol.c

1ced953b17bfaf Tejun Heo    2014-07-08  5167  
cda0d205259a7e Shakeel Butt 2021-07-16 @5168  void mem_cgroup_flush_stats(void)
cda0d205259a7e Shakeel Butt 2021-07-16  5169  {
cda0d205259a7e Shakeel Butt 2021-07-16  5170  	if (!spin_trylock(&stats_flush_lock))
cda0d205259a7e Shakeel Butt 2021-07-16  5171  		return;
cda0d205259a7e Shakeel Butt 2021-07-16  5172  
cda0d205259a7e Shakeel Butt 2021-07-16  5173  	cgroup_rstat_flush_irqsafe(root_mem_cgroup->css.cgroup);
cda0d205259a7e Shakeel Butt 2021-07-16  5174  	spin_unlock(&stats_flush_lock);
cda0d205259a7e Shakeel Butt 2021-07-16  5175  }
cda0d205259a7e Shakeel Butt 2021-07-16  5176  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 19287 bytes --]