All of lore.kernel.org
 help / color / mirror / Atom feed
From: ed@tanous.net
To: openembedded-devel@lists.openembedded.org
Cc: Ed Tanous <ed@tanous.net>
Subject: [meta-networking][PATCH] nghttp2 Use the built-in options for removing pack tools
Date: Mon, 19 Jul 2021 20:56:47 -0700	[thread overview]
Message-ID: <20210720035647.893435-1-ed@tanous.net> (raw)

From: Ed Tanous <ed@tanous.net>

For distros that want to use the ENABLE_LIB_ONLY option, the rm call in
the do_install_append() will fail, because ENABLE_HPACK_TOOLS (set
implicitly as part of ENABLE_LIB_ONLY) removes those two binaries from
the build, so they then can't be removed again.  It appears that nghttp2
has added explicit options for this use case, so this commit sets
ENABLE_HPACK_TOOLS=OFF, which not only allows for the option to be
overridden in other meta layers, also allows a simplified use of
ENABLE_LIB_ONLY in meta layers that don't want to ship any of the
binaries.

Signed-off-by: Ed Tanous <ed@tanous.net>
---
 meta-networking/recipes-support/nghttp2/nghttp2_1.43.0.bb | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/meta-networking/recipes-support/nghttp2/nghttp2_1.43.0.bb b/meta-networking/recipes-support/nghttp2/nghttp2_1.43.0.bb
index 959cccf35..08b855262 100644
--- a/meta-networking/recipes-support/nghttp2/nghttp2_1.43.0.bb
+++ b/meta-networking/recipes-support/nghttp2/nghttp2_1.43.0.bb
@@ -18,11 +18,7 @@ PACKAGECONFIG[manpages] = ""
 
 # examples are never installed, and don't need to be built in the
 # first place
-EXTRA_OECMAKE = "-DENABLE_EXAMPLES=OFF -DENABLE_APP=ON"
-
-do_install_append() {
-	rm ${D}${bindir}/deflatehd ${D}${bindir}/inflatehd
-}
+EXTRA_OECMAKE = "-DENABLE_EXAMPLES=OFF -DENABLE_APP=ON -DENABLE_HPACK_TOOLS=OFF"
 
 PACKAGES =+ "lib${PN} ${PN}-client ${PN}-proxy ${PN}-server"
 
-- 
2.32.0.402.g57bb445576-goog


             reply	other threads:[~2021-07-20  3:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-20  3:56 ed [this message]
2021-07-20 16:55 ` [oe] [meta-networking][PATCH] nghttp2 Use the built-in options for removing pack tools Khem Raj
2021-07-20 16:57   ` ed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210720035647.893435-1-ed@tanous.net \
    --to=ed@tanous.net \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.