From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56C70C07E9B for ; Tue, 20 Jul 2021 11:07:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F8816113C for ; Tue, 20 Jul 2021 11:07:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237822AbhGTK00 (ORCPT ); Tue, 20 Jul 2021 06:26:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:40114 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237177AbhGTKZX (ORCPT ); Tue, 20 Jul 2021 06:25:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8596C61107; Tue, 20 Jul 2021 11:05:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626779161; bh=+qOpfIZ2KxWKgu9KpXTV7Bv8qCzGPQfDmMztpoZHyv0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SEqqevoxN4NlJXodCzUzIjOChh5kcF15Gp82uUtrHgrXKWWK0tY41MNSNW+rufBBE C3WYxcVyavA9BM6P01ftdsn0kl92lAUddMYDvrvgfERZ55zcccA5h1IGFaTV9kTGxD qZ0Wa5YSpnyG4ZbPf+kHyNk1qyfKcJcFe2Kt8x6m5jLUq6LMTiUdUYCqoNghuolrfR svT+DRKJzUTF7x6oCJCPLDtJuG/gdQzJatGJ5uESHopGjgRexa45mCXB6IKxW2+fnA vdEJoUAJQ9zP2jWzK8gWqjbSga9iAFKWiXfHXRdWhaiL+UQgrt+eACDR6SQ+0Suwwb 5AbtFGUblPwtQ== Date: Tue, 20 Jul 2021 13:05:54 +0200 From: Jakub Kicinski To: Jia He Cc: Ariel Elior , GR-everest-linux-l2@marvell.com, "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, nd@arm.com, Prabhakar Kushwaha Subject: Re: [PATCH] Revert "qed: fix possible unpaired spin_{un}lock_bh in _qed_mcp_cmd_and_union()" Message-ID: <20210720130554.5c85b3e6@cakuba> In-Reply-To: <20210720092739.3539-1-justin.he@arm.com> References: <20210720092739.3539-1-justin.he@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Jul 2021 17:27:39 +0800, Jia He wrote: > This reverts commit 2d2f5ded858a4f4659fc63e01dd55605598a8f05. The hash looks wrong, the patch was applied to netdev/net AFAICT, and the ref there is: 6206b7981a36 ("qed: fix possible unpaired spin_{un}lock_bh in _qed_mcp_cmd_and_union()") Please tag the subject with "net": [PATCH net] Revert ... > That patch added additional spin_{un}lock_bh(), which was harmless > but pointless. The orginal code path has guaranteed the pair of > spin_{un}lock_bh(). > > We'd better revert it before we find the exact root cause of the > bug_on mentioned in that patch. > > Cc: David S. Miller > Cc: Prabhakar Kushwaha > Signed-off-by: Jia He Please also add a Fixes tag. Fixes: 6206b7981a36 ("qed: fix possible unpaired spin_{un}lock_bh in _qed_mcp_cmd_and_union()")