From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D841EC636C9 for ; Tue, 20 Jul 2021 15:06:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C5AC7610CC for ; Tue, 20 Jul 2021 15:06:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240216AbhGTOYj (ORCPT ); Tue, 20 Jul 2021 10:24:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239246AbhGTONm (ORCPT ); Tue, 20 Jul 2021 10:13:42 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEE61C0613F0 for ; Tue, 20 Jul 2021 07:49:42 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5r3u-0004tk-QQ; Tue, 20 Jul 2021 16:49:34 +0200 Received: from pengutronix.de (unknown [IPv6:2a03:f580:87bc:d400:3120:e42a:5796:3403]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 73D13653103; Tue, 20 Jul 2021 14:49:33 +0000 (UTC) Date: Tue, 20 Jul 2021 16:49:32 +0200 From: Marc Kleine-Budde To: Aswath Govindraju Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Nishanth Menon , Tero Kristo , Rob Herring , Lokesh Vutla Subject: Re: [PATCH 1/6] arm64: dts: ti: k3-am65-mcu: Add Support for MCAN Message-ID: <20210720144932.5rtvpkmjooma7zae@pengutronix.de> References: <20210720141642.24999-1-a-govindraju@ti.com> <20210720141642.24999-2-a-govindraju@ti.com> <20210720142047.mfqssyj4lwh3yi2k@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hpvarmjcpm2ogbfr" Content-Disposition: inline In-Reply-To: X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --hpvarmjcpm2ogbfr Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 20.07.2021 20:00:32, Aswath Govindraju wrote: > Hi Marc, >=20 > On 20/07/21 7:50 pm, Marc Kleine-Budde wrote: > > On 20.07.2021 19:46:37, Aswath Govindraju wrote: > >> From: Faiz Abbas > >> > >> Add Support for two MCAN controllers present on the am65x SOC. Both su= pport > >> classic CAN messages as well as CAN-FD. > >=20 > > Thanks for the patch! > >=20 > > Why don't you disable the CAN cores by default in the dtsi? >=20 > As far as I know, in the dtsi file we mention all the subsystems or > periherals present in the SoC and in the specific board dts file we > enable or disable the DT nodes depending on whether the pins are > brought out. If you disable the subsystems (that need pins) by default, you only have to list and configure only the used subsystems and not disable the unused ones. But it seems in the TI land you're following the rule you outlined above, so go ahead. Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --hpvarmjcpm2ogbfr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmD24noACgkQqclaivrt 76n/7Qf+PEg9CDe1udrXT9AkQwMz291wPkLCnJ1ovwadeNE9O2Ntj0lqsFsdJikZ Q6LXdiePRSKNgG0QaWasd4fU4sUOdBOXLvKCfvssW5GA1UfsMRYT+gECt4XaVdJ7 iGK+3T8PcygTvoalU8FrISpysm42BErouKENRQMa59yYJtAszH/RnB5VdtoM3M7u x/NRGqcof/YZlx+UmtHhMsK2Tq1KdaUH+xH9B7Qi6HGcEXPFTTRehMhKZf5Re8hK Ho91ZVWJfGQVPwHjP4C1MgXY8injX4Ib0ETYT4Psa8KPwE44YM0FrPq/ThwNR+Ff 97NPOogt5LaeAZXkztY32U7f5CgDkA== =mTBU -----END PGP SIGNATURE----- --hpvarmjcpm2ogbfr-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59C86C07E95 for ; Tue, 20 Jul 2021 14:51:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 25F67613BB for ; Tue, 20 Jul 2021 14:51:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 25F67613BB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UvhuHd5UALiaSngbLlDXUjh6T+gs0kvlZRqPBXYl1Tg=; b=o9e+vCV1njlx6rbOvIkmfpmcnG TjBytC0xXUUVrnz+sdbNQv8TzOHEqcZyWlec7WqHiGTAloCIxJYuhGOoixVqVh3NMMJ2FvvNqkaqC jXd5vaJL7kk7dUO6Fdt3dSyyeGTkYTu9waIWOYOL0g/5w7cubtIsaqjXsRycBFcERfRE0fV0dBFFO oNJcXdLZKTtpTfBAj3l8K7wKpjSOaK8XptJnMBSjOHj5+ufJurg7wbuvZbEOLxJLkjsIaEDr+iGow 6R4FV9QUM8YXpNTUkU6jqbbssdnqcjmaR3u1FzV2JMDzZ0VsFChkLWHK8zQoPIPt44FIDBQySOIw4 dYaFjGDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5r42-00DGOq-DR; Tue, 20 Jul 2021 14:49:42 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5r3y-00DGNZ-6m for linux-arm-kernel@lists.infradead.org; Tue, 20 Jul 2021 14:49:39 +0000 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5r3u-0004tk-QQ; Tue, 20 Jul 2021 16:49:34 +0200 Received: from pengutronix.de (unknown [IPv6:2a03:f580:87bc:d400:3120:e42a:5796:3403]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 73D13653103; Tue, 20 Jul 2021 14:49:33 +0000 (UTC) Date: Tue, 20 Jul 2021 16:49:32 +0200 From: Marc Kleine-Budde To: Aswath Govindraju Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Nishanth Menon , Tero Kristo , Rob Herring , Lokesh Vutla Subject: Re: [PATCH 1/6] arm64: dts: ti: k3-am65-mcu: Add Support for MCAN Message-ID: <20210720144932.5rtvpkmjooma7zae@pengutronix.de> References: <20210720141642.24999-1-a-govindraju@ti.com> <20210720141642.24999-2-a-govindraju@ti.com> <20210720142047.mfqssyj4lwh3yi2k@pengutronix.de> MIME-Version: 1.0 In-Reply-To: X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210720_074938_313501_64F199E1 X-CRM114-Status: GOOD ( 20.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6050421578539333330==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6050421578539333330== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hpvarmjcpm2ogbfr" Content-Disposition: inline --hpvarmjcpm2ogbfr Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 20.07.2021 20:00:32, Aswath Govindraju wrote: > Hi Marc, >=20 > On 20/07/21 7:50 pm, Marc Kleine-Budde wrote: > > On 20.07.2021 19:46:37, Aswath Govindraju wrote: > >> From: Faiz Abbas > >> > >> Add Support for two MCAN controllers present on the am65x SOC. Both su= pport > >> classic CAN messages as well as CAN-FD. > >=20 > > Thanks for the patch! > >=20 > > Why don't you disable the CAN cores by default in the dtsi? >=20 > As far as I know, in the dtsi file we mention all the subsystems or > periherals present in the SoC and in the specific board dts file we > enable or disable the DT nodes depending on whether the pins are > brought out. If you disable the subsystems (that need pins) by default, you only have to list and configure only the used subsystems and not disable the unused ones. But it seems in the TI land you're following the rule you outlined above, so go ahead. Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --hpvarmjcpm2ogbfr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmD24noACgkQqclaivrt 76n/7Qf+PEg9CDe1udrXT9AkQwMz291wPkLCnJ1ovwadeNE9O2Ntj0lqsFsdJikZ Q6LXdiePRSKNgG0QaWasd4fU4sUOdBOXLvKCfvssW5GA1UfsMRYT+gECt4XaVdJ7 iGK+3T8PcygTvoalU8FrISpysm42BErouKENRQMa59yYJtAszH/RnB5VdtoM3M7u x/NRGqcof/YZlx+UmtHhMsK2Tq1KdaUH+xH9B7Qi6HGcEXPFTTRehMhKZf5Re8hK Ho91ZVWJfGQVPwHjP4C1MgXY8injX4Ib0ETYT4Psa8KPwE44YM0FrPq/ThwNR+Ff 97NPOogt5LaeAZXkztY32U7f5CgDkA== =mTBU -----END PGP SIGNATURE----- --hpvarmjcpm2ogbfr-- --===============6050421578539333330== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6050421578539333330==--