From: "Marek Behún" <kabel@kernel.org>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH RFC net-next] net: phy: marvell10g: add downshift tunable support
Date: Tue, 20 Jul 2021 19:32:23 +0200 [thread overview]
Message-ID: <20210720193223.194cb79e@dellmb> (raw)
In-Reply-To: <20210720171401.GV22278@shell.armlinux.org.uk>
On Tue, 20 Jul 2021 18:14:01 +0100
"Russell King (Oracle)" <linux@armlinux.org.uk> wrote:
> On Tue, Jul 20, 2021 at 05:04:24PM +0200, Marek Behún wrote:
> > Hi Russell,
> >
> > On Tue, 20 Jul 2021 14:38:20 +0100
> > Russell King <rmk+kernel@armlinux.org.uk> wrote:
> >
> > > Add support for the downshift tunable for the Marvell 88x3310 PHY.
> > > Downshift is only usable with firmware 0.3.5.0 and later.
> >
> > mv3310_{g,s}et_features are also used for 88E211x, but there is no
> > such register in the documentation for these PHYs. (Also firmware
> > versions on those are different, the newest is 8.3.0.0, but thats
> > not important.) My solution would be to rename the current methods
> > prefix to mv211x_ and and add new mv3310_{g,s}et_tunable methods.
>
> There's more than just the tunables themselves - there's also
> config_init().
>
> We already need to reject downshift when old firmware is running,
> as that fails to work correctly. So, we can just do that for
> 88E211x as well, adding a flag to struct mv3310_chip to indicate
> whether downshift is present. Sound sensible?
Hmm, maybe add the flag to struct mv3310_priv, instead of struct
mv3310_chip, since the latter is static. And fill in the flag in
mv3310_probe() function, depending on firmware version?
BTW would you agree with a patch renaming the mv3310_ prefixes to
mv10g_ for all functions that are generic to both mv3310_ and mv2110_?
I was thinking about such a thing because it has become rather
confusing.
Marek
next prev parent reply other threads:[~2021-07-20 17:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 13:38 [PATCH RFC net-next] net: phy: marvell10g: add downshift tunable support Russell King
2021-07-20 14:28 ` Andrew Lunn
2021-07-20 14:30 ` Russell King (Oracle)
2021-07-20 15:04 ` Marek Behún
2021-07-20 17:14 ` Russell King (Oracle)
2021-07-20 17:32 ` Marek Behún [this message]
2021-07-20 17:39 ` Russell King (Oracle)
2021-07-20 17:50 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210720193223.194cb79e@dellmb \
--to=kabel@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.