From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 584B2C636C8 for ; Tue, 20 Jul 2021 22:51:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3BD3E61029 for ; Tue, 20 Jul 2021 22:51:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231285AbhGTWJI (ORCPT ); Tue, 20 Jul 2021 18:09:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:35570 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231294AbhGTWIu (ORCPT ); Tue, 20 Jul 2021 18:08:50 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CD333606A5; Tue, 20 Jul 2021 22:49:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626821367; bh=S0VBkMptMTBMbjlXlL3v3nxSVJbBzwoRLC13STy72fE=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=bpN59brQGPUtdQa9dWrAx0mFd04/ZQnXOjeiwi0mGLgC0s8WSRGtoOrLTT115IalN /CxuTWu6Y+HVfWNSZ2E1nKFyU9iv8L8ZvR/jZhMyRhNJasW9yBzZU2W0U78QVepML8 l8Hcqqd3Jum8OUrYlALzHjbY++rg4nl8wtuHXFISMMSoKihhP+Hz2ycuKQV5+2C7Pp 08mKiYYuDK8sSYHopWnOV2NgTiXoZGGfPtk7mua0V9tf9xzgixbyPqpNYLfC/L81K2 RbwzSswX/sHzc07Rc6Fq7b0W0N1KbJzzQNrea95cps/QzAxhE9OcwEljwLDZNcXbXY YG1vRgnPDrY7A== Date: Tue, 20 Jul 2021 17:49:25 -0500 From: Bjorn Helgaas To: Boqun Feng Cc: Bjorn Helgaas , Arnd Bergmann , Marc Zyngier , Catalin Marinas , Will Deacon , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, Sunil Muthuswamy , Mike Rapoport Subject: Re: [RFC v5 1/8] PCI: Introduce domain_nr in pci_host_bridge Message-ID: <20210720224925.GA137627@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210720134429.511541-2-boqun.feng@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 20, 2021 at 09:44:22PM +0800, Boqun Feng wrote: > Currently we retrieve the PCI domain number of the host bridge from the > bus sysdata (or pci_config_window if PCI_DOMAINS_GENERIC=y). Actually > we have the information at PCI host bridge probing time, and it makes > sense that we store it into pci_host_bridge. One benefit of doing so is > the requirement for supporting PCI on Hyper-V for ARM64, because the > host bridge of Hyper-V doesn't have pci_config_window, whereas ARM64 is > a PCI_DOMAINS_GENERIC=y arch, so we cannot retrieve the PCI domain > number from pci_config_window on ARM64 Hyper-V guest. > > As the preparation for ARM64 Hyper-V PCI support, we introduce the > domain_nr in pci_host_bridge and a sentinel value to allow drivers to > set domain numbers properly at probing time. Currently > CONFIG_PCI_DOMAINS_GENERIC=y archs are only users of this > newly-introduced field. > > Signed-off-by: Boqun Feng Once all the issues are ironed out, Lorenzo should probably merge this since it's primarily Hyper-V stuff, but I'm OK with this part: Acked-by: Bjorn Helgaas But fix the comment issue below. > --- > drivers/pci/probe.c | 6 +++++- > include/linux/pci.h | 10 ++++++++++ > 2 files changed, 15 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c > index 79177ac37880..60c50d4f156f 100644 > --- a/drivers/pci/probe.c > +++ b/drivers/pci/probe.c > @@ -594,6 +594,7 @@ static void pci_init_host_bridge(struct pci_host_bridge *bridge) > bridge->native_pme = 1; > bridge->native_ltr = 1; > bridge->native_dpc = 1; > + bridge->domain_nr = PCI_DOMAIN_NR_NOT_SET; > > device_initialize(&bridge->dev); > } > @@ -898,7 +899,10 @@ static int pci_register_host_bridge(struct pci_host_bridge *bridge) > bus->ops = bridge->ops; > bus->number = bus->busn_res.start = bridge->busnr; > #ifdef CONFIG_PCI_DOMAINS_GENERIC > - bus->domain_nr = pci_bus_find_domain_nr(bus, parent); > + if (bridge->domain_nr == PCI_DOMAIN_NR_NOT_SET) > + bus->domain_nr = pci_bus_find_domain_nr(bus, parent); > + else > + bus->domain_nr = bridge->domain_nr; > #endif > > b = pci_find_bus(pci_domain_nr(bus), bridge->busnr); > diff --git a/include/linux/pci.h b/include/linux/pci.h > index 540b377ca8f6..2c413a64d168 100644 > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -526,6 +526,15 @@ static inline int pci_channel_offline(struct pci_dev *pdev) > return (pdev->error_state != pci_channel_io_normal); > } > > +/* > +* Currently in ACPI spec, for each PCI host bridge, PCI Segment Group number is > +* limited to a 16-bit value, therefore (int)-1 is not a valid PCI domain number, > +* and can be used as a sentinel value indicating >domain_nr is not set by the > +* driver (and CONFIG_PCI_DOMAINS_GENERIC=y archs will set it with > +* pci_bus_find_domain_nr()). > +*/ Fix comment indentation (follow style of other comments in this file). s/>domain_nr/->domain_nr/ > +#define PCI_DOMAIN_NR_NOT_SET (-1) > + > struct pci_host_bridge { > struct device dev; > struct pci_bus *bus; /* Root bus */ > @@ -533,6 +542,7 @@ struct pci_host_bridge { > struct pci_ops *child_ops; > void *sysdata; > int busnr; > + int domain_nr; > struct list_head windows; /* resource_entry */ > struct list_head dma_ranges; /* dma ranges resource list */ > u8 (*swizzle_irq)(struct pci_dev *, u8 *); /* Platform IRQ swizzler */ > -- > 2.30.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC862C636C8 for ; Tue, 20 Jul 2021 22:51:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 764DE606A5 for ; Tue, 20 Jul 2021 22:51:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 764DE606A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=TNJyfFTSntMLG+z/sT2Z01S9cE5y6Xwz8SmHw6QysAI=; b=zHGZXuzttQ69jd IsANR789eHHwIswlEFshFia2kjb4xJCz1ObRieWRG6FegKOu6Ry9GttR+M+onqPJD8YssmnvNRnhP mUSpYnnutVTt3ihXZgM4m2bh8hhl7cOPNwj04QXql91UzBtjcPXOFMhGQtgpxJwn7N12udiWTsnCG FXBLmqPiet6b+w2hRSfua5+7ClvO46eAJvVg79/+OhnyLE7xmqOew5g4cIX5zyCo4OP24sh/tEGkW fx7YySqLaOSnZSx+5sSkv4tRtgOz9rCJcK5bQL+vndGS6Xk6IpTyIugoj1MfdhZKKKd9Q6pF0dgyT BWTA4QFw9SZtuO1u6tQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5yYO-00E6Fz-5n; Tue, 20 Jul 2021 22:49:32 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5yYK-00E6Fa-56 for linux-arm-kernel@lists.infradead.org; Tue, 20 Jul 2021 22:49:29 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id CD333606A5; Tue, 20 Jul 2021 22:49:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626821367; bh=S0VBkMptMTBMbjlXlL3v3nxSVJbBzwoRLC13STy72fE=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=bpN59brQGPUtdQa9dWrAx0mFd04/ZQnXOjeiwi0mGLgC0s8WSRGtoOrLTT115IalN /CxuTWu6Y+HVfWNSZ2E1nKFyU9iv8L8ZvR/jZhMyRhNJasW9yBzZU2W0U78QVepML8 l8Hcqqd3Jum8OUrYlALzHjbY++rg4nl8wtuHXFISMMSoKihhP+Hz2ycuKQV5+2C7Pp 08mKiYYuDK8sSYHopWnOV2NgTiXoZGGfPtk7mua0V9tf9xzgixbyPqpNYLfC/L81K2 RbwzSswX/sHzc07Rc6Fq7b0W0N1KbJzzQNrea95cps/QzAxhE9OcwEljwLDZNcXbXY YG1vRgnPDrY7A== Date: Tue, 20 Jul 2021 17:49:25 -0500 From: Bjorn Helgaas To: Boqun Feng Cc: Bjorn Helgaas , Arnd Bergmann , Marc Zyngier , Catalin Marinas , Will Deacon , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, Sunil Muthuswamy , Mike Rapoport Subject: Re: [RFC v5 1/8] PCI: Introduce domain_nr in pci_host_bridge Message-ID: <20210720224925.GA137627@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210720134429.511541-2-boqun.feng@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210720_154928_275919_C54EA8E9 X-CRM114-Status: GOOD ( 28.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 20, 2021 at 09:44:22PM +0800, Boqun Feng wrote: > Currently we retrieve the PCI domain number of the host bridge from the > bus sysdata (or pci_config_window if PCI_DOMAINS_GENERIC=y). Actually > we have the information at PCI host bridge probing time, and it makes > sense that we store it into pci_host_bridge. One benefit of doing so is > the requirement for supporting PCI on Hyper-V for ARM64, because the > host bridge of Hyper-V doesn't have pci_config_window, whereas ARM64 is > a PCI_DOMAINS_GENERIC=y arch, so we cannot retrieve the PCI domain > number from pci_config_window on ARM64 Hyper-V guest. > > As the preparation for ARM64 Hyper-V PCI support, we introduce the > domain_nr in pci_host_bridge and a sentinel value to allow drivers to > set domain numbers properly at probing time. Currently > CONFIG_PCI_DOMAINS_GENERIC=y archs are only users of this > newly-introduced field. > > Signed-off-by: Boqun Feng Once all the issues are ironed out, Lorenzo should probably merge this since it's primarily Hyper-V stuff, but I'm OK with this part: Acked-by: Bjorn Helgaas But fix the comment issue below. > --- > drivers/pci/probe.c | 6 +++++- > include/linux/pci.h | 10 ++++++++++ > 2 files changed, 15 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c > index 79177ac37880..60c50d4f156f 100644 > --- a/drivers/pci/probe.c > +++ b/drivers/pci/probe.c > @@ -594,6 +594,7 @@ static void pci_init_host_bridge(struct pci_host_bridge *bridge) > bridge->native_pme = 1; > bridge->native_ltr = 1; > bridge->native_dpc = 1; > + bridge->domain_nr = PCI_DOMAIN_NR_NOT_SET; > > device_initialize(&bridge->dev); > } > @@ -898,7 +899,10 @@ static int pci_register_host_bridge(struct pci_host_bridge *bridge) > bus->ops = bridge->ops; > bus->number = bus->busn_res.start = bridge->busnr; > #ifdef CONFIG_PCI_DOMAINS_GENERIC > - bus->domain_nr = pci_bus_find_domain_nr(bus, parent); > + if (bridge->domain_nr == PCI_DOMAIN_NR_NOT_SET) > + bus->domain_nr = pci_bus_find_domain_nr(bus, parent); > + else > + bus->domain_nr = bridge->domain_nr; > #endif > > b = pci_find_bus(pci_domain_nr(bus), bridge->busnr); > diff --git a/include/linux/pci.h b/include/linux/pci.h > index 540b377ca8f6..2c413a64d168 100644 > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -526,6 +526,15 @@ static inline int pci_channel_offline(struct pci_dev *pdev) > return (pdev->error_state != pci_channel_io_normal); > } > > +/* > +* Currently in ACPI spec, for each PCI host bridge, PCI Segment Group number is > +* limited to a 16-bit value, therefore (int)-1 is not a valid PCI domain number, > +* and can be used as a sentinel value indicating >domain_nr is not set by the > +* driver (and CONFIG_PCI_DOMAINS_GENERIC=y archs will set it with > +* pci_bus_find_domain_nr()). > +*/ Fix comment indentation (follow style of other comments in this file). s/>domain_nr/->domain_nr/ > +#define PCI_DOMAIN_NR_NOT_SET (-1) > + > struct pci_host_bridge { > struct device dev; > struct pci_bus *bus; /* Root bus */ > @@ -533,6 +542,7 @@ struct pci_host_bridge { > struct pci_ops *child_ops; > void *sysdata; > int busnr; > + int domain_nr; > struct list_head windows; /* resource_entry */ > struct list_head dma_ranges; /* dma ranges resource list */ > u8 (*swizzle_irq)(struct pci_dev *, u8 *); /* Platform IRQ swizzler */ > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel