Re: [PATCH][RFC] sched/cpuacct: Fix cpuacct charge

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3132 bytes --]

Hi Li,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on asm-generic/master]
[also build test WARNING on tip/sched/core tip/master linux/master linus/master v5.14-rc2 next-20210720]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Li-RongQing/sched-cpuacct-Fix-cpuacct-charge/20210720-150427
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git master
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/b7cbc83d1da5b3b55713e72269c478683f02c4eb
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Li-RongQing/sched-cpuacct-Fix-cpuacct-charge/20210720-150427
        git checkout b7cbc83d1da5b3b55713e72269c478683f02c4eb
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash kernel/sched/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   kernel/sched/cpuacct.c: In function 'cpuacct_charge':
   kernel/sched/cpuacct.c:344:25: error: implicit declaration of function 'get_irq_regs_cpu'; did you mean 'get_irq_regs'? [-Werror=implicit-function-declaration]
     344 |  struct pt_regs *regs = get_irq_regs_cpu(cpu) ? : task_pt_regs(tsk);
         |                         ^~~~~~~~~~~~~~~~
         |                         get_irq_regs
>> kernel/sched/cpuacct.c:344:49: warning: pointer/integer type mismatch in conditional expression
     344 |  struct pt_regs *regs = get_irq_regs_cpu(cpu) ? : task_pt_regs(tsk);
         |                                                 ^
   cc1: some warnings being treated as errors


vim +344 kernel/sched/cpuacct.c

   333	
   334	/*
   335	 * charge this task's execution time to its accounting group.
   336	 *
   337	 * called with rq->lock held.
   338	 */
   339	void cpuacct_charge(struct task_struct *tsk, u64 cputime)
   340	{
   341		struct cpuacct *ca;
   342		int index = CPUACCT_STAT_SYSTEM;
   343		int cpu = task_cpu(tsk);
 > 344		struct pt_regs *regs = get_irq_regs_cpu(cpu) ? : task_pt_regs(tsk);
   345	
   346		if (regs && user_mode(regs))
   347			index = CPUACCT_STAT_USER;
   348	
   349		rcu_read_lock();
   350	
   351		for (ca = task_ca(tsk); ca; ca = parent_ca(ca))
   352			__this_cpu_add(ca->cpuusage->usages[index], cputime);
   353	
   354		rcu_read_unlock();
   355	}
   356	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 70645 bytes --]