From: Christoph Hellwig <hch@lst.de>
To: Hillf Danton <hdanton@sina.com>
Cc: syzbot <syzbot+9937dc42271cd87d4b98@syzkaller.appspotmail.com>,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
syzkaller-bugs@googlegroups.com,
Eric Sandeen <sandeen@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Luis Chamberlain <mcgrof@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [syzbot] WARNING in internal_create_group
Date: Wed, 21 Jul 2021 06:30:34 +0200 [thread overview]
Message-ID: <20210721043034.GB7444@lst.de> (raw)
In-Reply-To: <20210721033703.949-1-hdanton@sina.com>
On Wed, Jul 21, 2021 at 11:37:03AM +0800, Hillf Danton wrote:
> On Tue, 20 Jul 2021 11:53:27 -0700
> >syzbot has found a reproducer for the following issue on:
> >
> >HEAD commit: 8cae8cd89f05 seq_file: disallow extremely large seq buffer..
> >git tree: upstream
> >console output: https://syzkaller.appspot.com/x/log.txt?x=116f92ec300000
> >kernel config: https://syzkaller.appspot.com/x/.config?x=7273c75708b55890
> >dashboard link: https://syzkaller.appspot.com/bug?extid=9937dc42271cd87d4b98
> >syz repro: https://syzkaller.appspot.com/x/repro.syz?x=15fc287c300000
> >C reproducer: https://syzkaller.appspot.com/x/repro.c?x=178cbf6a300000
<snip>
> >WARNING: CPU: 0 PID: 8435 at fs/sysfs/group.c:116 internal_create_group+0x911/0xb20 fs/sysfs/group.c:116
<snip>
> The device_add(ddev) in register_disk() may fail but it proceeds to register
> block queue even at the failure ... this falls in the class of known issue
> given the comment line.
>
> * FIXME: error handling
> */
> static void __device_add_disk(struct device *parent, struct gendisk *disk,
Yes, Luis is working on actually fixing this - but it requires changes
to every single block driver. How does a cap on the seq_buf size
propagate here, though?
next prev parent reply other threads:[~2021-07-21 4:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 18:57 [syzbot] WARNING in internal_create_group syzbot
2021-07-20 18:53 ` syzbot
[not found] ` <20210721033703.949-1-hdanton@sina.com>
2021-07-21 4:30 ` Christoph Hellwig [this message]
2021-08-11 21:37 ` Pavel Skripkin
2021-08-12 6:18 ` Christoph Hellwig
2021-09-16 6:55 ` Joel Stanley
2021-09-16 8:05 ` Greg Kroah-Hartman
2021-09-16 10:56 ` Pavel Skripkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210721043034.GB7444@lst.de \
--to=hch@lst.de \
--cc=gregkh@linuxfoundation.org \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=sandeen@redhat.com \
--cc=syzbot+9937dc42271cd87d4b98@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.