From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2AE9C07E9B for ; Wed, 21 Jul 2021 07:29:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ABFF360698 for ; Wed, 21 Jul 2021 07:29:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235390AbhGUGs6 (ORCPT ); Wed, 21 Jul 2021 02:48:58 -0400 Received: from verein.lst.de ([213.95.11.211]:57680 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234507AbhGUGsM (ORCPT ); Wed, 21 Jul 2021 02:48:12 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 67DB067373; Wed, 21 Jul 2021 09:28:47 +0200 (CEST) Date: Wed, 21 Jul 2021 09:28:47 +0200 From: Christoph Hellwig To: Arnd Bergmann Cc: netdev@vger.kernel.org, Christoph Hellwig , Arnd Bergmann Subject: Re: [PATCH v5 2/4] net: socket: rework SIOC?IFMAP ioctls Message-ID: <20210721072847.GB11257@lst.de> References: <20210720142436.2096733-1-arnd@kernel.org> <20210720142436.2096733-3-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210720142436.2096733-3-arnd@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > +static int dev_getifmap(struct net_device *dev, struct ifreq *ifr) > +{ > + struct ifmap *ifmap = &ifr->ifr_map; > + struct compat_ifmap *cifmap = (struct compat_ifmap *)&ifr->ifr_map; > + > + if (in_compat_syscall()) { Any reason that the cifmap declaration is outside this conditional? > +static int dev_setifmap(struct net_device *dev, struct ifreq *ifr) > +{ > + struct compat_ifmap *cifmap = (struct compat_ifmap *)&ifr->ifr_map; > + > + if (!dev->netdev_ops->ndo_set_config) > + return -EOPNOTSUPP; > + > + if (in_compat_syscall()) { Same here. Otherwise looks good: Reviewed-by: Christoph Hellwig