From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4B7EC07E9B for ; Wed, 21 Jul 2021 10:27:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75AE86044F for ; Wed, 21 Jul 2021 10:27:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75AE86044F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tvgVCcOGhacHz/oif5nqJdl1TsbHRCWGTdvm6c5VEhM=; b=2+T6AUZ6yME3MU 67pr5FKxCc/GEkFbrxDiCkSYe/GtEzqKQQgOy5f7sIvB1M1UFpY1vpDAyORUgdhzwW/nNmMHGrZvy 8ViN+aiPrWucAbC7TwHmQmZuVXHx6on0LI2TpctWKG8Z0y3k+M4yRkojKcQjz+BmK9JlmBAAo7VfV 757bs0UUnAMTJ2x2byMb6phOA2YdIKMgQ4o5gKlTiTogCPCWN7yegleFPSygDZELmzDoyoKWBPDAT CBnVGxx1vaI/IeyH/GKnWNALQ73VZ5Bn0vifHCSgDNTXrqSOmoS4GPJ9wFLJ26Ha22rsfId4WVug2 2CvM3SnSLelwMlVE9RIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m69Q8-00FFJl-TL; Wed, 21 Jul 2021 10:25:45 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m69Q5-00FFJI-7M for linux-arm-kernel@lists.infradead.org; Wed, 21 Jul 2021 10:25:42 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id E93CE61175; Wed, 21 Jul 2021 10:25:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626863140; bh=euY/uamjfJexuULQxgEDFTxIM6w50a1MsN2a9C2kBTk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YU3MVnofW02Rftehqnmw8bRkyrd1f72gyxnkt84gTUNLYzN0sMlfgSVBZYrjKt5MW /TPvfPfyGKfvImalw1bA3YT+0fLoHEdqI36+ckwiJeQOW6qfCFBRWFctXYm2vQ6K0n k14czfWkQKkKY4P0hWQvQmLPiXyR1Z9MKXzym3oOm1NwBKe0LTMaOyLdoTEmtS5H4V uKcG7qyHrUpjxHFogn9XR4t0NThoHvXtYPh+UX6nGfEbi/q14UkCPqIBkqwj+w1w2j bvgGFgNk0uoOz2O4oAeGueGlo8Zxy++lty6PuvakZ1Omd1c5KwtJyJb5mfH4uO7PjR 0JPYUaonEfWgw== Date: Wed, 21 Jul 2021 11:25:36 +0100 From: Will Deacon To: Vladimir Murzin Cc: Shaokun Zhang , linux-arm-kernel@lists.infradead.org, Lingyan Huang , Catalin Marinas Subject: Re: [PATCH v2] arm64: SSBS/DIT: print SSBS and DIT bit when printing PSTATE Message-ID: <20210721102536.GA10216@willie-the-truck> References: <1626835386-30788-1-git-send-email-zhangshaokun@hisilicon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210721_032541_324881_384E8592 X-CRM114-Status: GOOD ( 17.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 21, 2021 at 09:31:18AM +0100, Vladimir Murzin wrote: > On 7/21/21 3:43 AM, Shaokun Zhang wrote: > > From: Lingyan Huang > > > > The current code to print PSTATE when generating backtraces does not > > include SSBS bit and DIT bit, so add this information. > > > > Cc: Vladimir Murzin > > Cc: Catalin Marinas > > Cc: Will Deacon > > Signed-off-by: Lingyan Huang > > Signed-off-by: Shaokun Zhang > > --- > > ChangeLog: > > v1-->v2: > > 1. Address Vladimir's comment on update compat_user_mode > > > > arch/arm64/kernel/process.c | 11 ++++++++--- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c > > index c8989b999250..3da2ad00fa0c 100644 > > --- a/arch/arm64/kernel/process.c > > +++ b/arch/arm64/kernel/process.c > > @@ -163,7 +163,7 @@ static void print_pstate(struct pt_regs *regs) > > u64 pstate = regs->pstate; > > > > if (compat_user_mode(regs)) { > > - printk("pstate: %08llx (%c%c%c%c %c %s %s %c%c%c)\n", > > + printk("pstate: %08llx (%c%c%c%c %c %s %s %c%c%c %cPAN %cDIT %cSSBS)\n", > > pstate, > > pstate & PSR_AA32_N_BIT ? 'N' : 'n', > > pstate & PSR_AA32_Z_BIT ? 'Z' : 'z', > > @@ -174,12 +174,15 @@ static void print_pstate(struct pt_regs *regs) > > pstate & PSR_AA32_E_BIT ? "BE" : "LE", > > pstate & PSR_AA32_A_BIT ? 'A' : 'a', > > pstate & PSR_AA32_I_BIT ? 'I' : 'i', > > - pstate & PSR_AA32_F_BIT ? 'F' : 'f'); > > + pstate & PSR_AA32_F_BIT ? 'F' : 'f', > > + pstate & PSR_AA32_PAN_BIT ? '+' : '-', > > Hmm, commit message doesn't mention PAN bit... but I leave it to maintainers. Agreed, I don't see the rationale for exposing PAN for 32-bit userspace tasks. Please drop this part for v3. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel