From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH net-next v2] net: switchdev: switchdev_handle_fdb_del_to_device(): fix no-op function for disabled CONFIG_NET_SWITCHDEV
Date: Wed, 21 Jul 2021 10:29:25 +0000 [thread overview]
Message-ID: <20210721102924.ejzv3lxwbltx2wr2@skbuf> (raw)
In-Reply-To: <20210721101714.78977-1-mkl@pengutronix.de>
Hi Marc,
On Wed, Jul 21, 2021 at 12:17:14PM +0200, Marc Kleine-Budde wrote:
> In patch 8ca07176ab00 ("net: switchdev: introduce a fanout helper for
> SWITCHDEV_FDB_{ADD,DEL}_TO_DEVICE") new functionality including static
> inline no-op functions if CONFIG_NET_SWITCHDEV is disabled was added.
>
> This patch fixes the following build error for disabled
> CONFIG_NET_SWITCHDEV:
>
> | In file included from include/net/dsa.h:23,
> | from net/core/flow_dissector.c:8:
> | include/net/switchdev.h:410:1: error: expected identifier or ‘(’ before ‘{’ token
> | 410 | {
> | | ^
> | include/net/switchdev.h:399:1: warning: ‘switchdev_handle_fdb_del_to_device’ declared ‘static’ but never defined [-Wunused-function]
> | 399 | switchdev_handle_fdb_del_to_device(struct net_device *dev,
> | | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 8ca07176ab00 ("net: switchdev: introduce a fanout helper for SWITCHDEV_FDB_{ADD,DEL}_TO_DEVICE")
> Cc: Vladimir Oltean <vladimir.oltean@nxp.com>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
Thank you for the patch and sorry for the breakage, I've been waiting
for my version to get accepted since yesterday:
https://patchwork.kernel.org/project/netdevbpf/patch/20210720173557.999534-2-vladimir.oltean@nxp.com/
next prev parent reply other threads:[~2021-07-21 11:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 10:17 [PATCH net-next v2] net: switchdev: switchdev_handle_fdb_del_to_device(): fix no-op function for disabled CONFIG_NET_SWITCHDEV Marc Kleine-Budde
2021-07-21 10:29 ` Vladimir Oltean [this message]
2021-07-21 15:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210721102924.ejzv3lxwbltx2wr2@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=kernel@pengutronix.de \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.