All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Jose R. Ziviani" <jziviani@suse.de>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, cfontana@suse.de
Subject: Re: [RFC 1/2] modules: Option to build native TCG with --enable-modules
Date: Wed, 21 Jul 2021 12:59:06 +0200	[thread overview]
Message-ID: <20210721105906.lhosqmzqbh5xdxvi@sirius.home.kraxel.org> (raw)
In-Reply-To: <20210629212819.24389-2-jziviani@suse.de>

On Tue, Jun 29, 2021 at 06:28:18PM -0300, Jose R. Ziviani wrote:
> Adds an option (--enable-tcg-builtin) to build TCG natively when
> --enable-modules argument is passed to the build system. It gives
> the opportunity to have the accelerator built-in and still take
> advantage of the new modular system.

I think we should not special-case tcg here.  Either allow setting =y
for all modules with all the consequences this has for maintainance and
testing, or leave things as-is.

See also recent discussions kicked by Claudio Fontana.

take care,
  Gerd

PS: just back from vacation, wading backwards through
    my mail backlog ...).



  reply	other threads:[~2021-07-21 11:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-29 21:28 [RFC 0/2] Option to build native TCG with --enable-modules Jose R. Ziviani
2021-06-29 21:28 ` [RFC 1/2] modules: " Jose R. Ziviani
2021-07-21 10:59   ` Gerd Hoffmann [this message]
2021-07-21 11:03     ` Claudio Fontana
2021-06-29 21:28 ` [RFC 2/2] modules: Fix warning in module_arch documentation Jose R. Ziviani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210721105906.lhosqmzqbh5xdxvi@sirius.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=cfontana@suse.de \
    --cc=jziviani@suse.de \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.