All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Christoph Hellwig <hch@infradead.org>
Cc: Josef Bacik <josef@toxicpanda.com>,
	linux-btrfs@vger.kernel.org, kernel-team@fb.com,
	linux-fsdevel@vger.kernel.org,
	Nikolay Borisov <nborisov@suse.com>
Subject: Re: [PATCH v3 6/9] fs: add a filemap_fdatawrite_wbc helper
Date: Wed, 21 Jul 2021 13:20:15 +0200	[thread overview]
Message-ID: <20210721112015.GC19710@twin.jikos.cz> (raw)
In-Reply-To: <YO/UfqDrIEizq7Re@infradead.org>

On Thu, Jul 15, 2021 at 07:23:58AM +0100, Christoph Hellwig wrote:
> >  extern int filemap_check_errors(struct address_space *mapping);
> >  extern void __filemap_set_wb_err(struct address_space *mapping, int err);
> > +extern int filemap_fdatawrite_wbc(struct address_space *mapping,
> > +				  struct writeback_control *wbc);
> 
> No need for the extern here.

I'll remove it when applying the patch. There are many externs in the
file but also declaration without it so this one won't stand out.

  reply	other threads:[~2021-07-21 11:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-14 18:47 [PATCH v3 0/9] ENOSPC delalloc flushing fixes Josef Bacik
2021-07-14 18:47 ` [PATCH v3 1/9] btrfs: wake up async_delalloc_pages waiters after submit Josef Bacik
2021-07-14 18:47 ` [PATCH v3 2/9] btrfs: include delalloc related info in dump space info tracepoint Josef Bacik
2021-07-14 18:47 ` [PATCH v3 3/9] btrfs: enable a tracepoint when we fail tickets Josef Bacik
2021-07-14 18:47 ` [PATCH v3 4/9] btrfs: handle shrink_delalloc pages calculation differently Josef Bacik
2021-07-14 18:47 ` [PATCH v3 5/9] btrfs: wait on async extents when flushing delalloc Josef Bacik
2021-07-14 18:47 ` [PATCH v3 6/9] fs: add a filemap_fdatawrite_wbc helper Josef Bacik
2021-07-15  6:23   ` Christoph Hellwig
2021-07-21 11:20     ` David Sterba [this message]
2021-07-14 18:47 ` [PATCH v3 7/9] btrfs: use the filemap_fdatawrite_wbc helper for delalloc shrinking Josef Bacik
2021-07-14 18:47 ` [PATCH v3 8/9] 9p: migrate from sync_inode to filemap_fdatawrite_wbc Josef Bacik
2021-07-15  6:25   ` Christoph Hellwig
2021-07-21 10:49   ` David Sterba
2021-07-14 18:47 ` [PATCH v3 9/9] fs: kill sync_inode Josef Bacik
2021-07-15  6:27   ` Christoph Hellwig
2021-07-15  7:31 ` [PATCH v3 0/9] ENOSPC delalloc flushing fixes Nikolay Borisov
2021-07-21 11:29 ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210721112015.GC19710@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=hch@infradead.org \
    --cc=josef@toxicpanda.com \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=nborisov@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.