From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45AD9C636C9 for ; Wed, 21 Jul 2021 13:26:26 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5605860725 for ; Wed, 21 Jul 2021 13:26:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5605860725 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 96CD18164D; Wed, 21 Jul 2021 15:26:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="f70/C1JK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 41FE881BC0; Wed, 21 Jul 2021 15:26:20 +0200 (CEST) Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6FD088164D for ; Wed, 21 Jul 2021 15:26:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x832.google.com with SMTP id k9so1872779qtx.3 for ; Wed, 21 Jul 2021 06:26:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WzmlpVDp5IcJ1yDHaPPS8/S1R7lkI9odDw08+IRpxCE=; b=f70/C1JKaPgJSgbze6EYMz+mOODVk9d9OOo03gvbcwBaBg7oNPQHvR5Z9GZrzSiUP7 9b/QNJLMWUPVgdD4n9pK9E84uu77Vh5majx04Goi1j3xb8ErWpBnlRyOXrl+v/XvLG1m r3ej/CpqF3GcTRdfJxnENVTsAo4Ns1F7H98BE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=WzmlpVDp5IcJ1yDHaPPS8/S1R7lkI9odDw08+IRpxCE=; b=jwIFFx3h9hlWXvJFdoGyGkSp7CBF6Vt4qRt2efbj4jsOmsHGVZfT0xhp0WO4vwv+5l uBirdRvTePOjiT0dgfc+YHH4Vt5+S1MFuXPhmkACCUJ6QdCAGxW+r0hfM2tinAbSF+3w Ej4BC55FbFhGG6nkKnWTCMJYsizQoRTkT7vblbEukyu4ARvZfzgqbn8pxvTzM8//zR7W kNOXsFPJRu76mrXweVT18QAMBkWBuaYEpFrAutDJaymIJAoafcO1fdjJQS+ifz8qIhBJ GRxcIM+uLPW9662I9fpZKXAYkWXxA5cVllxEUFMIsTA0sLk0b4Ik8ClYiRvAfAOAaXK4 ymyA== X-Gm-Message-State: AOAM530A5Lnv/NiMFw24FZZoyhE99W6hJlIC1Dmu71GRQY3Gtae7nVqw O583gRyuTjhhDxRHA7+S2YBhbg== X-Google-Smtp-Source: ABdhPJxDSm3zHSFKnbjFPpSWNL3mX9d5pR6bZ4jknTu38SrNm5rDzDXweQzux2l45zF9THLid1+8pw== X-Received: by 2002:a05:622a:1987:: with SMTP id u7mr30061612qtc.45.1626873975173; Wed, 21 Jul 2021 06:26:15 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-9c8c-8f20-851e-7861.res6.spectrum.com. [2603:6081:7b01:cbda:9c8c:8f20:851e:7861]) by smtp.gmail.com with ESMTPSA id i21sm8257231qtw.68.2021.07.21.06.26.14 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 21 Jul 2021 06:26:14 -0700 (PDT) Date: Wed, 21 Jul 2021 09:26:12 -0400 From: Tom Rini To: Peng Fan Cc: Stefano Babic , Frieder Schrempf , "U-Boot@lists.denx.de" Subject: Re: Pull request: u-boot-imx u-boot-imx-20210720 Message-ID: <20210721132612.GR9379@bill-the-cat> References: <5eec1cef-521b-f612-fb24-85314486c35c@denx.de> <20210720174512.GN9379@bill-the-cat> <80a1b07f-939c-62d8-374c-18c1cccc0550@kontron.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mwyYwuEU+DI08Yj7" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --mwyYwuEU+DI08Yj7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 21, 2021 at 10:23:12AM +0000, Peng Fan wrote: > Sorry for non-text top posting. >=20 > The imx8ulp patch set has pin headers that would have lots warning, but w= e have agreement in Linux kernel that they are acceptable. Or you need we f= ix the line 100 warning? >=20 > Are there others blocking the patch set? I saw at least a few "spaces before tabs" and similar errors. The best answer I can give here is to run checkpatch.pl in the tree and make sure there's nothing that's not just pin headers/long lines. But I do think I saw some about general coding style too. --=20 Tom --mwyYwuEU+DI08Yj7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmD4IHAACgkQFHw5/5Y0 tyyOggv/f6id9F5nYyyppAZlavCPJpfmCVyFPPcRSNhw6ZejBn9iTT6900VsLQKE H/PmlCSkPRB65nFO1hSQ+8XGXSbadaK6NyOLQvGxkreVyVv30CYqRS0HL7OJx0Yb t/5sVks00OH+8fHn1JD7uOmuuU4C+JEqxS7fE7ndleOX7kaGT6TXyKG1t8+nVs2h 8hL3Ps09ecX27MQz7J+iqpgjBOyWG8BF8CTDxci4vloWReRhsOi5vEIlwjhw6BkF 0PHRsdopBDywxRV5fa2qdp92meoY9RNPSqfT1PnPVgy6bF8Z/e1IGaKQ8609fYx7 zPkdMmM3lCfMk4B4uqMTkzCtQUurXbHfqKdlnHIArLmhINz7ukGt+/teMe9qm7dw eBXAq0miactC5BkJg1pVwDDF4HaP7Tn5hSQJ+ZPR4v/5tJgHSiQqU5tvdWBqTcW0 FPWTwH86YDpRyTpFsspq6paHkd6XwhVie78vtrTb7FwXRwCYAUbZrQDFpQaAGRtK EqR735pD =8Aq9 -----END PGP SIGNATURE----- --mwyYwuEU+DI08Yj7--