From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1m6DL7-0002fs-GC for mharc-grub-devel@gnu.org; Wed, 21 Jul 2021 10:36:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48908) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6DL5-0002eP-UP for grub-devel@gnu.org; Wed, 21 Jul 2021 10:36:47 -0400 Received: from dibed.net-space.pl ([84.10.22.86]:57903) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_3DES_EDE_CBC_SHA1:192) (Exim 4.90_1) (envelope-from ) id 1m6DL4-0003Wb-9F for grub-devel@gnu.org; Wed, 21 Jul 2021 10:36:47 -0400 Received: from router-fw.i.net-space.pl ([192.168.52.1]:58676 "EHLO tomti.i.net-space.pl") by router-fw-old.i.net-space.pl with ESMTP id S2109611AbhGUOgi (ORCPT ); Wed, 21 Jul 2021 16:36:38 +0200 X-Comment: RFC 2476 MSA function at dibed.net-space.pl logged sender identity as: dkiper Date: Wed, 21 Jul 2021 16:36:35 +0200 From: Daniel Kiper To: Stefan Berger Cc: grub-devel@gnu.org, Daniel Axtens , Stefan Berger Subject: Re: [PATCH v2 1/4] ieee1275: drop HEAP_MAX_ADDR, HEAP_MIN_SIZE Message-ID: <20210721143635.uekavdbrq4xszp3p@tomti.i.net-space.pl> References: <20210720211449.572356-1-stefanb@linux.vnet.ibm.com> <20210720211449.572356-2-stefanb@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210720211449.572356-2-stefanb@linux.vnet.ibm.com> User-Agent: NeoMutt/20170113 (1.7.2) Received-SPF: pass client-ip=84.10.22.86; envelope-from=dkiper@net-space.pl; helo=dibed.net-space.pl X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jul 2021 14:36:48 -0000 On Tue, Jul 20, 2021 at 05:14:46PM -0400, Stefan Berger wrote: > From: Daniel Axtens > > HEAP_MAX_ADDR is confusing. Currently it is set to 32MB, except > on ieee1275 on x86, where it is 64MB. > > There is a comment which purports to explain it: > > /* If possible, we will avoid claiming heap above this address, because it > seems to cause relocation problems with OSes that link at 4 MiB */ > > This doesn't make a lot of sense when the constants are well above 4MB > already. It was not always this way. Prior to > commit 7b5d0fe4440c ("Increase heap limit") in 2010, HEAP_MAX_SIZE and > HEAP_MAX_ADDR were indeed 4MB. However, when the constants were increased > the comment was left unchanged. > > It's been over a decade. It doesn't seem like we have problems with > claims over 4MB on powerpc or x86 ieee1275. (sparc does things completely > differently and never used the constant.) > > Drop the constant and the check. > > The only use of HEAP_MIN_SIZE was to potentially override the > HEAP_MAX_ADDR check. It is now unused. Remove it. > > Signed-off-by: Daniel Axtens > Tested-by: Stefan Berger Nit, you should add your Signed-off-by after Daniel's one. I can make it for you if you do not object. Otherwise: Reviewed-by: Daniel Kiper Daniel