From: Pavel Skripkin <paskripkin@gmail.com>
To: Andre Naujoks <nautsch2@gmail.com>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Stephane Grosjean <s.grosjean@peak-system.com>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Colin Ian King <colin.king@canonical.com>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Expose Peak USB device id in sysfs via phys_port_name.
Date: Wed, 21 Jul 2021 15:52:40 +0300 [thread overview]
Message-ID: <20210721155240.57887e6c@gmail.com> (raw)
In-Reply-To: <20210721124048.590426-1-nautsch2@gmail.com>
On Wed, 21 Jul 2021 14:40:47 +0200
Andre Naujoks <nautsch2@gmail.com> wrote:
> The Peak USB CAN adapters can be assigned a device id via the Peak
> provided tools (pcan-settings). This id can currently not be set by
> the upstream kernel drivers, but some devices expose this id already.
>
> The id can be used for consistent naming of CAN interfaces regardless
> of order of attachment or recognition on the system. The classical
> CAN Peak USB adapters expose this id via bcdDevice (combined with
> another value) on USB-level in the sysfs tree and this value is then
> available in ID_REVISION from udev. This is not a feasible approach,
> when a single USB device offers more than one CAN-interface, like
> e.g. the PCAN-USB Pro FD devices.
>
> This patch exposes those ids via the, up to now unused, netdevice
> sysfs attribute phys_port_name as a simple decimal ASCII
> representation of the id. phys_port_id was not used, since the
> default print functions from net/core/net-sysfs.c output a
> hex-encoded binary value, which is overkill for a one-byte device id,
> like this one.
Hi, Andre!
You should add Signed-off-by tag to the patch
With regards,
Pavel Skripkin
next prev parent reply other threads:[~2021-07-21 12:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 12:40 [PATCH] Expose Peak USB device id in sysfs via phys_port_name Andre Naujoks
2021-07-21 12:52 ` Pavel Skripkin [this message]
2021-07-21 12:59 ` [PATCH v2] " Andre Naujoks
2021-07-21 13:29 ` Stéphane Grosjean
2021-07-21 13:39 ` Andre Naujoks
[not found] ` <DBBPR03MB67952FE719401869BC8F1A77D6E59@DBBPR03MB6795.eurprd03.prod.outlook.com>
2021-07-23 7:33 ` Andre Naujoks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210721155240.57887e6c@gmail.com \
--to=paskripkin@gmail.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=gustavoars@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=nautsch2@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=s.grosjean@peak-system.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.