* [PATCH] drivers: net: aquantia: fix unsigned compared against 0
@ 2021-07-21 16:13 Cosmin-Florin Aluchenesei
2021-07-22 19:14 ` Ramon Fried
0 siblings, 1 reply; 3+ messages in thread
From: Cosmin-Florin Aluchenesei @ 2021-07-21 16:13 UTC (permalink / raw)
To: joe.hershberger, rfried.dev
Cc: ioana.ciornei, u-boot, Cosmin-Florin Aluchenesei
Change the reg variable to not be unsigned so that we not get into an
unsigned compared against 0.
Signed-off-by: Cosmin-Florin Aluchenesei <aluchenesei.cosmin-florin@nxp.com>
---
drivers/net/phy/aquantia.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/aquantia.c b/drivers/net/phy/aquantia.c
index 9061afa620..d3d35a75d0 100644
--- a/drivers/net/phy/aquantia.c
+++ b/drivers/net/phy/aquantia.c
@@ -3,7 +3,7 @@
* Aquantia PHY drivers
*
* Copyright 2014 Freescale Semiconductor, Inc.
- * Copyright 2018 NXP
+ * Copyright 2018, 2021 NXP
*/
#include <config.h>
#include <common.h>
@@ -554,8 +554,9 @@ int aquantia_config(struct phy_device *phydev)
int aquantia_startup(struct phy_device *phydev)
{
- u32 reg, speed;
+ u32 speed;
int i = 0;
+ int reg;
phydev->duplex = DUPLEX_FULL;
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: net: aquantia: fix unsigned compared against 0
2021-07-21 16:13 [PATCH] drivers: net: aquantia: fix unsigned compared against 0 Cosmin-Florin Aluchenesei
@ 2021-07-22 19:14 ` Ramon Fried
2021-07-22 19:16 ` Ramon Fried
0 siblings, 1 reply; 3+ messages in thread
From: Ramon Fried @ 2021-07-22 19:14 UTC (permalink / raw)
To: Cosmin-Florin Aluchenesei
Cc: Joe Hershberger, ioana.ciornei, U-Boot Mailing List
On Wed, Jul 21, 2021 at 7:13 PM Cosmin-Florin Aluchenesei
<aluchenesei.cosmin-florin@nxp.com> wrote:
>
> Change the reg variable to not be unsigned so that we not get into an
> unsigned compared against 0.
>
> Signed-off-by: Cosmin-Florin Aluchenesei <aluchenesei.cosmin-florin@nxp.com>
> ---
> drivers/net/phy/aquantia.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/phy/aquantia.c b/drivers/net/phy/aquantia.c
> index 9061afa620..d3d35a75d0 100644
> --- a/drivers/net/phy/aquantia.c
> +++ b/drivers/net/phy/aquantia.c
> @@ -3,7 +3,7 @@
> * Aquantia PHY drivers
> *
> * Copyright 2014 Freescale Semiconductor, Inc.
> - * Copyright 2018 NXP
> + * Copyright 2018, 2021 NXP
> */
> #include <config.h>
> #include <common.h>
> @@ -554,8 +554,9 @@ int aquantia_config(struct phy_device *phydev)
>
> int aquantia_startup(struct phy_device *phydev)
> {
> - u32 reg, speed;
> + u32 speed;
> int i = 0;
> + int reg;
>
> phydev->duplex = DUPLEX_FULL;
>
> --
> 2.21.0
>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: net: aquantia: fix unsigned compared against 0
2021-07-22 19:14 ` Ramon Fried
@ 2021-07-22 19:16 ` Ramon Fried
0 siblings, 0 replies; 3+ messages in thread
From: Ramon Fried @ 2021-07-22 19:16 UTC (permalink / raw)
To: Cosmin-Florin Aluchenesei
Cc: Joe Hershberger, ioana.ciornei, U-Boot Mailing List
On Thu, Jul 22, 2021 at 10:14 PM Ramon Fried <rfried.dev@gmail.com> wrote:
>
> On Wed, Jul 21, 2021 at 7:13 PM Cosmin-Florin Aluchenesei
> <aluchenesei.cosmin-florin@nxp.com> wrote:
> >
> > Change the reg variable to not be unsigned so that we not get into an
> > unsigned compared against 0.
> >
> > Signed-off-by: Cosmin-Florin Aluchenesei <aluchenesei.cosmin-florin@nxp.com>
> > ---
> > drivers/net/phy/aquantia.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/phy/aquantia.c b/drivers/net/phy/aquantia.c
> > index 9061afa620..d3d35a75d0 100644
> > --- a/drivers/net/phy/aquantia.c
> > +++ b/drivers/net/phy/aquantia.c
> > @@ -3,7 +3,7 @@
> > * Aquantia PHY drivers
> > *
> > * Copyright 2014 Freescale Semiconductor, Inc.
> > - * Copyright 2018 NXP
> > + * Copyright 2018, 2021 NXP
> > */
> > #include <config.h>
> > #include <common.h>
> > @@ -554,8 +554,9 @@ int aquantia_config(struct phy_device *phydev)
> >
> > int aquantia_startup(struct phy_device *phydev)
> > {
> > - u32 reg, speed;
> > + u32 speed;
> > int i = 0;
> > + int reg;
> >
> > phydev->duplex = DUPLEX_FULL;
> >
> > --
> > 2.21.0
> >
> Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
Applied to u-boot-net/network-master
Thanks,
Ramon.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-22 19:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-21 16:13 [PATCH] drivers: net: aquantia: fix unsigned compared against 0 Cosmin-Florin Aluchenesei
2021-07-22 19:14 ` Ramon Fried
2021-07-22 19:16 ` Ramon Fried
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.