From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58108C636C9 for ; Wed, 21 Jul 2021 16:26:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4193D61242 for ; Wed, 21 Jul 2021 16:26:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235104AbhGUPqU (ORCPT ); Wed, 21 Jul 2021 11:46:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:40809 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235319AbhGUPqP (ORCPT ); Wed, 21 Jul 2021 11:46:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626884811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m+x1aVmvJEpbSpTNhe+gSPdN5GMbbTZag6bLJsVFPDU=; b=CHiHl7DtJ01SHTWIVkKyk38j/UIPOpK2ylGo8zojJDwjmfMgKCSQcj20e1QyasS+Thrp7H BvO3tZ8svpVjPnNr5snQHwAzDTQ4PhNGkfY3F/uRU+1WLphrAXXG9S0iMtkVZ9P323m+lR noeNuW26JXDXr1XPSISHPF1y1Soqt5g= Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-584-j9nrV3XFPum6Fg8IKDxK8g-1; Wed, 21 Jul 2021 12:26:49 -0400 X-MC-Unique: j9nrV3XFPum6Fg8IKDxK8g-1 Received: by mail-io1-f72.google.com with SMTP id k2-20020a5d8b020000b029050b6f9cfe31so1937150ion.11 for ; Wed, 21 Jul 2021 09:26:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=m+x1aVmvJEpbSpTNhe+gSPdN5GMbbTZag6bLJsVFPDU=; b=jdahz6ExWQXVqs31zlc+ymTGUPOSYsQ3gtjA4OWPVwI6onokvtctKRgS9QpbUXDJ+c QnrJu33T+Wr+ZEZvUIinCkmjF3rkTwWbF3ezQcnxrbQJrBnVlrIaMCBf3g6nbM0xGrhf gZpM/BdYXLJcb8+fVfCtF9aqOwbpqZOLQyGHD8mQD1ytEQPBf2JMhKhvV9RSolmWynNM E7nsoOmDaMRF7gKcxZ2JgeGKJanNmreSu6SwpCQQZtG2bKmWuJnMtbWxg334yEP66Wky euJ0x45nanVJNDGp7QLjsqL4C4HOMdk84UmpuKHMjuJgprOBVvwZeUiEWNmmkFdgpobz fIpw== X-Gm-Message-State: AOAM533BnqtEQ6aoWl7yCTwHx7VCySeJwUOva1KwyPDG4ZEWjR4GucKv E7MEhUWO0UmFy8DpU5MEMggninTduB8hqCLAS+TRMPTkVpZT8fMWnVKoOot4IKfPsuKJ7TfaTtF BVVo+YAEiyL4I X-Received: by 2002:a6b:fe03:: with SMTP id x3mr7853639ioh.120.1626884808812; Wed, 21 Jul 2021 09:26:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwgzuS9Yi4VtCvnXQZWmI5CguoZwANnXgiGFfIgiUSl1f7p3if1KjZl/ILBiSx0bJnXvz5BQ== X-Received: by 2002:a6b:fe03:: with SMTP id x3mr7853623ioh.120.1626884808633; Wed, 21 Jul 2021 09:26:48 -0700 (PDT) Received: from gator ([140.82.166.162]) by smtp.gmail.com with ESMTPSA id m1sm14838987iok.33.2021.07.21.09.26.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jul 2021 09:26:48 -0700 (PDT) Date: Wed, 21 Jul 2021 18:26:45 +0200 From: Andrew Jones To: Oliver Upton Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, Marc Zyngier , Raghavendra Rao Anata , Peter Shier , Sean Christopherson , David Matlack , Paolo Bonzini , linux-arm-kernel@lists.infradead.org, Jim Mattson Subject: Re: [PATCH v3 09/12] selftests: KVM: Add support for aarch64 to system_counter_offset_test Message-ID: <20210721162645.5frobtrhtniyanng@gator> References: <20210719184949.1385910-1-oupton@google.com> <20210719184949.1385910-10-oupton@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210719184949.1385910-10-oupton@google.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Jul 19, 2021 at 06:49:46PM +0000, Oliver Upton wrote: > KVM/arm64 now allows userspace to adjust the guest virtual counter-timer > via a vCPU device attribute. Test that changes to the virtual > counter-timer offset result in the correct view being presented to the > guest. > > Signed-off-by: Oliver Upton > --- > tools/testing/selftests/kvm/Makefile | 1 + > .../selftests/kvm/include/aarch64/processor.h | 12 +++++ > .../kvm/system_counter_offset_test.c | 54 ++++++++++++++++++- > 3 files changed, 66 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile > index 7bf2e5fb1d5a..d89908108c97 100644 > --- a/tools/testing/selftests/kvm/Makefile > +++ b/tools/testing/selftests/kvm/Makefile > @@ -96,6 +96,7 @@ TEST_GEN_PROGS_aarch64 += kvm_page_table_test > TEST_GEN_PROGS_aarch64 += set_memory_region_test > TEST_GEN_PROGS_aarch64 += steal_time > TEST_GEN_PROGS_aarch64 += kvm_binary_stats_test > +TEST_GEN_PROGS_aarch64 += system_counter_offset_test > > TEST_GEN_PROGS_s390x = s390x/memop > TEST_GEN_PROGS_s390x += s390x/resets > diff --git a/tools/testing/selftests/kvm/include/aarch64/processor.h b/tools/testing/selftests/kvm/include/aarch64/processor.h > index 27dc5c2e56b9..3168cdbae6ee 100644 > --- a/tools/testing/selftests/kvm/include/aarch64/processor.h > +++ b/tools/testing/selftests/kvm/include/aarch64/processor.h > @@ -129,4 +129,16 @@ void vm_install_sync_handler(struct kvm_vm *vm, > > #define isb() asm volatile("isb" : : : "memory") > > +static inline uint64_t read_cntvct_ordered(void) > +{ > + uint64_t r; > + > + __asm__ __volatile__("isb\n\t" > + "mrs %0, cntvct_el0\n\t" > + "isb\n\t" > + : "=r"(r)); > + > + return r; > +} > + > #endif /* SELFTEST_KVM_PROCESSOR_H */ > diff --git a/tools/testing/selftests/kvm/system_counter_offset_test.c b/tools/testing/selftests/kvm/system_counter_offset_test.c > index 7e9015770759..88ad997f5b69 100644 > --- a/tools/testing/selftests/kvm/system_counter_offset_test.c > +++ b/tools/testing/selftests/kvm/system_counter_offset_test.c > @@ -53,7 +53,59 @@ static uint64_t host_read_guest_system_counter(struct test_case *test) > return rdtsc() + test->tsc_offset; > } > > -#else /* __x86_64__ */ > +#elif __aarch64__ /* __x86_64__ */ > + > +enum arch_counter { > + VIRTUAL, > +}; > + > +struct test_case { > + enum arch_counter counter; > + uint64_t offset; > +}; > + > +static struct test_case test_cases[] = { > + { .counter = VIRTUAL, .offset = 0 }, > + { .counter = VIRTUAL, .offset = 180 * NSEC_PER_SEC }, > + { .counter = VIRTUAL, .offset = -180 * NSEC_PER_SEC }, > +}; > + > +static void check_preconditions(struct kvm_vm *vm) > +{ > + if (!_vcpu_has_device_attr(vm, VCPU_ID, KVM_ARM_VCPU_TIMER_CTRL, > + KVM_ARM_VCPU_TIMER_OFFSET_VTIMER)) > + return; > + > + print_skip("KVM_ARM_VCPU_TIMER_OFFSET_VTIMER not supported; skipping test"); > + exit(KSFT_SKIP); > +} > + > +static void setup_system_counter(struct kvm_vm *vm, struct test_case *test) > +{ > + vcpu_access_device_attr(vm, VCPU_ID, KVM_ARM_VCPU_TIMER_CTRL, > + KVM_ARM_VCPU_TIMER_OFFSET_VTIMER, &test->offset, > + true); > +} > + > +static uint64_t guest_read_system_counter(struct test_case *test) > +{ > + switch (test->counter) { > + case VIRTUAL: > + return read_cntvct_ordered(); > + default: > + GUEST_ASSERT(0); > + } > + > + /* unreachable */ > + return 0; > +} > + > +static uint64_t host_read_guest_system_counter(struct test_case *test) > +{ > + return read_cntvct_ordered() - test->offset; > +} > + > +#else /* __aarch64__ */ > > #error test not implemented for this architecture! > > -- > 2.32.0.402.g57bb445576-goog > > _______________________________________________ > kvmarm mailing list > kvmarm@lists.cs.columbia.edu > https://lists.cs.columbia.edu/mailman/listinfo/kvmarm > Reviewed-by: Andrew Jones From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD1E1C12002 for ; Wed, 21 Jul 2021 16:26:54 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 4F62761242 for ; Wed, 21 Jul 2021 16:26:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F62761242 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id BE4E14B100; Wed, 21 Jul 2021 12:26:53 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qMjMYXLvv9SS; Wed, 21 Jul 2021 12:26:52 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 914E04B115; Wed, 21 Jul 2021 12:26:52 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C2B854B100 for ; Wed, 21 Jul 2021 12:26:51 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R+jZR+6OwbIu for ; Wed, 21 Jul 2021 12:26:50 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B00094086F for ; Wed, 21 Jul 2021 12:26:50 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626884810; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m+x1aVmvJEpbSpTNhe+gSPdN5GMbbTZag6bLJsVFPDU=; b=iKhz1ocfWiID1lGL82qLvbKTY6rDNO4EZ5esICYOx6HgdgVVn790sOduhYWCYDZnAk+Xxx hiNQNR2SVfBAl1wxH+UWOoSiX95pCOIxoy9rLlufNs2YC8BDacCE0eIg6b9P5w7hA8C8+e 3dbe4fUD+cz5hzFhI+eSAr4gtEH+kQA= Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-294-Hw8DzDMRPfS9d1SkOs-2lw-1; Wed, 21 Jul 2021 12:26:49 -0400 X-MC-Unique: Hw8DzDMRPfS9d1SkOs-2lw-1 Received: by mail-io1-f71.google.com with SMTP id p7-20020a6b63070000b029050017e563a6so1955574iog.4 for ; Wed, 21 Jul 2021 09:26:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=m+x1aVmvJEpbSpTNhe+gSPdN5GMbbTZag6bLJsVFPDU=; b=LnawvxeI8XZhuWy2oq+kRYdk6LFovumXXh95/2gBrr6bQMAN2uHLnXN2mFXz+s5RoF 4pKwpeOu7GeenCPTLFGarVj2nwDQgVyOWltOKHWDw+vkZP2l1cfr2+aOJZGR434F8CgU b5od2f+PLMex1j3ZOCQJC8q3FVzW2HOUYYEXlPo1vPISEHC2QuXOFXeNg2MGqAZhMaNE ULvwveLiBZNc6mmVOps0aUnFA2N24IcX9q8CRlhr5j1q8JgXzkQNSgfRWdXYaMHM0YtP pHTQVdkSQfAr+OE2/x/LgX5SxGs8yNEzJgnQM36GhGLtLF5NJxJpdIRbBgN82iYB5mbQ ZWag== X-Gm-Message-State: AOAM533O8vchkQTjPpK6ujbJAyPjTGg3h4yv95p7xQB3XlRkdg3DFude LXsnfn2csCTPafhaM07PHXJmgINuBfbbMZfo9tSwVoQ+XZ15/BIFAzEzd92UlgsKkFgEEbJq1M2 B7LcCOb2HC6DUMR7R72cbze9p X-Received: by 2002:a6b:fe03:: with SMTP id x3mr7853643ioh.120.1626884808828; Wed, 21 Jul 2021 09:26:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwgzuS9Yi4VtCvnXQZWmI5CguoZwANnXgiGFfIgiUSl1f7p3if1KjZl/ILBiSx0bJnXvz5BQ== X-Received: by 2002:a6b:fe03:: with SMTP id x3mr7853623ioh.120.1626884808633; Wed, 21 Jul 2021 09:26:48 -0700 (PDT) Received: from gator ([140.82.166.162]) by smtp.gmail.com with ESMTPSA id m1sm14838987iok.33.2021.07.21.09.26.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jul 2021 09:26:48 -0700 (PDT) Date: Wed, 21 Jul 2021 18:26:45 +0200 From: Andrew Jones To: Oliver Upton Subject: Re: [PATCH v3 09/12] selftests: KVM: Add support for aarch64 to system_counter_offset_test Message-ID: <20210721162645.5frobtrhtniyanng@gator> References: <20210719184949.1385910-1-oupton@google.com> <20210719184949.1385910-10-oupton@google.com> MIME-Version: 1.0 In-Reply-To: <20210719184949.1385910-10-oupton@google.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=drjones@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: kvm@vger.kernel.org, Marc Zyngier , Raghavendra Rao Anata , Peter Shier , Sean Christopherson , David Matlack , Paolo Bonzini , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Jim Mattson X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Mon, Jul 19, 2021 at 06:49:46PM +0000, Oliver Upton wrote: > KVM/arm64 now allows userspace to adjust the guest virtual counter-timer > via a vCPU device attribute. Test that changes to the virtual > counter-timer offset result in the correct view being presented to the > guest. > > Signed-off-by: Oliver Upton > --- > tools/testing/selftests/kvm/Makefile | 1 + > .../selftests/kvm/include/aarch64/processor.h | 12 +++++ > .../kvm/system_counter_offset_test.c | 54 ++++++++++++++++++- > 3 files changed, 66 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile > index 7bf2e5fb1d5a..d89908108c97 100644 > --- a/tools/testing/selftests/kvm/Makefile > +++ b/tools/testing/selftests/kvm/Makefile > @@ -96,6 +96,7 @@ TEST_GEN_PROGS_aarch64 += kvm_page_table_test > TEST_GEN_PROGS_aarch64 += set_memory_region_test > TEST_GEN_PROGS_aarch64 += steal_time > TEST_GEN_PROGS_aarch64 += kvm_binary_stats_test > +TEST_GEN_PROGS_aarch64 += system_counter_offset_test > > TEST_GEN_PROGS_s390x = s390x/memop > TEST_GEN_PROGS_s390x += s390x/resets > diff --git a/tools/testing/selftests/kvm/include/aarch64/processor.h b/tools/testing/selftests/kvm/include/aarch64/processor.h > index 27dc5c2e56b9..3168cdbae6ee 100644 > --- a/tools/testing/selftests/kvm/include/aarch64/processor.h > +++ b/tools/testing/selftests/kvm/include/aarch64/processor.h > @@ -129,4 +129,16 @@ void vm_install_sync_handler(struct kvm_vm *vm, > > #define isb() asm volatile("isb" : : : "memory") > > +static inline uint64_t read_cntvct_ordered(void) > +{ > + uint64_t r; > + > + __asm__ __volatile__("isb\n\t" > + "mrs %0, cntvct_el0\n\t" > + "isb\n\t" > + : "=r"(r)); > + > + return r; > +} > + > #endif /* SELFTEST_KVM_PROCESSOR_H */ > diff --git a/tools/testing/selftests/kvm/system_counter_offset_test.c b/tools/testing/selftests/kvm/system_counter_offset_test.c > index 7e9015770759..88ad997f5b69 100644 > --- a/tools/testing/selftests/kvm/system_counter_offset_test.c > +++ b/tools/testing/selftests/kvm/system_counter_offset_test.c > @@ -53,7 +53,59 @@ static uint64_t host_read_guest_system_counter(struct test_case *test) > return rdtsc() + test->tsc_offset; > } > > -#else /* __x86_64__ */ > +#elif __aarch64__ /* __x86_64__ */ > + > +enum arch_counter { > + VIRTUAL, > +}; > + > +struct test_case { > + enum arch_counter counter; > + uint64_t offset; > +}; > + > +static struct test_case test_cases[] = { > + { .counter = VIRTUAL, .offset = 0 }, > + { .counter = VIRTUAL, .offset = 180 * NSEC_PER_SEC }, > + { .counter = VIRTUAL, .offset = -180 * NSEC_PER_SEC }, > +}; > + > +static void check_preconditions(struct kvm_vm *vm) > +{ > + if (!_vcpu_has_device_attr(vm, VCPU_ID, KVM_ARM_VCPU_TIMER_CTRL, > + KVM_ARM_VCPU_TIMER_OFFSET_VTIMER)) > + return; > + > + print_skip("KVM_ARM_VCPU_TIMER_OFFSET_VTIMER not supported; skipping test"); > + exit(KSFT_SKIP); > +} > + > +static void setup_system_counter(struct kvm_vm *vm, struct test_case *test) > +{ > + vcpu_access_device_attr(vm, VCPU_ID, KVM_ARM_VCPU_TIMER_CTRL, > + KVM_ARM_VCPU_TIMER_OFFSET_VTIMER, &test->offset, > + true); > +} > + > +static uint64_t guest_read_system_counter(struct test_case *test) > +{ > + switch (test->counter) { > + case VIRTUAL: > + return read_cntvct_ordered(); > + default: > + GUEST_ASSERT(0); > + } > + > + /* unreachable */ > + return 0; > +} > + > +static uint64_t host_read_guest_system_counter(struct test_case *test) > +{ > + return read_cntvct_ordered() - test->offset; > +} > + > +#else /* __aarch64__ */ > > #error test not implemented for this architecture! > > -- > 2.32.0.402.g57bb445576-goog > > _______________________________________________ > kvmarm mailing list > kvmarm@lists.cs.columbia.edu > https://lists.cs.columbia.edu/mailman/listinfo/kvmarm > Reviewed-by: Andrew Jones _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFDA1C12002 for ; Wed, 21 Jul 2021 16:28:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7609F600EF for ; Wed, 21 Jul 2021 16:28:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7609F600EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N5fvGN9qcjDh1jmQoxMuj1FDnpVW6JgFZr4A5qMFuDM=; b=L+zcSk3XyyVjRa 6AVwPo3sczVDmxl2I9svz/JePPOGIGRtVkf0cLn+Ia64drSqKm/GhD+y+/XqE7m4xPZHEtO+1XJV5 ANeAmsjLgURiHPu7MpHsUpEDQLVxFlEG/nvlQasGvqboEbjUw4sKMlV7La7wIpM9LB9tDML8p3oxH MhFXFrXjIZgoBXEdqVOoyc7jCOJRSbhnJmP2sQzYtuGPR8EDtES+oDYAmhPXEqYK022CrA9Pu+XcW F6+bHHwZIHbtb1zCTueORc/xPr+Lgf7G4V56rd1ta7SHa7VFMQBKSyKc4huNfyWXsI33I6BQy0hIo EdaYrCLN1H31Y2ctTJ2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6F3h-00GZ70-N0; Wed, 21 Jul 2021 16:26:58 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6F3c-00GZ5k-Hg for linux-arm-kernel@lists.infradead.org; Wed, 21 Jul 2021 16:26:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626884811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m+x1aVmvJEpbSpTNhe+gSPdN5GMbbTZag6bLJsVFPDU=; b=CHiHl7DtJ01SHTWIVkKyk38j/UIPOpK2ylGo8zojJDwjmfMgKCSQcj20e1QyasS+Thrp7H BvO3tZ8svpVjPnNr5snQHwAzDTQ4PhNGkfY3F/uRU+1WLphrAXXG9S0iMtkVZ9P323m+lR noeNuW26JXDXr1XPSISHPF1y1Soqt5g= Received: from mail-il1-f197.google.com (mail-il1-f197.google.com [209.85.166.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-584-lEU8hWD9PR6Z6Wou5BnKgg-1; Wed, 21 Jul 2021 12:26:49 -0400 X-MC-Unique: lEU8hWD9PR6Z6Wou5BnKgg-1 Received: by mail-il1-f197.google.com with SMTP id o8-20020a92c6880000b0290214927ba4d8so1867242ilg.6 for ; Wed, 21 Jul 2021 09:26:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=m+x1aVmvJEpbSpTNhe+gSPdN5GMbbTZag6bLJsVFPDU=; b=mgFyBchZqTS/E8IinvhcaKySrQsDxUfA9/LZw4RpXbhTTVdDJM20iYoqJUudG0hM37 H/2XweEMhK6b5ebYzYopWaF+vG9X70+5UoOKEIKS/PGuHSHOtihR8lmsRqtiHGYssnk7 FVarhpoFXB89K8XRC95N1tdawcX6ZJ70Qj8VOKqp+mucyommprcfNVphH/qRDjDjPhE3 hYqFqg67vKdyUtO+h+CNJfnvzXnaQaA5oGXMvaTqlPZW23dTvg14Lm6hbU+y8vHCcbSm 6jJP+jQF9zkT1Y6C1L3TQbr3tx2fnd53tsNBOeSy12MZ+ro2SwZmjydzV66c5Ug7elr9 mIGg== X-Gm-Message-State: AOAM532SOamEtk7ImYrlBOJ+SK6LmqDDM3hU13MutFJzGUpiz/GvchY0 AaCwkRYWO3DNXqVVq+mwz7SSDoDfoy5ZThLYqvaRaq7wnCHlQ4AiV0XcxWN/EaLyHPCuuNmmlBh NUALLbTZzyKR8gZpHO6gI6V0BbaEVjFNWqj4= X-Received: by 2002:a6b:fe03:: with SMTP id x3mr7853636ioh.120.1626884808811; Wed, 21 Jul 2021 09:26:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwgzuS9Yi4VtCvnXQZWmI5CguoZwANnXgiGFfIgiUSl1f7p3if1KjZl/ILBiSx0bJnXvz5BQ== X-Received: by 2002:a6b:fe03:: with SMTP id x3mr7853623ioh.120.1626884808633; Wed, 21 Jul 2021 09:26:48 -0700 (PDT) Received: from gator ([140.82.166.162]) by smtp.gmail.com with ESMTPSA id m1sm14838987iok.33.2021.07.21.09.26.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jul 2021 09:26:48 -0700 (PDT) Date: Wed, 21 Jul 2021 18:26:45 +0200 From: Andrew Jones To: Oliver Upton Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, Marc Zyngier , Raghavendra Rao Anata , Peter Shier , Sean Christopherson , David Matlack , Paolo Bonzini , linux-arm-kernel@lists.infradead.org, Jim Mattson Subject: Re: [PATCH v3 09/12] selftests: KVM: Add support for aarch64 to system_counter_offset_test Message-ID: <20210721162645.5frobtrhtniyanng@gator> References: <20210719184949.1385910-1-oupton@google.com> <20210719184949.1385910-10-oupton@google.com> MIME-Version: 1.0 In-Reply-To: <20210719184949.1385910-10-oupton@google.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=drjones@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210721_092652_714211_B6BF957B X-CRM114-Status: GOOD ( 25.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 19, 2021 at 06:49:46PM +0000, Oliver Upton wrote: > KVM/arm64 now allows userspace to adjust the guest virtual counter-timer > via a vCPU device attribute. Test that changes to the virtual > counter-timer offset result in the correct view being presented to the > guest. > > Signed-off-by: Oliver Upton > --- > tools/testing/selftests/kvm/Makefile | 1 + > .../selftests/kvm/include/aarch64/processor.h | 12 +++++ > .../kvm/system_counter_offset_test.c | 54 ++++++++++++++++++- > 3 files changed, 66 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile > index 7bf2e5fb1d5a..d89908108c97 100644 > --- a/tools/testing/selftests/kvm/Makefile > +++ b/tools/testing/selftests/kvm/Makefile > @@ -96,6 +96,7 @@ TEST_GEN_PROGS_aarch64 += kvm_page_table_test > TEST_GEN_PROGS_aarch64 += set_memory_region_test > TEST_GEN_PROGS_aarch64 += steal_time > TEST_GEN_PROGS_aarch64 += kvm_binary_stats_test > +TEST_GEN_PROGS_aarch64 += system_counter_offset_test > > TEST_GEN_PROGS_s390x = s390x/memop > TEST_GEN_PROGS_s390x += s390x/resets > diff --git a/tools/testing/selftests/kvm/include/aarch64/processor.h b/tools/testing/selftests/kvm/include/aarch64/processor.h > index 27dc5c2e56b9..3168cdbae6ee 100644 > --- a/tools/testing/selftests/kvm/include/aarch64/processor.h > +++ b/tools/testing/selftests/kvm/include/aarch64/processor.h > @@ -129,4 +129,16 @@ void vm_install_sync_handler(struct kvm_vm *vm, > > #define isb() asm volatile("isb" : : : "memory") > > +static inline uint64_t read_cntvct_ordered(void) > +{ > + uint64_t r; > + > + __asm__ __volatile__("isb\n\t" > + "mrs %0, cntvct_el0\n\t" > + "isb\n\t" > + : "=r"(r)); > + > + return r; > +} > + > #endif /* SELFTEST_KVM_PROCESSOR_H */ > diff --git a/tools/testing/selftests/kvm/system_counter_offset_test.c b/tools/testing/selftests/kvm/system_counter_offset_test.c > index 7e9015770759..88ad997f5b69 100644 > --- a/tools/testing/selftests/kvm/system_counter_offset_test.c > +++ b/tools/testing/selftests/kvm/system_counter_offset_test.c > @@ -53,7 +53,59 @@ static uint64_t host_read_guest_system_counter(struct test_case *test) > return rdtsc() + test->tsc_offset; > } > > -#else /* __x86_64__ */ > +#elif __aarch64__ /* __x86_64__ */ > + > +enum arch_counter { > + VIRTUAL, > +}; > + > +struct test_case { > + enum arch_counter counter; > + uint64_t offset; > +}; > + > +static struct test_case test_cases[] = { > + { .counter = VIRTUAL, .offset = 0 }, > + { .counter = VIRTUAL, .offset = 180 * NSEC_PER_SEC }, > + { .counter = VIRTUAL, .offset = -180 * NSEC_PER_SEC }, > +}; > + > +static void check_preconditions(struct kvm_vm *vm) > +{ > + if (!_vcpu_has_device_attr(vm, VCPU_ID, KVM_ARM_VCPU_TIMER_CTRL, > + KVM_ARM_VCPU_TIMER_OFFSET_VTIMER)) > + return; > + > + print_skip("KVM_ARM_VCPU_TIMER_OFFSET_VTIMER not supported; skipping test"); > + exit(KSFT_SKIP); > +} > + > +static void setup_system_counter(struct kvm_vm *vm, struct test_case *test) > +{ > + vcpu_access_device_attr(vm, VCPU_ID, KVM_ARM_VCPU_TIMER_CTRL, > + KVM_ARM_VCPU_TIMER_OFFSET_VTIMER, &test->offset, > + true); > +} > + > +static uint64_t guest_read_system_counter(struct test_case *test) > +{ > + switch (test->counter) { > + case VIRTUAL: > + return read_cntvct_ordered(); > + default: > + GUEST_ASSERT(0); > + } > + > + /* unreachable */ > + return 0; > +} > + > +static uint64_t host_read_guest_system_counter(struct test_case *test) > +{ > + return read_cntvct_ordered() - test->offset; > +} > + > +#else /* __aarch64__ */ > > #error test not implemented for this architecture! > > -- > 2.32.0.402.g57bb445576-goog > > _______________________________________________ > kvmarm mailing list > kvmarm@lists.cs.columbia.edu > https://lists.cs.columbia.edu/mailman/listinfo/kvmarm > Reviewed-by: Andrew Jones _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel